bug#72013: The eshell/kill command doesn't work with eshell/sudo correctly

[Jim Porter <jporterbugs@gmail.com>]

[-- Attachment #1: Type: text/plain, Size: 719 bytes --]

On 7/14/2024 3:14 PM, Jim Porter wrote:
> On 7/10/2024 12:33 AM, Michael Albinus via Bug reports for GNU Emacs, 
> the Swiss army knife of text editors wrote:
>> Tramp ought to support signal-process (and interrupt-process). See
>> optional argument REMOTE of signal-process.
>>
>> Best regards, Michael.
> 
> Ok, I figured out why I thought Tramp didn't support 'signal-process'. 
> Elsewhere in Emacs, you can provide the signal to use like so: 
> 'SIGKILL'. However, Tramp's 'tramp-signal-process' passes the name 
> directly to the POSIX "kill" command, which expects the "SIG" to be 
> removed. Here's a patch which does this.

Whoops, we should be case-insensitive about things here. Fixed in the 
attached patch.

[-- Attachment #2: 0001-Support-passing-signals-like-SIGCODE-to-tramp-signal.patch --]
[-- Type: text/plain, Size: 1339 bytes --]

From ae65d1a5bd296c16aade42deae85e8af28089d30 Mon Sep 17 00:00:00 2001
From: Jim Porter <jporterbugs@gmail.com>
Date: Sun, 14 Jul 2024 15:07:28 -0700
Subject: [PATCH] Support passing signals like 'SIGCODE' to
 'tramp-signal-process'

POSIX specifies that "kill" should take signal names without the "SIG"
prefix.

* lisp/net/tramp.el (tramp-signal-process): Strip the "SIG" prefix when
present.
---
 lisp/net/tramp.el | 9 +++++++--
 1 file changed, 7 insertions(+), 2 deletions(-)

diff --git a/lisp/net/tramp.el b/lisp/net/tramp.el
index e8329c82743..5c7236011b8 100644
--- a/lisp/net/tramp.el
+++ b/lisp/net/tramp.el
@@ -6986,8 +6986,13 @@ tramp-signal-process
       (setq pid process
             vec (and (stringp remote) (tramp-dissect-file-name remote))))
      (t (signal 'wrong-type-argument (list #'processp process))))
-    (unless (or (numberp sigcode) (symbolp sigcode))
-      (signal 'wrong-type-argument (list #'numberp sigcode)))
+    (cond
+     ((symbolp sigcode)
+      (setq sigcode (upcase (symbol-name sigcode)))
+      (when (string-prefix-p "SIG" sigcode)
+        (setq sigcode (substring sigcode 3))))
+     ((not (numberp sigcode))
+      (signal 'wrong-type-argument (list #'numberp sigcode))))
     ;; If it's a Tramp process, send SIGCODE remotely.
     (when (and pid vec)
       (tramp-message
-- 
2.25.1