From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Drew Adams Newsgroups: gmane.emacs.bugs Subject: bug#30285: dired-do-chmod vs. top line of dired Date: Mon, 5 Feb 2018 08:45:21 -0800 (PST) Message-ID: <62b07a53-d019-4909-9d67-b8ce211b2150@default> References: <87mv0wg80c.fsf@jidanni.org> <87efm8snnr.fsf@gmail.com> <83efm8irac.fsf@gnu.org> <87d11sl08v.fsf@gmail.com> <87fu6lwxxu.fsf@mail.linkov.net> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable X-Trace: blaine.gmane.org 1517852697 20327 195.159.176.226 (5 Feb 2018 17:44:57 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Mon, 5 Feb 2018 17:44:57 +0000 (UTC) Cc: Juri Linkov , 30285@debbugs.gnu.org, jidanni@jidanni.org To: Tino Calancha Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Mon Feb 05 18:44:52 2018 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eikom-0004BH-P6 for geb-bug-gnu-emacs@m.gmane.org; Mon, 05 Feb 2018 18:44:37 +0100 Original-Received: from localhost ([::1]:42631 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eikqn-0000TC-MU for geb-bug-gnu-emacs@m.gmane.org; Mon, 05 Feb 2018 12:46:41 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:55094) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eijuA-0007lq-Iy for bug-gnu-emacs@gnu.org; Mon, 05 Feb 2018 11:46:09 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eiju6-0005Ad-Gm for bug-gnu-emacs@gnu.org; Mon, 05 Feb 2018 11:46:06 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:51056) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1eiju6-0005A7-DS for bug-gnu-emacs@gnu.org; Mon, 05 Feb 2018 11:46:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1eiju6-0005tr-4Y for bug-gnu-emacs@gnu.org; Mon, 05 Feb 2018 11:46:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Drew Adams Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 05 Feb 2018 16:46:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 30285 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 30285-submit@debbugs.gnu.org id=B30285.151784913322642 (code B ref 30285); Mon, 05 Feb 2018 16:46:02 +0000 Original-Received: (at 30285) by debbugs.gnu.org; 5 Feb 2018 16:45:33 +0000 Original-Received: from localhost ([127.0.0.1]:58953 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eijtd-0005t8-8x for submit@debbugs.gnu.org; Mon, 05 Feb 2018 11:45:33 -0500 Original-Received: from aserp2130.oracle.com ([141.146.126.79]:53986) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eijtc-0005sw-6y for 30285@debbugs.gnu.org; Mon, 05 Feb 2018 11:45:32 -0500 Original-Received: from pps.filterd (aserp2130.oracle.com [127.0.0.1]) by aserp2130.oracle.com (8.16.0.22/8.16.0.22) with SMTP id w15Gfh3o153518; Mon, 5 Feb 2018 16:45:25 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=mime-version : message-id : date : from : sender : to : cc : subject : references : in-reply-to : content-type : content-transfer-encoding; s=corp-2017-10-26; bh=FemFA6Yc+i3UeE31uMGmScF7y5KAphYUs18qDcBTwUE=; b=HlwQ282sdhzWAlXAHSyQBDuaCdyaB304ONEAlk4N4WoRUsi/rN+sZX8eYg/E+HijyJGY xU5niNj0JGjE562GtcmDa2huoGB5SakActSatzR4/1YIGUWVAy3Ewe1A5Uuk+6UnMJXO s+KTKY83kfY/OBsBr2s+/Ej5w5Yo+SxUuhiG1iFXRdxAYqAdnUj8oBRLTyKu6Ife9dCK b/mOZZEqxyX4QsQPLm0nyxx04FD2QYdsV63/mJkWBEXYRBPGb/YymrlRRBc+VN2VrpYc nD61rpli8GGwU5oaA7ZkvPmDuImjOv3L08qz818ApR7wB+313EMy0n30LP8owTZqlaUK Cg== Original-Received: from userv0022.oracle.com (userv0022.oracle.com [156.151.31.74]) by aserp2130.oracle.com with ESMTP id 2fxt490e78-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 05 Feb 2018 16:45:25 +0000 Original-Received: from aserv0122.oracle.com (aserv0122.oracle.com [141.146.126.236]) by userv0022.oracle.com (8.14.4/8.14.4) with ESMTP id w15GjNec001039 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Mon, 5 Feb 2018 16:45:24 GMT Original-Received: from abhmp0002.oracle.com (abhmp0002.oracle.com [141.146.116.8]) by aserv0122.oracle.com (8.14.4/8.14.4) with ESMTP id w15GjMJS030531; Mon, 5 Feb 2018 16:45:22 GMT In-Reply-To: X-Priority: 3 X-Mailer: Oracle Beehive Extensions for Outlook 2.0.1.9.1 (1003210) [OL 16.0.4639.0 (x86)] X-Proofpoint-Virus-Version: vendor=nai engine=5900 definitions=8796 signatures=668662 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 malwarescore=0 phishscore=0 bulkscore=0 spamscore=0 mlxscore=0 mlxlogscore=999 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1711220000 definitions=main-1802050210 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:142941 Archived-At: > >> I would like all `dired-do...' commands behave the same under the > >> 'X condition': * called from the top line ** no marked files. > > > > I've already said that it's not only about the top line. > > It's about the ordinary Dired situation of not being on a > > file line. Plenty of Dired code already deals (simply) > > with this "X condition". > > Sorry for the confussion: I thought it was prety obvious > that 'X condition' was akind of summary of what the patch > was doing. I don't think there was any confusion there. It was clear what you meant by "X condition". You said it meant: "* called from the top line [and] ** no marked files" My point was that Dired code already deals, in various places, with the condition of not being on a file line and no files being marked. That condition is easy to deal with. And I think that's the only problem that this bug report needs to fix - in the case of the commands, like `dired-do-chmod', that don't yet deal with it. > It would be as easy as to read my commit message to realize that; or > take > a quick look in the diff I provided (dont need even to test it). Then, > you would be talking about my work, not about what you guess it > is my work. For the future, please try to at least read my commit > messages before make lot of observations about one patch that you didn't > even read at all. Thanks! :-) I guess you are angry or frustrated. Sorry if I caused that. I had already said, a day or two earlier in reply to your request that I provide an alternative patch, that I'm OK with whatever you decide. I offered suggestions about this bug, and I made clear that it's up to you and I wouldn't be getting into the implementation details: > May I ask you to provide an alternative patch to compare > with mine? Then, people here might do further feedback > based on those 2 alternatives. Sorry; I don't have time to work on this. I've already provided my suggestions - hope they help. Whatever you decide is fine by me. Thx. I consider this bug to be trivial, and I hope for a simple fix that doesn't complicate Dired generally. But whatever fix you provide is OK by me. Sorry if my suggestions made you feel like I was discounting your efforts. I too have already spent more time on this bug than I can afford to. Please fix this bug as you see best. And thanks for your work on Dired and other Emacs features.