From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Yuan Fu Newsgroups: gmane.emacs.bugs Subject: bug#60044: 30.0.50; hideshow in python-ts-mode not working Date: Thu, 15 Dec 2022 17:19:49 -0800 Message-ID: <62F1EFAE-34D7-474D-80E5-43128EF69FCD@gmail.com> References: <87y1rboyin.fsf@kraus.my> Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3696.120.41.1.1\)) Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="36210"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 60044@debbugs.gnu.org To: daniel@kraus.my Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Dec 16 02:20:15 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1p5zOY-0009EO-Uj for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 16 Dec 2022 02:20:14 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1p5zOO-0008R8-UA; Thu, 15 Dec 2022 20:20:04 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p5zON-0008Qf-Pr for bug-gnu-emacs@gnu.org; Thu, 15 Dec 2022 20:20:03 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1p5zON-0001lE-6P for bug-gnu-emacs@gnu.org; Thu, 15 Dec 2022 20:20:03 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1p5zOM-0006sD-OT for bug-gnu-emacs@gnu.org; Thu, 15 Dec 2022 20:20:02 -0500 X-Loop: help-debbugs@gnu.org In-Reply-To: <87y1rboyin.fsf@kraus.my> Resent-From: Yuan Fu Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 16 Dec 2022 01:20:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 60044 X-GNU-PR-Package: emacs Original-Received: via spool by 60044-submit@debbugs.gnu.org id=B60044.167115360126411 (code B ref 60044); Fri, 16 Dec 2022 01:20:02 +0000 Original-Received: (at 60044) by debbugs.gnu.org; 16 Dec 2022 01:20:01 +0000 Original-Received: from localhost ([127.0.0.1]:46033 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p5zOL-0006rv-Eg for submit@debbugs.gnu.org; Thu, 15 Dec 2022 20:20:01 -0500 Original-Received: from mail-pj1-f47.google.com ([209.85.216.47]:44862) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p5zOJ-0006rp-H3 for 60044@debbugs.gnu.org; Thu, 15 Dec 2022 20:20:00 -0500 Original-Received: by mail-pj1-f47.google.com with SMTP id 3-20020a17090a098300b00219041dcbe9so897205pjo.3 for <60044@debbugs.gnu.org>; Thu, 15 Dec 2022 17:19:59 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=to:cc:date:message-id:subject:mime-version :content-transfer-encoding:from:from:to:cc:subject:date:message-id :reply-to; bh=yethP8cUUAXJkmxqwJ9mvHufDttb+BSbmRFfVbvq1as=; b=JNPRQE+/EHZtgPoB+nDsicJnkl7JFSekMiz2PoWzvyADAAVkM3r5ej3b38debsfoiC ZOk9EV++YtFrH5QotvmyYSBAyhMEjs4Gni5PftIVdEagi0aEn58+uMCaCNvtqtSDnLW3 ZCPtwIzrUS2eidmhqBLtAHghggK5FKuVN8dvTvd7fHq+f7i3Ms9v2K0C33sRgKw/XNq8 w2pwejCD6gy4urfts2zCKJe+wJIo05/fQkPXhSEdFox3Ap0Z8/bXJRhGbBkXVY8Z+s2c yM5VEl0s+ujXY3a9w43YRijxdR19wDY3I+uCLsYopxRfO0vNolUC2L/HSoyK3lSXJsGO x+pw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=to:cc:date:message-id:subject:mime-version :content-transfer-encoding:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=yethP8cUUAXJkmxqwJ9mvHufDttb+BSbmRFfVbvq1as=; b=Pio1rckd1Nkb3uxeAfoOIEW/3cCBL61fuUH+zmK+v/m5mJBQHZDeNRZKdZrUvOaHrS emkVNzjperNdTLtND+dbAnQNg8AaitpHZ1xa40mIPvtZowPv/AKmPlZm/I4Dp/Rdg3XT IhNKkWuliK16uXeY/XGQeX2MKtcku+3fEHnkdo2Gr9yYETTreMop2vmYiVM81Izf/OmI K9obfWnRai1fmdMOV7HSfJ0KQvFWUsUkdKHph9uJqhlelggcK8NeOVYRDU5HfH/i28x9 Z/+5imymgbSy/EuMGINrF8/LFQjzgYN+1Ocb2m88tsSA7gRg+rcOfnShu88Bed3vpEeU 0m0g== X-Gm-Message-State: ANoB5plQqYv39jSx9FzM7rq5eYtFi9Gj1wei46xqF3Pm2WwQPFGAgaOj GAIJblnBUihRr1Wue7tfnr5VI/MS28g= X-Google-Smtp-Source: AA0mqf6gXZ41iESozPwYuU2VXMov2PYHhJNfNGPh+5r430OT9dg9x3SIIn0CZo/kG524TDkToOMuZg== X-Received: by 2002:a05:6a20:2aa9:b0:ab:ee20:b003 with SMTP id v41-20020a056a202aa900b000abee20b003mr35908044pzh.14.1671153591530; Thu, 15 Dec 2022 17:19:51 -0800 (PST) Original-Received: from smtpclient.apple (cpe-172-117-161-177.socal.res.rr.com. [172.117.161.177]) by smtp.gmail.com with ESMTPSA id g7-20020a63dd47000000b0046ec7beb53esm342872pgj.8.2022.12.15.17.19.50 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Thu, 15 Dec 2022 17:19:51 -0800 (PST) X-Mailer: Apple Mail (2.3696.120.41.1.1) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:251167 Archived-At: Daniel Kraus writes: > Not sure if this is a bug report or feature request > but I use hideshow for code folding and I see that > `python-base-mode` only adds python-mode to hs-special-modes-alist: > > (add-to-list > 'hs-special-modes-alist > `(python-mode > ,python-nav-beginning-of-block-regexp > ;; Use the empty string as end regexp so it doesn't default to > ;; "\\s)". This way parens at end of defun are properly hidden. > "" > "#" > python-hideshow-forward-sexp-function > nil > python-nav-beginning-of-block > python-hideshow-find-next-block > python-info-looking-at-beginning-of-block)) > > > Simply adding the same with python-ts-mode makes hideshow work > but I guess maybe `python-nav-beginning-of-block` etc should > be replaced with the equivalent tree-sitter functions?! > Maybe it's the same with the other treesit modes, I haven't checked. > > Thanks, > Daniel Thanks for reporting this! For now I just python-ts-mode to the setup, as you suggested. In the future we will switch it to use tree-sitter. Yuan