From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.bugs Subject: bug#62749: 28.2; Emacs keeps opening related file from vc-diff buffer Date: Tue, 16 May 2023 14:46:36 +0300 Message-ID: <6241918f-0933-7086-e3e8-d2b2df62c302@gutov.dev> References: <86ttwdlffv.fsf@mail.linkov.net> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="4070"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.10.0 Cc: 62749@debbugs.gnu.org To: Juri Linkov , Oleksandr Gavenko Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue May 16 13:47:30 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pyt9M-0000mO-9B for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 16 May 2023 13:47:29 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pyt94-0005XJ-U0; Tue, 16 May 2023 07:47:11 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pyt8w-0005Wy-Ic for bug-gnu-emacs@gnu.org; Tue, 16 May 2023 07:47:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pyt8w-0001pi-AI for bug-gnu-emacs@gnu.org; Tue, 16 May 2023 07:47:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pyt8w-00044V-6B for bug-gnu-emacs@gnu.org; Tue, 16 May 2023 07:47:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Dmitry Gutov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 16 May 2023 11:47:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 62749 X-GNU-PR-Package: emacs Original-Received: via spool by 62749-submit@debbugs.gnu.org id=B62749.168423760815611 (code B ref 62749); Tue, 16 May 2023 11:47:02 +0000 Original-Received: (at 62749) by debbugs.gnu.org; 16 May 2023 11:46:48 +0000 Original-Received: from localhost ([127.0.0.1]:45411 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pyt8h-00043j-Vq for submit@debbugs.gnu.org; Tue, 16 May 2023 07:46:48 -0400 Original-Received: from out5-smtp.messagingengine.com ([66.111.4.29]:60683) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pyt8f-00043V-N1 for 62749@debbugs.gnu.org; Tue, 16 May 2023 07:46:47 -0400 Original-Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.nyi.internal (Postfix) with ESMTP id 935DB5C01E9; Tue, 16 May 2023 07:46:39 -0400 (EDT) Original-Received: from mailfrontend1 ([10.202.2.162]) by compute4.internal (MEProxy); Tue, 16 May 2023 07:46:39 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gutov.dev; h=cc :cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to; s=fm2; t= 1684237599; x=1684323999; bh=iOYcOAgibeGFX+xwPHkINDGN7fE5icAlMKx 12+IMubo=; b=ZiVP9tfxDPT2MXpyT5sTMhrs6BRyFW0+MRgHfuEg9mQx6AyNvzf G5JjZfSe9MPmEw/NOkD/6z1v5ZrgAocOAfYQU0AwaJxL7FDcsH8BTPboqdDqcq/M gcniX/GcH9wIKYFwMH55EoxoQeaEoHCT71wwsx6WFf4ARmiKdUXJaeFfclwgEpcm 6D3STsc6fKKoocvFZRhHZO3MVVwo9L5FkC/sDCtmipoHwyU+PN4RFHFW5IZEP3YM GLUr+MwIwljDGtxa8CY1Yt1kufVZdVKTywCXbnnSx7AKVpZ4HJRFKw8SB2MIu5IW 8o9JT2Bie0SAEuhYluIoELwPby4+Pk/5dow== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t= 1684237599; x=1684323999; bh=iOYcOAgibeGFX+xwPHkINDGN7fE5icAlMKx 12+IMubo=; b=bhN35Q4fD2/l2j1dEZqESykjGpezRKKRAe939wjE9OE2rDkX8dO 7lsY1ZuYaQCyMWxTFs5X2/j5enBUzjUp5kn/WuxZxtgvVc3I3v+F0QJHPsaPKpSg MpVmedFoycuJIi0w0ckKYsFgJwrOdwB4tPHxKPHZnwQFWDvJagMg9fq0b23V4Y/N hE3CGE9N+yyyHMTOy6kTEl8RhxG86d4sz8O6YBry5AKdQb+T3nz7KACXCH2caCf6 gR3Mdim5p6MtHCB0pQpRnFqHvxEiHboUQGnM5VYsIEI/mwmHk0xXth0Yh5zYByK5 5T15WeESf4GU/yORg+V9w7lZmaGJtcZf3Yg== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrfeehledggeegucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepkfffgggfuffvvehfhfgjtgfgsehtjeertddtfeejnecuhfhrohhmpeffmhhi thhrhicuifhuthhovhcuoegumhhithhrhiesghhuthhovhdruggvvheqnecuggftrfgrth htvghrnhepiefgteevheevveffheeltdeukeeiieekueefgedugfefgefhudelgfefveel vdevnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepug hmihhtrhihsehguhhtohhvrdguvghv X-ME-Proxy: Feedback-ID: i0e71465a:Fastmail Original-Received: by mail.messagingengine.com (Postfix) with ESMTPA; Tue, 16 May 2023 07:46:38 -0400 (EDT) Content-Language: en-US In-Reply-To: <86ttwdlffv.fsf@mail.linkov.net> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:261783 Archived-At: On 15/05/2023 19:46, Juri Linkov wrote: >> After bisecting my long .emacs config I pinpointed the culprit: >> >> (which-func-mode 1) >> >> During the movement through a diff buffer this mode loads corresponding >> files: >> >> if the cursor reaches a new hunk - the corresponding file is opened (( >> >> This is done one by one file while I scroll down with the cursor. >> >> Removing the line significantly improved performance during scromming in VC >> diff buffer in Cygwin and no more new files opened! > This is an interesting problem, I can reproduce it by > 'M-x which-function-mode'. > >> I think which-function-mode is broken for diff-mode, the workaround for >> those who wants this mode is to deal with: >> >> (defcustom which-func-modes t >> ;; '(emacs-lisp-mode c-mode c++-mode objc-mode perl-mode cperl-mode python-mode >> ;; makefile-mode sh-mode fortran-mode f90-mode ada-mode >> ;; diff-mode) >> "List of major modes for which Which Function mode should be used. >> For other modes it is disabled. If this is equal to t, >> then Which Function mode is enabled in any major mode that supports it." >> >> What are the next actions? > Maybe 'diff-syntax-fontify' could have a similar list of minor modes > that should be ignored. Then such a list should at least contain > 'which-func-mode' by default. Do you mean that it's not feasible to fix the behavior when which-func-mode is enabled?