From mboxrd@z Thu Jan  1 00:00:00 1970
From: Carsten Dominik <carsten.dominik@gmail.com>
Subject: Re: [PATCH] Removed unecessary invocations of org-agenda-show.
Date: Mon, 4 Oct 2010 06:22:50 +0200
Message-ID: <62316513-0AF8-4F39-A770-475C76DFB790@gmail.com>
References: <87zkvly3m3.fsf@archdesk.localdomain>
	<C2234DC7-1A63-4EB1-8CFC-8579CA7B249B@gmail.com>
	<878w329v2i.fsf@archdesk.localdomain>
Mime-Version: 1.0 (Apple Message framework v936)
Content-Type: text/plain; charset=US-ASCII; format=flowed; delsp=yes
Content-Transfer-Encoding: 7bit
Return-path: <emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org>
Received: from [140.186.70.92] (port=55437 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1P2ccA-0000xR-VG
	for emacs-orgmode@gnu.org; Mon, 04 Oct 2010 00:25:27 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <carsten.dominik@gmail.com>) id 1P2cZj-00080f-A5
	for emacs-orgmode@gnu.org; Mon, 04 Oct 2010 00:22:56 -0400
Received: from mail-ew0-f41.google.com ([209.85.215.41]:34992)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <carsten.dominik@gmail.com>) id 1P2cZj-00080N-5G
	for emacs-orgmode@gnu.org; Mon, 04 Oct 2010 00:22:55 -0400
Received: by ewy19 with SMTP id 19so2130877ewy.0
	for <emacs-orgmode@gnu.org>; Sun, 03 Oct 2010 21:22:54 -0700 (PDT)
In-Reply-To: <878w329v2i.fsf@archdesk.localdomain>
List-Id: "General discussions about Org-mode." <emacs-orgmode.gnu.org>
List-Unsubscribe: <http://lists.gnu.org/mailman/listinfo/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/emacs-orgmode>
List-Post: <mailto:emacs-orgmode@gnu.org>
List-Help: <mailto:emacs-orgmode-request@gnu.org?subject=help>
List-Subscribe: <http://lists.gnu.org/mailman/listinfo/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=subscribe>
Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org
Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org
To: Matthew Lundin <mdl@imapmail.org>
Cc: org-mode List <emacs-orgmode@gnu.org>


On Sep 16, 2010, at 6:22 AM, Matthew Lundin wrote:

> Hi Carsten,
>
> Carsten Dominik <carsten.dominik@gmail.com> writes:
>
>> On Sep 13, 2010, at 6:48 PM, Matt Lundin wrote:
>>
>>>
>>> lisp/org-agenda.el (org-agenda-set-tags): Remove org-agenda-show to
>>> prevent
>>> disrupting windows and changing point in original buffer.
>>> (org-agenda-set-property): Same
>>> (org-agenda-set-effort): Same
>>> (org-agenda-toggle-archive-tag): Same
>>>
>>> When setting a tag in the agenda, org-mode displays the  
>>> corresponding
>>> entry in the original org buffer by calling org-agenda-show. This  
>>> has
>>> the unwelcome side-effect of disrupting the current window  
>>> arrangement
>>> and changing the position of the point in the original buffer. This
>>> behavior is inconsistent with the that of org-agenda-todo, which  
>>> makes
>>> all its changes "silently."
>>
>> I agree, but I am sure I used to have problems with something
>> which is why this was added.
>> Have you been running this patch for some time already?
>> Without any problems like the agenda jumping to a wrong place in a  
>> org
>> file or so?
>
> I haven't yet encountered any deleterious side effects, but I agree  
> that
> this patch needs further consideration. I will do some additional
> research/testing and return with a report. :)

Hi Matt,

any new about this patch?

Thanks

- Carsten