From: Dmitry Gutov <dmitry@gutov.dev>
To: Eshel Yaron <me@eshelyaron.com>
Cc: Eli Zaretskii <eliz@gnu.org>, 68958@debbugs.gnu.org
Subject: bug#68958: [PATCH] Support bookmarking Xref results buffers
Date: Thu, 15 Feb 2024 19:57:08 +0200 [thread overview]
Message-ID: <622b208a-6e2a-4f47-b243-40846ec48df1@gutov.dev> (raw)
In-Reply-To: <m18r3ou9dx.fsf@dazzs-mbp.home>
On 13/02/2024 09:10, Eshel Yaron wrote:
> Dmitry Gutov <dmitry@gutov.dev> writes:
>
>> On 12/02/2024 13:45, Eshel Yaron wrote:
>>
>>> I agree that redundant complexity is better avoided, but this is the
>>> simplest compatible extension to the API I came up with to implement
>>> this feature.
>>
>> If we're going to recommend the callers use the new capability, I'd
>> rather they didn't have to be redundant every time.
>
> Often callers can use xref-make-fetcher to make the fetcher function,
> and that takes care of the redundant work for them. That's was I did
> for project-find-regexp and friends in my working branch, works well :)
>
> [ BTW, while at it, I noticed that the docstring for
> project-or-external-find-regexp mentions a prefix argument, but the
> function doesn't actually handle one. ]
Thank you for noting, now fixed.
>> Though I'm not sure whether the fetcher should reach
>> xref-show-xrefs-function intact (simpler code, but a breakage in the
>> interface, which could be mended with catching
>> wrong-number-of-arguments), or like in this example, both the original
>> fetcher and the arguments should be passed through alist.
>>
>> Otherwise, the requirements on the arguments are the same (fetcher --
>> named function, args -- printability).
>
> That might work, although it seems rather difficult to explain such
> requirements, and it's difficult for callers to ensure or even check
> whether they're kept (how do you know if your argument is too big
> without printing it in advance?)
You can usually track that on the level of user input. A good rule of
thumb would be not to pass a generated list of files. And if some user's
interactive input string is veeeeeery long, well, whatever disk space is
wasted as a result is their own doing.
What's the alternative, though? Writing a separate bookmark storage
function for every sort of search? For project, lsp-mode/eglot (they
both have additional commands doing extra searches), etc?
And the return value of xref-backend-context (from your proposal) must
likewise be print-able and compact enough, right?
> Furthermore, IIUC, what you get is an opaque function and argument list,
> and the frontend cannot reason about these, it can only apply the
> function to these arguments to get a list of xrefs. In contrast,
> xref-fetcher-alist provides clear (documented) semantics.
Which will only work for Xref's own commands but not for any external
callers of xref-show-xrefs. Right?
> We use it for
> bookmarking first and foremost, but the frontend can legitimately use it
> for other stuff too, like showing some info in the mode line.
>
>> Also, I'm not sure how we're supposed to guarantee that
>> xref--original-buffer is live.
>
> In my patch, we don't guarantee that (see xref-bookmark-make-record).
> And that's fine, it's a best effort to give the backend all the context
> it might need. If there's no original buffer, we just don't save and
> restore that bit of context.
Okay, I see that. Basically, you bookmark the "original point" and then
restore it from xref-backend-restore. So this would work, most of the time.
> The backend can handle a nil CONTEXT
> argument in xref-backend-restore however it sees fit. By default, it
> does nothing.
I don't any LSP backend could handle nil, though. It would need
additional data, like the origin file name, the value of point, etc.
>> Is that for use with desktop-mode only?
>
> What do you mean? To be clear, this is unrelated to desktop-mode, or at
> least I didn't design/implement any of this with desktop-mode in mind.
I meant that if you require the original buffer to be available when the
bookmark is loaded, the easiest way to satisfy that is for desktop-mode
to be used. But I see you solved that in a different way.
>> And it seems like as soon as the buffer has some new changes, the
>> bookmark is likely to become invalid (the same value of point will
>> point to a different identifier).
>
> We don't keep the value of point as such, we use the standard bookmark
> facilities to save some context around point so we can relocate to the
> right place if something changes. If we can't find that context when
> restoring the bookmark, point is just left at the beginning of the
> *xref* buffer. That's also fine. Does that make sense?
I meant the position of point in the original buffer, not in the Xref
buffer, which is required for the Xref searches to work in LSP backends.
I suppose the same bookmark mechanism would be used, too, though.
next prev parent reply other threads:[~2024-02-15 17:57 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-06 20:17 bug#68958: [PATCH] Support bookmarking Xref results buffers Eshel Yaron via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-02-07 12:25 ` Eli Zaretskii
2024-02-07 17:04 ` Eshel Yaron via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-02-11 3:27 ` Dmitry Gutov
2024-02-11 6:18 ` Eshel Yaron via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-02-11 11:13 ` Eshel Yaron via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-02-11 15:34 ` Dmitry Gutov
2024-02-11 17:21 ` Eshel Yaron via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-02-11 23:01 ` Dmitry Gutov
2024-02-12 11:45 ` Eshel Yaron via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-02-13 3:18 ` Dmitry Gutov
2024-02-13 7:10 ` Eshel Yaron via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-02-14 7:14 ` Juri Linkov
2024-02-15 17:57 ` Dmitry Gutov [this message]
2024-02-15 21:49 ` Eshel Yaron via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-02-15 7:58 ` Juri Linkov
2024-02-15 9:28 ` Eshel Yaron via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-02-07 17:25 ` Juri Linkov
2024-02-11 3:21 ` Dmitry Gutov
2024-02-11 17:37 ` Juri Linkov
2024-02-11 22:45 ` Dmitry Gutov
2024-02-12 18:31 ` Juri Linkov
2024-02-12 18:40 ` Dmitry Gutov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=622b208a-6e2a-4f47-b243-40846ec48df1@gutov.dev \
--to=dmitry@gutov.dev \
--cc=68958@debbugs.gnu.org \
--cc=eliz@gnu.org \
--cc=me@eshelyaron.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.