From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Mauro Aranda Newsgroups: gmane.emacs.bugs Subject: bug#13476: 24.3.50; Reverting scroll-bar face customization has no effect Date: Mon, 28 Feb 2022 09:59:15 -0300 Message-ID: <621cc726.1c69fb81.61de0.dd5b@mx.google.com> References: <87d2x4oyfv.fsf@rosalinde.fritz.box> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="5629"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 13476@debbugs.gnu.org, stephen.berman@gmx.net To: Po Lu Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Feb 28 14:01:40 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nOfel-0001LW-Tq for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 28 Feb 2022 14:01:39 +0100 Original-Received: from localhost ([::1]:50940 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nOfej-0002r0-OW for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 28 Feb 2022 08:01:37 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:53094) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nOfdD-0002Kr-SI for bug-gnu-emacs@gnu.org; Mon, 28 Feb 2022 08:00:05 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:38324) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nOfdC-0000DI-UX for bug-gnu-emacs@gnu.org; Mon, 28 Feb 2022 08:00:03 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1nOfdC-000511-SZ for bug-gnu-emacs@gnu.org; Mon, 28 Feb 2022 08:00:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Mauro Aranda Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 28 Feb 2022 13:00:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 13476 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: fixed Original-Received: via spool by 13476-submit@debbugs.gnu.org id=B13476.164605316619202 (code B ref 13476); Mon, 28 Feb 2022 13:00:02 +0000 Original-Received: (at 13476) by debbugs.gnu.org; 28 Feb 2022 12:59:26 +0000 Original-Received: from localhost ([127.0.0.1]:60454 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nOfcb-0004ze-Tj for submit@debbugs.gnu.org; Mon, 28 Feb 2022 07:59:26 -0500 Original-Received: from mail-ot1-f53.google.com ([209.85.210.53]:47005) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nOfca-0004zQ-CD for 13476@debbugs.gnu.org; Mon, 28 Feb 2022 07:59:24 -0500 Original-Received: by mail-ot1-f53.google.com with SMTP id p12-20020a05683019cc00b005af1442c9e9so9371231otp.13 for <13476@debbugs.gnu.org>; Mon, 28 Feb 2022 04:59:24 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=message-id:from:to:cc:subject:in-reply-to:date:mime-version; bh=O5z6dauuhj+2k8BwI7CSsy3wktZS2vqAoQ8FnrugSXM=; b=SuHwk/uksu+VkpOsWOdbFYOPaUAiDGRxpKujpes27R8D9xPOHT3Z6ypXsSEkTUNMo6 ScZGZuw8NGxynuTsoZD2ywigb5V7tLS4vKOWQAeYhY7ZFa3o1Xsf/RFvWCm1r6GbbF55 LVwcKsfeWOHt9Xq9/HahnJZDgazhJd63cxpcr2WoO/TbK1/8H1CnLKlYNR/1/8aasqCr P61gZz1dh3fqmTqB4z7wDW9J145BplRoFIn1pTX1ergBdCK4ydifTnSZJtx/EgwOwQZ0 ImxaEolMiNLFTIuGhjry7Wl1BbHlsDlq+vmHsDDFXjDbyCvtyl8//xxoMa/EiP2uxnbl N+vw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:from:to:cc:subject:in-reply-to:date :mime-version; bh=O5z6dauuhj+2k8BwI7CSsy3wktZS2vqAoQ8FnrugSXM=; b=Ub92oL64lNAk1kxf5ICpDPkbh7dCcPN9aUgXsG6PV5zE5U9+lBPXt875coB6dRNuRw Qc5YqnHh4rAfeFwZG7SSUbC9Xyz2VxJa8+rz3gwPxz9dbol0VtlMTnKG+yfuP//+lVai DQ+VvVcYcQMEsO5Y3OfT6T7i27T1dZ/kemvlKYqG+DEro+tS8dPYb/Q4GB7H+5o7Dyus yzE7MSoNFqMRUTgtgheXNl/QSFaSDwGxYw8L24bMUkIsyoPnG1MeHnshit1xLqVfDtgc eVN0zZIzIg1OwSQRMwSJxMVbfdxm2xsDRUzq8Ib2mi/E/n1Wu4X9LcgDL5auEdpy9EOT C/Zg== X-Gm-Message-State: AOAM530cdFiqScP4upQrO+GwMG6y5Hu9uz1C6n6KEAOvfwAxYGfFHsZ8 DuZsrRP5tRCM0eseXvXJqp4= X-Google-Smtp-Source: ABdhPJyMcnTvm+Y8iaJ55vuLJa4SqTHVHBt1kXggCHv4z5vO6GJe+h0uKHNKozzkJOphy2DqMVj1lw== X-Received: by 2002:a05:6830:1c62:b0:5ad:364d:5e9c with SMTP id s2-20020a0568301c6200b005ad364d5e9cmr9017917otg.164.1646053158587; Mon, 28 Feb 2022 04:59:18 -0800 (PST) Original-Received: from tbb-desktop ([181.29.189.16]) by smtp.gmail.com with ESMTPSA id o23-20020a9d2217000000b005ad54e6064csm4936874ota.66.2022.02.28.04.59.17 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Mon, 28 Feb 2022 04:59:18 -0800 (PST) X-Google-Original-Message-ID: <87y21vp2os.fsf@maurooaranda@gmail.com> In-Reply-To: <87mtib40jq.fsf@yahoo.com> (message from Po Lu on Mon, 28 Feb 2022 20:51:05 +0800) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:227800 Archived-At: Po Lu writes: > Mauro Aranda writes: > >> It would have been nice to see the patch posted here. > > branch: master > commit 66899628f8a8c79ca8dfe32094f11a8320630fae > Author: Po Lu > Commit: Po Lu > > Better fix for bug#13476 > > * lisp/faces.el (face-spec-recalc): Apply scroll bar foreground > and background to the frame if changing the scroll-bar face. > (scroll-bar): Restore previous declaration. That way, the > default colors are used for toolkit scroll bars, instead of > black and white. > --- > lisp/faces.el | 15 ++++++++++----- > 1 file changed, 10 insertions(+), 5 deletions(-) > > diff --git a/lisp/faces.el b/lisp/faces.el > index 76da210280..4b582ac439 100644 > --- a/lisp/faces.el > +++ b/lisp/faces.el > @@ -1743,7 +1743,14 @@ The following sources are applied in this order: > (and tail (face-spec-set-2 face frame > (list :extend (cadr tail)))))) > (setq face-attrs (face-spec-choose (get face 'face-override-spec) frame)) > - (face-spec-set-2 face frame face-attrs))) > + (face-spec-set-2 face frame face-attrs) > + (when (and (fboundp 'set-frame-parameter) ; This isn't available > + ; during loadup. > + (eq face 'scroll-bar)) > + ;; Set the `scroll-bar-foreground' and `scroll-bar-background' > + ;; frame parameters. (bug#13476) > + (set-frame-parameter frame 'scroll-bar-foreground (face-foreground face)) > + (set-frame-parameter frame 'scroll-bar-background (face-background face))))) > > (defun face-spec-set-2 (face frame face-attrs) > "Set the face attributes of FACE on FRAME according to FACE-ATTRS. > @@ -2826,11 +2833,9 @@ used to display the prompt text." > :group 'frames > :group 'basic-faces) > > -(defface scroll-bar > - '((((background light)) :foreground "black") > - (((background dark)) :foreground "white")) > +(defface scroll-bar '((t nil)) > "Basic face for the scroll bar colors under X." > - :version "28.1" > + :version "21.1" > :group 'frames > :group 'basic-faces) Thank you.