From: Dmitry Gutov <dmitry@gutov.dev>
To: "João Távora" <joaotavora@gmail.com>
Cc: 62029@debbugs.gnu.org, Yuan Fu <casouri@gmail.com>
Subject: bug#62029: 29.0.60; Allow users to customize eldoc buffer separator
Date: Wed, 12 Apr 2023 04:38:28 +0300 [thread overview]
Message-ID: <61fd5d66-ca0b-f67d-df70-7906c32596de@gutov.dev> (raw)
In-Reply-To: <871qkqmzit.fsf@gmail.com>
On 11/04/2023 14:25, João Távora wrote:
> Dmitry Gutov <dmitry@gutov.dev> writes:
>
>> On 30/03/2023 11:13, João Távora wrote:
>>
>>>>> You do need to set eldoc-documentation-strategy to
>>>>> eldoc-documentation-compose though (this should really
>>>>> be the default).
>>>>
>>>> Huh, I wonder why I can see both flymake + eglot in the eldoc doc
>>>> buffer when my eldoc-documentation-strategy is the default value?
>>> Because Eglot changes eldoc-documentation-strategy automatically.
>>> It
>>> shouldn't but the default value is really bad.
>>> The reason the default value is historic. Previously, there was a
>>> single producer of ElDoc, and only in Emacs Lisp. It would decide
>>> whether to show variable _or_ function doc, even if a given symbol had
>>> more than one meaning. So what's the problem with setting
>>> eldoc-documentation-strategy something like e-d-compose, you ask.
>>> Well, because of the default value of
>>> eldoc-echo-area-use-multiline-p,
>>> people would be seeing "bouncing" in the echo area while editing Elisp,
>>> which is something they are not used to.
>>> I think a very good solution is to set e-d-strategy to e-d-compose
>>> globally and e-e-a-use-multiline-p to 1 in emacs-lisp-mode.
>>> I once proposed this in this bug tracker, but the message was
>>> garbled by
>>> some side discussion, and I gave up. And ElDoc wasn't so powerful then.
>>
>> Last time I tested Eglot's behavior (recently),
>
> How "recently"? Does it have this commit?
>
> commit d00e05daa96700860dbb9dc6527105e464ffb960
> Author: João Távora <joaotavora@gmail.com>
> Date: Sat Mar 25 19:53:14 2023 +0000
>
> Eglot: take advantage of new Eldoc options for signature doc
>
> Only echo the "active signature", send all the other signatures for
> the *eldoc* buffer.
>
> * lisp/progmodes/eglot.el (eglot--sig-info): Rework protocol.
> (eglot-signature-eldoc-function): Rework.
>
> This is also in the latest released Eglot 1.14, btw.
I retested it just yesterday (and now as well), to take that screenshot.
But that was Emacs 29. With current master, it is indeed better.
>> Eldoc took away half the window to display the overloads of a
>> function's signature. Screenshot attached.
>
> This is exactly what I've been working on and discussing with Yuan and
> others, so I'm pretty familiar with the situation.
>> That doesn't look like good behavior to me, no matter the language or
>> IDE package used.
>
> I agree, and this is why I changed it. Let's hope noone complains
> (unlikely, but possible, as this changed longstanding behaviour).
>
> But here I was describing something not related to Eglot at all, rather
> elisp-mode.el. Do you have something to say about that? Did you try
> the patch I showed Yuan?
I have applied it. What should I be looking at?
next prev parent reply other threads:[~2023-04-12 1:38 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-07 7:56 bug#62029: 29.0.60; Allow users to customize eldoc buffer separator Yuan Fu
2023-03-08 0:25 ` bug#62030: " Yuan Fu
2023-03-08 17:14 ` bug#62029: " João Távora
2023-03-08 21:28 ` Yuan Fu
2023-03-23 21:33 ` João Távora
2023-03-24 0:12 ` Yuan Fu
2023-03-24 17:44 ` João Távora
2023-03-25 3:04 ` Yuan Fu
2023-03-25 8:10 ` João Távora
2023-03-30 5:22 ` Yuan Fu
2023-03-30 8:13 ` João Távora
2023-03-30 8:25 ` Yuan Fu
2023-04-11 0:04 ` Dmitry Gutov
2023-04-11 11:25 ` João Távora
2023-04-12 1:38 ` Dmitry Gutov [this message]
2023-04-12 11:06 ` João Távora
2023-04-13 0:20 ` Dmitry Gutov
2023-04-13 4:20 ` Yuan Fu
2023-04-13 9:50 ` João Távora
2023-04-13 10:11 ` João Távora
2023-04-13 10:48 ` João Távora
2023-04-13 21:53 ` Dmitry Gutov
2023-04-13 22:13 ` Dmitry Gutov
2023-04-13 23:01 ` João Távora
2023-04-13 23:26 ` Dmitry Gutov
2023-04-14 0:04 ` João Távora
2023-04-14 23:50 ` Dmitry Gutov
2023-04-15 9:41 ` João Távora
2023-10-23 1:39 ` Dmitry Gutov
2023-04-18 0:47 ` Dmitry Gutov
2023-04-18 11:17 ` João Távora
2023-04-18 23:05 ` Dmitry Gutov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=61fd5d66-ca0b-f67d-df70-7906c32596de@gutov.dev \
--to=dmitry@gutov.dev \
--cc=62029@debbugs.gnu.org \
--cc=casouri@gmail.com \
--cc=joaotavora@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.