From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Jim Porter Newsgroups: gmane.emacs.devel Subject: Re: master 7f631a3e2ac: Allow using multiple buffers in 'eshell-command' Date: Sat, 6 Jul 2024 12:47:30 -0700 Message-ID: <61d599b4-2235-091c-6623-a090d48e93d9@gmail.com> References: <172023408734.9826.6615246233994903888@vcs2.savannah.gnu.org> <20240706024807.B74E4C1FB6A@vcs2.savannah.gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="34719"; mail-complaints-to="usenet@ciao.gmane.io" Cc: emacs-devel@gnu.org To: Stefan Kangas , Thierry Volpiatto Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sat Jul 06 21:48:17 2024 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1sQBOK-0008pa-Nf for ged-emacs-devel@m.gmane-mx.org; Sat, 06 Jul 2024 21:48:16 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sQBNk-0006wL-Sh; Sat, 06 Jul 2024 15:47:40 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sQBNj-0006wB-8x for emacs-devel@gnu.org; Sat, 06 Jul 2024 15:47:39 -0400 Original-Received: from mail-il1-x12d.google.com ([2607:f8b0:4864:20::12d]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sQBNh-0005DM-R1 for emacs-devel@gnu.org; Sat, 06 Jul 2024 15:47:39 -0400 Original-Received: by mail-il1-x12d.google.com with SMTP id e9e14a558f8ab-382458be739so12617085ab.1 for ; Sat, 06 Jul 2024 12:47:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1720295252; x=1720900052; darn=gnu.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:mime-version:date:message-id:from:to:cc :subject:date:message-id:reply-to; bh=aRaOjxn0DjIM0OSTL8fPkvAIEqG6mFLRLVVy4xfn/+4=; b=DUjpbrppZ3Tj+mTfHmJM0BXX0FhaBDTVSHffJqBC01KgEO7A5MxHgMP56ra7xRaVBI W0/6CuPCaR39dFUVwVmYGscDSRGI2aE8ZbJVlHsk9Ya37tg8ENOFBfmEFaf90wEP69wQ D3e6oaMoUWbObd9Se5zB2n9uqw+1jbETK9lPtg2m1pv6WZLELHEBsrhawGUdvYc6Qend sHn0AloWXI5wO34EloXti1rB326j7f94DKmLAulTAhCC6maWFJfkmgmKt0SdyomDZS5Y IQ9ZSkZm6cA3r2NmyEVPSTV1t2HMYYMDOUpVwnr5MSCX21dC2WuNFWqYsuj80xYf8IHy 558A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1720295252; x=1720900052; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=aRaOjxn0DjIM0OSTL8fPkvAIEqG6mFLRLVVy4xfn/+4=; b=hqhr01biOismUmSks29qWFTET5JU28z6fo3/G7wasqkKXAequKw7LSHn+RLh0mMPh7 35I71yfbTxeEwTFLp6EuzE6oGaHBpynjHAl6taJetHfT4WU+U8lWIx6jp5qWAIOYqAwO geMVbEOyAZ+sh7i3JezWpTzlgYamiQaxql2cOJyKAhpVRvL8QgXAfk4xNJ5q+KI07u8H NdtwoPWBzMT/YSADHdbsYd8tJHVYuLbDygNOCasMtKraut1n8DlgCd5Sf8WN+NpCK3xI tWmfo2dqD0CrfhttPHMUZ9gmxz6JjGASfH1qzopbe2A+Ht+NBWJr2M5nhBnFM/wbibXb TNWw== X-Gm-Message-State: AOJu0YwOGUM11LY1DTs/zhTpb6y7UB+X/sDjTPKO3yEbjJwV96pjMSr+ R46NzTaiQ3bblXoouCUqPcAF26yZAsLNXIbdNsoklc+t+ZWfqzp0h3akuw== X-Google-Smtp-Source: AGHT+IGdElzg6XcAOxDAmcSCxd5prXO3xs7x66Wf9nXs+J/MCOs+KPdgGpbTLLjrdnifktKgHG9oMA== X-Received: by 2002:a05:6e02:1a61:b0:376:44be:59 with SMTP id e9e14a558f8ab-3839b18fb28mr95244035ab.31.1720295252426; Sat, 06 Jul 2024 12:47:32 -0700 (PDT) Original-Received: from [192.168.1.2] (syn-023-240-098-037.res.spectrum.com. [23.240.98.37]) by smtp.googlemail.com with ESMTPSA id 41be03b00d2f7-72c69b53e6dsm12850476a12.5.2024.07.06.12.47.31 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 06 Jul 2024 12:47:31 -0700 (PDT) Content-Language: en-US In-Reply-To: Received-SPF: pass client-ip=2607:f8b0:4864:20::12d; envelope-from=jporterbugs@gmail.com; helo=mail-il1-x12d.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:321460 Archived-At: On 7/6/2024 10:15 AM, Stefan Kangas wrote: > Jim Porter writes: > >> branch: master >> commit 7f631a3e2aca97e95b8659c902c25ab21f084e08 >> Author: Thierry Volpiatto >> Commit: Jim Porter >> >> Allow using multiple buffers in 'eshell-command' [snip] > This new test is failing here: Hm, I can't reproduce that, but I'm guessing it's a race condition with the process sentinel. Does this make the test pass for you? ---------------------------------------- diff --git a/lisp/eshell/eshell.el b/lisp/eshell/eshell.el index 568f6745067..6c79f753d6f 100644 --- a/lisp/eshell/eshell.el +++ b/lisp/eshell/eshell.el @@ -357,8 +357,8 @@ eshell-command (with-current-buffer bufname ;; Stop all the processes in the old buffer (there may ;; be several). - (eshell-process-interact #'interrupt-process t)) - (accept-process-output) + (eshell-process-interact #'interrupt-process t) + (eshell-wait-for-process (mapcar #'car eshell-process-list))) (kill-buffer bufname)) ((eq eshell-command-async-buffer 'confirm-new-buffer) (shell-command--same-buffer-confirm "Use a new buffer")