all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Daiki Ueno <ueno@unixuser.org>
Cc: wilde@sha-bang.de, wk@gnupg.org, ken.manheimer@gmail.com,
	emacs-devel@gnu.org
Subject: Re: Documenting gpg-agent
Date: Tue, 26 Dec 2006 10:01:45 +0900	[thread overview]
Message-ID: <61d457d1-ee81-47bb-8cea-b49d840df05d@well-done.deisui.org> (raw)
In-Reply-To: <E1Gyt4c-0005JD-8J@fencepost.gnu.org> (Richard Stallman's message of "Mon, 25 Dec 2006 11:53:14 -0500")

>>>>> In <E1Gyt4c-0005JD-8J@fencepost.gnu.org> 
>>>>>	Richard Stallman <rms@gnu.org> wrote:
>     Since allout exploits the use of PGG's passphrase handling functions to
>     provide a custom passphrase handling, it's not a bug in PGG or gpg-agent,
>     I think.

> I am not convinced of that.  He says that PGG was ignoring the
> passphrases that allout passes in.  Why isn't that a bug?

I'm sorry for that I misunderstood his explanation and the current
gpg-agent support of PGG.  I just looked at the code and found it
actually has a bug.  PGG checks whether to use a given passphrase or
gpg-agent two times, for the first time a given passphrase wins, but for
the second time gpg-agent wins.  Here is a tiny patch to fix this.

Sascha, can you check this?

Index: lisp/pgg-gpg.el
===================================================================
RCS file: /sources/emacs/emacs/lisp/pgg-gpg.el,v
retrieving revision 1.19
diff -c -r1.19 pgg-gpg.el
*** lisp/pgg-gpg.el	17 Dec 2006 23:18:36 -0000	1.19
--- lisp/pgg-gpg.el	26 Dec 2006 01:00:29 -0000
***************
*** 61,67 ****
    "GnuPG ID of your default identity.")
  
  (defun pgg-gpg-process-region (start end passphrase program args)
!   (let* ((use-agent (pgg-gpg-use-agent-p)) 
  	 (output-file-name (pgg-make-temp-file "pgg-output"))
  	 (args
  	  `("--status-fd" "2"
--- 61,67 ----
    "GnuPG ID of your default identity.")
  
  (defun pgg-gpg-process-region (start end passphrase program args)
!   (let* ((use-agent (and (null passphrase) (pgg-gpg-use-agent-p)))
  	 (output-file-name (pgg-make-temp-file "pgg-output"))
  	 (args
  	  `("--status-fd" "2"

-- 
Daiki Ueno

  reply	other threads:[~2006-12-26  1:01 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-12-11 14:59 Documenting gpg-agent Richard Stallman
2006-12-17 18:44 ` Sascha Wilde
2006-12-17 18:56   ` Sascha Wilde
2006-12-18 15:59     ` Richard Stallman
2006-12-23 17:04       ` Ken Manheimer
2006-12-23 17:25         ` David Kastrup
2006-12-23 18:11           ` Ken Manheimer
2006-12-24  1:35         ` Richard Stallman
2006-12-24 22:45           ` Daiki Ueno
2006-12-25 16:53             ` Richard Stallman
2006-12-26  1:01               ` Daiki Ueno [this message]
2006-12-28 14:21                 ` Sascha Wilde
2007-02-15 16:33                 ` Ken Manheimer
2007-02-17 20:57                   ` Richard Stallman
2006-12-25 17:39             ` Ken Manheimer
2006-12-17 23:19   ` Chong Yidong
2006-12-18 15:59   ` Richard Stallman
2006-12-24  1:06     ` Chong Yidong
2006-12-24 17:09       ` Richard Stallman
2006-12-24 20:55         ` Chong Yidong
2006-12-25 17:37         ` Chong Yidong
2006-12-26 17:22           ` Richard Stallman
2006-12-31 13:08             ` Sascha Wilde
2006-12-31 22:13               ` Richard Stallman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=61d457d1-ee81-47bb-8cea-b49d840df05d@well-done.deisui.org \
    --to=ueno@unixuser.org \
    --cc=emacs-devel@gnu.org \
    --cc=ken.manheimer@gmail.com \
    --cc=wilde@sha-bang.de \
    --cc=wk@gnupg.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.