all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Ergus <spacibba@aol.com>
To: emacs-devel@gnu.org, Juri Linkov <juri@linkov.net>
Cc: Po Lu <luangruo@yahoo.com>, Eli Zaretskii <eliz@gnu.org>,
	Stefan Monnier <monnier@iro.umontreal.ca>
Subject: Re: Question about completion behavior
Date: Thu, 10 Mar 2022 23:35:24 +0100	[thread overview]
Message-ID: <61E441D4-D147-4E38-8A1C-159A916DD801@aol.com> (raw)
In-Reply-To: <86ee39r69o.fsf@mail.linkov.net>

Hi juri

On March 10, 2022 7:50:43 PM GMT+01:00, Juri Linkov <juri@linkov.net> wrote:
>> I just added a new branch feature/completions-customs.
>
>Thank you.  I hope these small steps that add new options
>will gradually place the default completion UI on a par with
>modern completion packages.
>
>One question - please explain what values of completion-auto-help
>nil/t/lazy/visible/always now do in these cases that you posted earlier:
>
>  1. no unique        (shows or update completions)
>  2. unique common    (complete-common and UPDATE completions)

The new values only change this case. Always shows or update  completions and visible only updates if they are already visible. The other previous values just hide completions.

>  3. unique candidate (complete and hides completion)
>  4. unique common but completion is a valid entry (complete-common and hides completion)
>
>> The changes there are minimal and finished in my opinion.  Whenever any
>> of the maintainers decide they can correct, fix, or merge into
>> master. (there is a small issue with the reference in the manual, so
>> please fix it, but I don't have any more time)
>
>I fixed these and some other issues in the branch.
>

Thanks :)

>> The changes include the max-height for completion window, a
>> completions-highlight-mode and the new values for completion-auto-help.
>
>Why not highlight the completions by default?  Unlike other changes,
>highlighting doesn't change the previous behavior.
>

You know...

>> I didn't include the zcomplete-mode because I am not sure how to name it
>> and didn't receive any feedback except from Juri.  In total it is 53
>> lines and provides an interaction similar to zsh (as explained before)
>> which may be very suitable for new users.
>
>I'm still unsure about this mode.  It's unclear what is the answer
>to the main question: should it select the completion buffer or not?
>

This one only works with the buffer selected. I minimized the hacks as much as possible. The only change is that when pressing a letter key or when attempting to edit the read only completions buffer, it will try to go to the mini buffer immediately and execute the key command there. Just give it a luck.

>I'll soon post a patch to allows navigation in the completion buffer
>without selecting it, i.e. from the minibuffer. 

We already tried that, but you are a much better lisper... Let's hope ;)

 This will handle
>the problem of self-inserting keys that will continue working
>in the minibuffer.  When this will prove to be insufficient,
>then we could add new mode to auto-select the completions buffer.
>But then why don't just use the recently added completion-auto-select?
>

The zcomplete-mode is intended to be used with completion-auto-select for a better experience indeed. As I said what it does is just to skip the completions when any letter, DEL or edit attempt is done in the Completions. Then it tries to execute the command directly in the mini-buffer before signaling an error... Basically it saves to explicitly jump to the mini-buffer before inserting another letter or delete one. 


>> Apart from that I am wondering if it makes sense to add an option to
>> propertise/configure the Initial line in the Completions buffer (there
>> is one to remove the help, but not the other)
>
>Do you mean completion-show-help whose nil doesn't remove
>text "Possible completions are:"?
>
Yep

>> (for example to remove it or add properties like intangible, a face etc)
>> could we also add a sort of counter there to indicate the total number
>> of candidates?
>
>Good idea.
>
Best,
Ergus
-- 
Sent from my Android device with K-9 Mail. Please excuse my brevity.



  reply	other threads:[~2022-03-10 22:35 UTC|newest]

Thread overview: 37+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20220309001013.gxyh2uasbuxiz6ww.ref@Ergus>
2022-03-09  0:10 ` Question about completion behavior Ergus
2022-03-09  0:22   ` Stefan Monnier
2022-03-09  1:46     ` Ergus
2022-03-09  3:05       ` Stefan Monnier
2022-03-09  3:37         ` Eli Zaretskii
2022-03-09 10:11           ` Ergus
2022-03-09 11:46             ` Ergus
2022-03-09 13:16               ` Eli Zaretskii
2022-03-09 13:46                 ` Po Lu
2022-03-09 17:32                   ` Stefan Monnier
2022-03-09 17:41                     ` Ergus
2022-03-10  0:42                     ` Po Lu
2022-03-10 10:21                       ` Ergus
2022-03-10 11:15                         ` Po Lu
2022-03-10 14:03                           ` Ergus
2022-03-10 18:50                             ` Juri Linkov
2022-03-10 22:35                               ` Ergus [this message]
2022-03-12 18:31                                 ` Juri Linkov
2022-03-13 14:58                                   ` Ergus
2022-03-12  0:17                               ` Ergus
2022-03-12 18:34                                 ` Juri Linkov
2022-03-13 11:21                                   ` Ergus
2022-03-13 17:44                                     ` Juri Linkov
2022-03-13 18:50                                       ` Ergus
2022-03-13 18:57                                         ` Eli Zaretskii
2022-03-13 19:49                                           ` Ergus
2022-03-13 20:48                                       ` [External] : " Drew Adams
2022-03-13 21:15                                         ` Ergus
2022-03-13 23:14                                           ` Drew Adams
2022-03-13 23:38                                             ` Ergus
2022-03-14  2:23                                               ` Drew Adams
2022-03-12 20:25                             ` Drew Adams
2022-03-09 14:30                 ` Ergus
2022-03-09 16:14                   ` [PATCH] " Ergus
2022-03-09 16:56                   ` Eli Zaretskii
2022-03-09 13:10             ` Eli Zaretskii
2022-03-09 14:22               ` Ergus

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=61E441D4-D147-4E38-8A1C-159A916DD801@aol.com \
    --to=spacibba@aol.com \
    --cc=eliz@gnu.org \
    --cc=emacs-devel@gnu.org \
    --cc=juri@linkov.net \
    --cc=luangruo@yahoo.com \
    --cc=monnier@iro.umontreal.ca \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.