From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Yuan Fu Newsgroups: gmane.emacs.bugs Subject: bug#69952: [PATCH] Support pdumping compiled queries by dumping their source Date: Tue, 21 May 2024 23:36:47 -0700 Message-ID: <61C9A0EB-D97D-4223-B257-FCA8DB150AA6@gmail.com> References: <86r0g1zaqi.fsf@gnu.org> <86le5hr9oj.fsf@gnu.org> <861q709y5y.fsf@gnu.org> <9B2A2190-AB42-4F1B-9F9D-5623B343CF0A@gmail.com> <86frvf8gf9.fsf@gnu.org> <86eday6j9o.fsf@gnu.org> <868r157wdy.fsf@gnu.org> <868r0phq6e.fsf@gnu.org> <493C3C1B-74F2-405D-830F-213B4D76DDC1@gmail.com> <86wmnrecr0.fsf@gnu.org> Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3731.700.6.1.1\)) Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="33091"; mail-complaints-to="usenet@ciao.gmane.io" Cc: serg.foo@gmail.com, dancol@dancol.org, 69952@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed May 22 08:39:11 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1s9fd1-0008Lb-CW for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 22 May 2024 08:39:11 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1s9fco-0004pP-R7; Wed, 22 May 2024 02:38:58 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1s9fcm-0004os-If for bug-gnu-emacs@gnu.org; Wed, 22 May 2024 02:38:56 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1s9fcm-0000Qc-At for bug-gnu-emacs@gnu.org; Wed, 22 May 2024 02:38:56 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1s9fcr-0006ro-Pz for bug-gnu-emacs@gnu.org; Wed, 22 May 2024 02:39:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Yuan Fu Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 22 May 2024 06:39:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 69952 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 69952-submit@debbugs.gnu.org id=B69952.171635989326390 (code B ref 69952); Wed, 22 May 2024 06:39:01 +0000 Original-Received: (at 69952) by debbugs.gnu.org; 22 May 2024 06:38:13 +0000 Original-Received: from localhost ([127.0.0.1]:53810 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1s9fc5-0006ra-Bp for submit@debbugs.gnu.org; Wed, 22 May 2024 02:38:13 -0400 Original-Received: from mail-oi1-f171.google.com ([209.85.167.171]:46453) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1s9fc2-0006rR-J9 for 69952@debbugs.gnu.org; Wed, 22 May 2024 02:38:11 -0400 Original-Received: by mail-oi1-f171.google.com with SMTP id 5614622812f47-3c99d0521cbso2814739b6e.1 for <69952@debbugs.gnu.org>; Tue, 21 May 2024 23:38:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1716359819; x=1716964619; darn=debbugs.gnu.org; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=PVxVM3HJADEHx+5JDZmCFzNqiSczhOFGoj+x7xt7UR4=; b=OL3PkSIO2ST1on9NG3bTP9qV+HiHB9DBd3ij/PeO3TkqbGYIlFW36F1isgv/njuRP2 RO5LbJSgNa5enz8EYrH72DLU/8QAubslMYg93+bthSTsy2dgKeWnV1QqVRPcQoUWeNaQ r9LYTFRt13sQ8dx/wSszdqnAFsemCfOVPWzA6KHa4yHrvqw8hsb4gMztL8fQZKTw1lek hPo1BZj0dbpqU5v3oQLvIRMYyrmB/uCLByDD0e9xK+sU4yeX2Bis+faXC5PEwgo9bXWi 9kMHG4lI9X6pZH47yfdJMIqvvct16xQqm6B1PhwOkNcmkxXkGTAIQoaIc5A0ewxa0pxr hbhA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1716359819; x=1716964619; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=PVxVM3HJADEHx+5JDZmCFzNqiSczhOFGoj+x7xt7UR4=; b=GGnfNieqZUcu80XB+XZGflH6nLkVqJAJ560giputjKReaaG8bi5ODZ3y9+gWIsHBWq rZu5/rodrOx/Cj3qYUMxy3TZ5ZpxGW9JSIcsEFaYTbPQU7/AixiETLt2OFyplzMIwHI/ JF9Qy+ZOpXXK4+FY7mE2eVChsGigAMfJjxeC3LKyjREOR+lQ4wArrbwn18dG4z1Tt+74 IHtSJwZlWJYpMpY+LzEIq4x2OvpxH2DJr+s3ZMI4qqe+CvIheSDPHzTWW5tNlpKhQ+VK wKmR+cLbZQCcwp358PS06bUiD17HjYsmG+87Ue3KSVFcEFtoiIEXk/afPVJvY9ry+E3O i67A== X-Forwarded-Encrypted: i=1; AJvYcCWuVbcvvGPA7BY6uvv7Z+CcHo2ntFzPwkdEze+IUXfYEOiGROuJha/K2WMPY6M/+y64hhEYT34DJ1jCwJiTTnBMsywoMHg= X-Gm-Message-State: AOJu0YxURWZqc46t5HRQNF4z6Tz3WuglYl0geZm6yn0ljwu4EOoG4btO tO8zR4IbtOZ1Ipc0M9v1QyiIujkQz/D4Dfyrs3RAqFinLUHyUZygslAN7A== X-Google-Smtp-Source: AGHT+IHH0NDlHVMxb+UJ7OmsWUnYcEO2r4qMELEEr093Qgja+CQ/gLjck/fYeJw1h2dlyCNB31i9ZA== X-Received: by 2002:a05:6808:f04:b0:3c8:6420:a9fc with SMTP id 5614622812f47-3cdb817993bmr1439090b6e.58.1716359819399; Tue, 21 May 2024 23:36:59 -0700 (PDT) Original-Received: from smtpclient.apple ([2601:641:300:4910:d47e:183a:1bb4:b282]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-6f6c4576a5bsm2515034b3a.208.2024.05.21.23.36.58 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Tue, 21 May 2024 23:36:58 -0700 (PDT) In-Reply-To: <86wmnrecr0.fsf@gnu.org> X-Mailer: Apple Mail (2.3731.700.6.1.1) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:285583 Archived-At: > On May 18, 2024, at 1:38 AM, Eli Zaretskii wrote: >=20 > Ping! >=20 >> From: Yuan Fu >> Date: Sat, 4 May 2024 14:29:06 -0700 >> Cc: serg.foo@gmail.com, >> dancol@dancol.org, >> 69952@debbugs.gnu.org >>=20 >>=20 >>=20 >>> On May 4, 2024, at 2:39 AM, Eli Zaretskii wrote: >>>=20 >>>> From: Yuan Fu >>>> Date: Sun, 21 Apr 2024 23:25:10 -0700 >>>> Cc: dancol@dancol.org, >>>> serg.foo@gmail.com, >>>> 69952@debbugs.gnu.org >>>>=20 >>>>> On Apr 21, 2024, at 11:18 PM, Eli Zaretskii wrote: >>>>>=20 >>>>>=20 >>>>> We cannot safely signal an error at that point, I think, so just >>>>> keeping the query as a string should do, as it will then signal an >>>>> error at run time when that query is used, is that right? >>>>=20 >>>> Yes, most likely a function-undefined signal, since all the = treesit.c functions like treesit-query-capture or treesit-query-compile = will be nonexistent. And usually the Lisp program trying to use the = query would check for tree-sitter availability with treesit-available-p = before trying to use any tree-sitter functions; so that signal will be = usually avoided as well. >>>=20 >>> Can you suggest such an addition to the patch? >>=20 >> Let me take a look. >>=20 >> Yuan Am I missing something? It seems the patch doesn=E2=80=99t include = anything about loading a dumped query? I guess that=E2=80=99s the = addition you=E2=80=99re talking about? If I want to add a special = loader, where should I start? Yuan=