From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.ciao.gmane.io!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.bugs Subject: bug#40919: 27.0.91; next-error-select-buffer does not always behave as documented Date: Sun, 14 Jun 2020 14:50:33 +0300 Message-ID: <619c3a9f-6c68-cd58-9e94-076cd424ad20@yandex.ru> References: <53913bd9-2bdc-0f70-f7b4-744283e0512f@ieee.org> <87d07rmb6j.fsf@mail.linkov.net> <87zhau5bfw.fsf@mail.linkov.net> <66f63b16-307a-919c-1d25-60ff63f92ae6@ieee.org> <87bln8u3xq.fsf@mail.linkov.net> <851cd382-4b2e-447a-2212-919c8a4ce908@ieee.org> <87d07lykkd.fsf@mail.linkov.net> <83bln5rbah.fsf@gnu.org> <87zhaozlvo.fsf@mail.linkov.net> <87v9kr8t1s.fsf@mail.linkov.net> <87zh9yuw5o.fsf@mail.linkov.net> <251b7e0d-ef94-e438-4023-a6513b611725@yandex.ru> <87lfl6tojw.fsf@mail.linkov.net> <87a71amsho.fsf@mail.linkov.net> <0138e3ed-2bf7-1d07-b5d1-7a4f3786e865@yandex.ru> <87bllp1b1e.fsf@mail.linkov.net> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="ciao.gmane.io:159.69.161.202"; logging-data="97403"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.8.0 Cc: 40919@debbugs.gnu.org, tspiteri@ieee.org To: Juri Linkov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Jun 14 13:51:11 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jkRAN-000PE5-Q3 for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 14 Jun 2020 13:51:11 +0200 Original-Received: from localhost ([::1]:52324 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jkRAM-0002vF-Rp for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 14 Jun 2020 07:51:10 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:59884) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jkRAE-0002tv-FN for bug-gnu-emacs@gnu.org; Sun, 14 Jun 2020 07:51:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:59708) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jkRAE-0002Xo-6G for bug-gnu-emacs@gnu.org; Sun, 14 Jun 2020 07:51:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1jkRAE-0001lI-47 for bug-gnu-emacs@gnu.org; Sun, 14 Jun 2020 07:51:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Dmitry Gutov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 14 Jun 2020 11:51:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 40919 X-GNU-PR-Package: emacs Original-Received: via spool by 40919-submit@debbugs.gnu.org id=B40919.15921354456748 (code B ref 40919); Sun, 14 Jun 2020 11:51:02 +0000 Original-Received: (at 40919) by debbugs.gnu.org; 14 Jun 2020 11:50:45 +0000 Original-Received: from localhost ([127.0.0.1]:43021 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jkR9x-0001km-62 for submit@debbugs.gnu.org; Sun, 14 Jun 2020 07:50:45 -0400 Original-Received: from mail-wr1-f45.google.com ([209.85.221.45]:44116) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jkR9u-0001kY-US for 40919@debbugs.gnu.org; Sun, 14 Jun 2020 07:50:43 -0400 Original-Received: by mail-wr1-f45.google.com with SMTP id y17so14236366wrn.11 for <40919@debbugs.gnu.org>; Sun, 14 Jun 2020 04:50:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=9dxuZtx6cyY3pLl31KrmrnZCsNmh+T4nwkcEwqtHT+w=; b=JfXb11Pxnijhr1PPgkzvofNeAY3fYOWU44aO7FqzNoXyMjWxZE7OL5c2IAGAWY5DRB 2BDliXroG8gFYBnQh7WKVUbsSxNaclu0G11fj9ApQ8mI3fhoIEkyZqsKI4zMBYWb9jix 6yluPbEWhNNn/5ZJqX0U/+gmULK5lWdQgZ0qrY3m3RD0QThkVEgIiyWxrR/DAvwRMSiq Vyg01SxLmn26LRs1b5Z+klOVdCNW50+yPwfaY0UolrgXBNix/QKOMal7/HIhN8QAo0Pq 3XSinsLQbNFuIxzFjuw9WT/yIPuouFUFdf8TvGMVw7A73Uz+ZBotQbSpwOVkfE2WfCTT 2RMw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:cc:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=9dxuZtx6cyY3pLl31KrmrnZCsNmh+T4nwkcEwqtHT+w=; b=fJ1Tc/miqeXoygO016V1/hB/FJnH7FG1WTEs4Vj9S0CHzoG+S/FmlEpyF9AvOH8PEq ORwpTQStkZXL80myaZDXipgiowc0OArE7kpss/u4TB68Q9Lk8CpyLMrs2Lm24/jJixWh 71f0/8uJCpRXpmObefEoDxzxoWW3iOTPIBPMfn4Kdl0Ur/zN1y2Q1z6uTcw0b1rs7mLP 9cMlH+vJp+uGnv35EVIh2ER90+EEOf8sDEi48cUHkBU2xmmRWYHLmW4oaDJHCzq7zWEt ZIbzCmt1V41/0wzPOmF8p6g/8IldGz9uYhc/Vxq60Ab/Y6axc1uQE4Y1pUd0qqqPLn6c EamQ== X-Gm-Message-State: AOAM533I9Z4//DBEKh/3LElMrO4SjKKaOFaQfwOf2dIylpxNjhXgX5vq Z2yb7OpUbVHfrqNd7cWBgy4= X-Google-Smtp-Source: ABdhPJwEVZb4E4Y5rTSd0HgAbzku3/jNGPXFT4gk3QndlfI6dRMLW4NaVXuowa3+SoV+hz7rn+qAlw== X-Received: by 2002:a5d:6288:: with SMTP id k8mr22795243wru.94.1592135436931; Sun, 14 Jun 2020 04:50:36 -0700 (PDT) Original-Received: from [192.168.0.3] ([66.205.73.129]) by smtp.googlemail.com with ESMTPSA id o6sm17090286wmc.39.2020.06.14.04.50.34 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 14 Jun 2020 04:50:34 -0700 (PDT) In-Reply-To: <87bllp1b1e.fsf@mail.linkov.net> Content-Language: en-US X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:181941 Archived-At: On 12.06.2020 01:43, Juri Linkov wrote: >> what kind of functions do they want to put on there? > > Both next-error-buffer-on-selected-frame and next-error-no-navigation-try-current. > >> And/or would they be content to advice-add on >> next-error-find-buffer-function instead? > > Is it possible to add advice-add by using customization? No, or at least not yet. But if we know of only one user that wants this setup, surely that's not a problem? By the way, you were going to evaluate the new default. Do you now think that it's problematic somehow (and, for instance, the previous was a better default), or do you want to change it as a purely personal preference? >>> -(defcustom next-error-find-buffer-function #'ignore >>> +(defcustom next-error-find-buffer-function '(ignore) >> >> ^s, maybe? > > Ok, when using as a hook it could be '-functions', but in case > of using advice-add it should be still '-function'. Yup. These are the two options. >>> ;; 2. If next-error-last-buffer is an acceptable buffer, use that. >>> (if (and next-error-last-buffer >>> (next-error-buffer-p next-error-last-buffer avoid-current >> >> Should we take the rest of the cases in next-error-find-buffer and move >> them to the default value of the above hook? > > I don't think so, I don't believe someone might want to customize the > rest of the cases. Well, if you're sure about that. Having them all on the hook seemed logical to me, but indeed I don't know how necessary that is.