From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Jackson Ray Hamilton Newsgroups: gmane.emacs.bugs Subject: bug#21898: scss-mode font-lock face for variables Date: Sat, 29 Jul 2017 10:24:48 -0700 (PDT) Message-ID: <619239865.75863.1501349088595@privateemail.com> References: <1447446585.9212.2@smtp.gmail.com> <1501346767.29622.1@smtp.gmail.com> Reply-To: Jackson Ray Hamilton NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: multipart/alternative; boundary="----=_Part_75862_663829224.1501349088478" X-Trace: blaine.gmane.org 1501349118 10760 195.159.176.226 (29 Jul 2017 17:25:18 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sat, 29 Jul 2017 17:25:18 +0000 (UTC) Cc: 21898@debbugs.gnu.org To: Simen =?UTF-8?Q?Heggest=C3=B8yl?= Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sat Jul 29 19:25:12 2017 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dbVU9-00029x-72 for geb-bug-gnu-emacs@m.gmane.org; Sat, 29 Jul 2017 19:25:05 +0200 Original-Received: from localhost ([::1]:53003 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dbVUF-0003pE-6l for geb-bug-gnu-emacs@m.gmane.org; Sat, 29 Jul 2017 13:25:11 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:45932) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dbVU9-0003ns-PC for bug-gnu-emacs@gnu.org; Sat, 29 Jul 2017 13:25:06 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dbVU6-0005wn-Lj for bug-gnu-emacs@gnu.org; Sat, 29 Jul 2017 13:25:05 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:58863) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1dbVU6-0005w2-IU for bug-gnu-emacs@gnu.org; Sat, 29 Jul 2017 13:25:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1dbVU6-00065z-9l for bug-gnu-emacs@gnu.org; Sat, 29 Jul 2017 13:25:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Jackson Ray Hamilton Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 29 Jul 2017 17:25:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 21898 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 21898-submit@debbugs.gnu.org id=B21898.150134909623417 (code B ref 21898); Sat, 29 Jul 2017 17:25:02 +0000 Original-Received: (at 21898) by debbugs.gnu.org; 29 Jul 2017 17:24:56 +0000 Original-Received: from localhost ([127.0.0.1]:33307 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dbVU0-00065d-MV for submit@debbugs.gnu.org; Sat, 29 Jul 2017 13:24:56 -0400 Original-Received: from mta-08-3.privateemail.com ([198.54.127.61]:3190) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dbVTy-00065Q-W6 for 21898@debbugs.gnu.org; Sat, 29 Jul 2017 13:24:55 -0400 Original-Received: from APP-03 (unknown [10.20.147.153]) (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by MTA-08.privateemail.com (Postfix) with ESMTPSA id 9F92B60044; Sat, 29 Jul 2017 17:24:48 +0000 (UTC) In-Reply-To: <1501346767.29622.1@smtp.gmail.com> X-Priority: 3 Importance: Medium X-Mailer: Open-Xchange Mailer v7.8.1-Rev35 X-Originating-Client: open-xchange-appsuite X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:135120 Archived-At: ------=_Part_75862_663829224.1501349088478 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Looks fine to me in all the default themes and the top 10 themes here: http= s://emacsthemes.com/charts/all-time.html > On July 29, 2017 at 9:46 AM Simen Heggest=C3=B8yl wr= ote: > > > Maybe a solution could be to let the `css-property' face inherit from > `font-lock-keyword-face' instead of `font-lock-variable-name-face'? That > would let `font-lock-variable-name-face' stay reserved for CSS/Sass > variables, while being distinguishable from CSS properties by default. > > -- Simen > ------=_Part_75862_663829224.1501349088478 MIME-Version: 1.0 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: 7bit Looks fine to me in all the default themes and the top 10 themes here: https://emacsthemes.com/charts/all-time.html

> On July 29, 2017 at 9:46 AM Simen Heggestøyl <simenheg@gmail.com> wrote:
>
>
> Maybe a solution could be to let the `css-property' face inherit from
> `font-lock-keyword-face' instead of `font-lock-variable-name-face'? That
> would let `font-lock-variable-name-face' stay reserved for CSS/Sass
> variables, while being distinguishable from CSS properties by default.
>
> -- Simen
>
------=_Part_75862_663829224.1501349088478--