From: Dmitry Gutov <dgutov@yandex.ru>
To: emacs-devel@gnu.org, Leo Liu <sdl.web@gmail.com>
Subject: Re: [Emacs-diffs] emacs-25 e55d0db: Fix revision calculation in vc-git-mode-line-string
Date: Wed, 27 Apr 2016 12:40:46 +0300 [thread overview]
Message-ID: <60a6de33-1bc9-b5e4-82b9-c1a26d655a94@yandex.ru> (raw)
In-Reply-To: <E1avHst-0007zE-3Z@vcs.savannah.gnu.org>
On 04/27/2016 08:19 AM, Leo Liu wrote:
> branch: emacs-25
> commit e55d0db95700edd11e71660729566c67b6c563b3
> Author: Leo Liu <sdl.web@gmail.com>
> Commit: Leo Liu <sdl.web@gmail.com>
>
> Fix revision calculation in vc-git-mode-line-string
>
> * lisp/vc/vc-git.el (vc-git-mode-line-string): Use
> vc-git-working-revision because vc-working-revision needs to decide
> the backend and may return nil.
Why was that bad?
vc-working-revision also caches the result, and vc-git-working-revision
does not. Do you want Emacs to call Git multiple times per second?
next parent reply other threads:[~2016-04-27 9:40 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20160427051934.30651.96563@vcs.savannah.gnu.org>
[not found] ` <E1avHst-0007zE-3Z@vcs.savannah.gnu.org>
2016-04-27 9:40 ` Dmitry Gutov [this message]
2016-04-27 14:23 ` [Emacs-diffs] emacs-25 e55d0db: Fix revision calculation in vc-git-mode-line-string Leo Liu
2016-04-27 14:55 ` Dmitry Gutov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=60a6de33-1bc9-b5e4-82b9-c1a26d655a94@yandex.ru \
--to=dgutov@yandex.ru \
--cc=emacs-devel@gnu.org \
--cc=sdl.web@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.