From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Merten Newsgroups: gmane.emacs.bugs Subject: bug#11711: 24.0.95; [PATCH] added imenu and which-func support to rst.el Date: Mon, 18 Jun 2012 11:28:39 +0200 Message-ID: <6091.1340011719@theowa.merten-home.homelinux.org> References: <20120615.041527.616439723447762585.yamato@redhat.com> <20120617.073313.1303392924099989359.yamato@redhat.com> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha1; protocol="application/pgp-signature" X-Trace: dough.gmane.org 1340045220 6783 80.91.229.3 (18 Jun 2012 18:47:00 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Mon, 18 Jun 2012 18:47:00 +0000 (UTC) To: 11711@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Mon Jun 18 20:46:59 2012 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1SggyT-0002wc-Fz for geb-bug-gnu-emacs@m.gmane.org; Mon, 18 Jun 2012 20:46:53 +0200 Original-Received: from localhost ([::1]:58729 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SggyT-0005Wp-GQ for geb-bug-gnu-emacs@m.gmane.org; Mon, 18 Jun 2012 14:46:53 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:52102) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SggyP-0005Tb-8S for bug-gnu-emacs@gnu.org; Mon, 18 Jun 2012 14:46:50 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SggyM-0006Uk-OT for bug-gnu-emacs@gnu.org; Mon, 18 Jun 2012 14:46:48 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:37455) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SggyM-0006Uc-9G for bug-gnu-emacs@gnu.org; Mon, 18 Jun 2012 14:46:46 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.72) (envelope-from ) id 1Sgh1W-0002Hc-MN for bug-gnu-emacs@gnu.org; Mon, 18 Jun 2012 14:50:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Merten Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 18 Jun 2012 18:50:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 11711 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: confirmed X-Debbugs-Original-To: bug-gnu-emacs@gnu.org X-Debbugs-Original-Cc: 11711@debbugs.gnu.org, monnier@iro.umontreal.ca Original-Received: via spool by submit@debbugs.gnu.org id=B.13400453748717 (code B ref -1); Mon, 18 Jun 2012 18:50:02 +0000 Original-Received: (at submit) by debbugs.gnu.org; 18 Jun 2012 18:49:34 +0000 Original-Received: from localhost ([127.0.0.1]:46997 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1Sgh14-0002GU-7r for submit@debbugs.gnu.org; Mon, 18 Jun 2012 14:49:34 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:34917) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1Sgh11-0002GK-AB for submit@debbugs.gnu.org; Mon, 18 Jun 2012 14:49:32 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Sggxo-0006Ol-6F for submit@debbugs.gnu.org; Mon, 18 Jun 2012 14:46:14 -0400 Original-Received: from lists.gnu.org ([208.118.235.17]:39944) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Sggxo-0006Ob-2v for submit@debbugs.gnu.org; Mon, 18 Jun 2012 14:46:12 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:51966) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Sggxm-0005PQ-81 for bug-gnu-emacs@gnu.org; Mon, 18 Jun 2012 14:46:11 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Sggxk-0006NP-As for bug-gnu-emacs@gnu.org; Mon, 18 Jun 2012 14:46:09 -0400 Original-Received: from moutng.kundenserver.de ([212.227.126.186]:50430) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Sggxk-0006N2-18 for bug-gnu-emacs@gnu.org; Mon, 18 Jun 2012 14:46:08 -0400 Original-Received: from theowa.merten-home.homelinux.org (ip-109-84-0-42.web.vodafone.de [109.84.0.42]) by mrelayeu.kundenserver.de (node=mrbap4) with ESMTP (Nemesis) id 0LylEN-1RsNcl07mx-016Aka; Mon, 18 Jun 2012 20:46:03 +0200 Original-Received: by theowa.merten-home.homelinux.org (Postfix, from userid 1000) id 6B5EF401E0; Mon, 18 Jun 2012 11:28:39 +0200 (CEST) Original-Received: from theowa.merten-home.homelinux.org (localhost [127.0.0.1]) by theowa.merten-home.homelinux.org (Postfix) with ESMTP id 5F3AE7A00C; Mon, 18 Jun 2012 11:28:39 +0200 (CEST) In-reply-to: <20120617.073313.1303392924099989359.yamato@redhat.com> Comments: In-reply-to Masatake YAMATO message dated "Sun, 17 Jun 2012 07:33:13 +0900." X-Mailer: MH-E 8.2; nmh 1.3; GNU Emacs 23.1.1 X-Provags-ID: V02:K0:R/yG1zF8+35msSx6FXBR2joHH4DKl6GsFKdXTOD3guo paZrIGZpD9KGuB/iHqxze5G5YRyaeZZPsAR74GiwHj82aPqOr4 /NbD3hkkT9+Z49yi6SJTFVgx2AT24nWNqNIwXi9vmuE6agoVla wwzPo3DDRpR8Vfg6V+/ARf1zSW6R3IaPjdESu4uxN93E/drU0Z 3vOhN7bPstUd8kYBXBBQB99/szgOalTzb/5xbMrVJ7tsp14RTM xthbyR1y3xnf/HsGuWXtij3jkRe5EZ/m3flGvCDLX4PX8fp0f8 0hEGKIdYIQUMl9sLsx2H6kXR5I/rLmb3/WSTn0YHGQEkStzy02 5gnYlSnS2gfu95ZqwiJCqp6xu84syGWVlmcpGAZ3rlB9b/l4ww ooL0MjA4O7CB68hVACVbbkZTPFHA5uiXsw= X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2) X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:61072 Archived-At: --=-=-= Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: quoted-printable Hi Masatake! Yesterday Masatake YAMATO wrote: >>> This is not a bug report. This is a request to merge a patch >>> to the offcial source tree. Thanks for the patch. >>> 2012-06-13 Masatake YAMATO >>=20 >>> * textmodes/rst.el (rst-mode, rst-imenu-index): Added >>> imenu and which-func support. >>=20 >> I'll let the other Stefan decide what to do with it. It looks >> pretty good for me. Just a few nitpicks below: It is definitely interesting. So far I never used imenu but it looks like a very useful thing. I already integrated your patch in my development version. However, I'll massage it a bit to fit better. > I found I should explain more about to the maintainer. Good idea. > I know `rst-toc'. People who writes a document in rst format may use > `rst-toc' instead of imenu. I'm thinking about whether opening a second method for this type of functionality using imenu. Indeed imenu is a mature framework and it is useful to use this instead of homebrew stuff like `rst-toc`. For instance I also have using the speed bar with `rst-mode`. The imenu documentation says it supports the speed bar somehow - so this might be a quick win :-) . > However, there is a reason I write this > patch. Sometime I read document writtn in rst file by my colleagues(on > emacs running on a terminal). In such case `which-func' helps me to > understand the document; and `which-func' uses imenu internally. I didn't get `which-func` to work - not even in Emacs Lisp mode. The documentation says When Which Function mode is enabled, the current function name is continuously displayed in the mode line, in certain major modes. Unfortunately the mode line doesn't change when I say `which-func-mode` :-( . [...checking...] Ah that's probably because I (setq default-mode-line-format ...) in my `.emacs`. Uuh, these stone-old customizations bite sometimes :-( . Gr=FC=DFe Stefan --=-=-= Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.10 (GNU/Linux) iQCVAwUBT970wgnTZgC3zSk5AQIU0gQAlyzV8Nmbu8CykEwDTwSXtoR2fw/I4DV/ FDrAWT45hBNeQNpfYk9C610rbsphYBpWlc4vQ+7zJWeNanHDBBiaz1vNe0lKvV+E FVMSPseArD7+gT81GWy1H8EXc4+uJyAftccWwUNZt1V7gtGONn/t2uKRamtW2gN9 mt13SwlHUvA= =NBWS -----END PGP SIGNATURE----- --=-=-=--