From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Yuan Fu Newsgroups: gmane.emacs.devel Subject: Re: Turning c-ts-mode.el, go-ts-mode.el, csharp-ts-mode.el etc into :core packages? Date: Tue, 7 Mar 2023 20:19:43 -0800 Message-ID: <6041CDB4-54EF-4840-805C-1CCE752EB399@gmail.com> References: <68a6b078-f91a-d392-f37f-53a86b76465b@yandex.ru> Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3731.400.51.1.1\)) Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="31363"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Emacs developers To: Dmitry Gutov Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Wed Mar 08 05:20:21 2023 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pZlHo-00080S-Us for ged-emacs-devel@m.gmane-mx.org; Wed, 08 Mar 2023 05:20:20 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pZlHT-0000wH-3D; Tue, 07 Mar 2023 23:19:59 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pZlHS-0000w2-09 for emacs-devel@gnu.org; Tue, 07 Mar 2023 23:19:58 -0500 Original-Received: from mail-pl1-x634.google.com ([2607:f8b0:4864:20::634]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pZlHQ-0000y6-AX for emacs-devel@gnu.org; Tue, 07 Mar 2023 23:19:57 -0500 Original-Received: by mail-pl1-x634.google.com with SMTP id v11so16528426plz.8 for ; Tue, 07 Mar 2023 20:19:55 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1678249195; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=jvMHyzHCJpPT1w1kdZObPi5RXLa5MKEvnCC0lcVoX9I=; b=Rh1Gn7l58F/timnpRpEjzeYXna8bGCi4GXrf+9s/UG881YPFKYSLoLiwzQtUKAuHs+ D7GjqkHs7qgqAdmJK48dyKQUHNpG9oHrfWPf/sDmOqA0CCKdh+Wsh7x/4tZ71N9bJwiP KW34oVyb/Bt4xqBPrXYR17Iu+Sbfil0bcnsWUOCeAwQYujIjxBn0hSuccBBcidh82Gyu 1sZAMI6oGmyuiNz4Pvwn29Es25GNDUA8jYXpoU33SbL7yMgNd7h/2uQsec7nLIbEdz2u +5LCbTdo02l1Yk59wJEDIjeZLSsmxtdk/ewmKhEHosdzcHZ/SerMUiBeTb9URBG7dZot Nvsg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1678249195; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=jvMHyzHCJpPT1w1kdZObPi5RXLa5MKEvnCC0lcVoX9I=; b=hc7ywtAd8VMAmaD2Q3ju433OkG2Jtzbxavh8Fu83LNe2Qm/FK6a3YdBRkpL/9IVSCm pLU6/60i4rI2Qzn560ll/zPKITJZcNEzU1cD2GnidsquGEEnSlyxi+NwEk0zcyUmid0p 0RU6kfFOT2XZRo2KkKwkqDfPzY7pofcwKmS651en5vGFhK6dXMlO6ZB5csMwPx4HRXpC uDd1uuxQvb9U0evVZMjaLhiBaI4um5Mf7kZ6mKgmD+UudCGcwmKumH6RqyiwGf8B0plh fARZxxHZs66pAVbLxRy327LQY1wG2E6wDEnrDAnWl64p9fo2LSCzTMCSR8QnR+J23gty ORfA== X-Gm-Message-State: AO0yUKWcghFxe4bw/loez5SkF9yrtLQVn5rrDxDGZqD0gqitg3mJvYlA 7Hq8J2+dEvGw+OF35L4DGMo= X-Google-Smtp-Source: AK7set++I+0ekHpZ3IpN52/PRTQJJoAx+4WuW1r7BcsP+88jMx1Y5ARDofmcAOUbRiHosN7rvPZsVQ== X-Received: by 2002:a17:902:f54f:b0:19d:164e:5565 with SMTP id h15-20020a170902f54f00b0019d164e5565mr16642555plf.56.1678249194806; Tue, 07 Mar 2023 20:19:54 -0800 (PST) Original-Received: from smtpclient.apple (cpe-172-117-161-177.socal.res.rr.com. [172.117.161.177]) by smtp.gmail.com with ESMTPSA id s1-20020a170902988100b0019aeddce6casm8998014plp.205.2023.03.07.20.19.53 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Tue, 07 Mar 2023 20:19:54 -0800 (PST) In-Reply-To: <68a6b078-f91a-d392-f37f-53a86b76465b@yandex.ru> X-Mailer: Apple Mail (2.3731.400.51.1.1) Received-SPF: pass client-ip=2607:f8b0:4864:20::634; envelope-from=casouri@gmail.com; helo=mail-pl1-x634.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:304104 Archived-At: > On Mar 7, 2023, at 7:06 AM, Dmitry Gutov wrote: >=20 > On 06/03/2023 00:41, Yuan Fu wrote: >> What are the implications of turning something into a :core package? = I can=E2=80=99t find much description of it. If my understanding of it = is correct, I think it would be beneficial to make new tree-sitter modes = into :core packages. Right now they are pretty bare-bones, and haven=E2=80= =99t been =E2=80=9Cbattle-tested=E2=80=9D. Making them core packages = would allow us gradually improve them and fix errors that come up. Those = files I mentioned in the subject are new files, if that matters. But I = don=E2=80=99t know if there are any downsides of turning something into = a :core package. >=20 > Most of the associated overhead is having to keep in mind the version = of Emacs that each packages advertises compatibility with. Which makes = using new features (or fixes) from future Emacs versions harder = (requiring versions checks, etc). I wish package.el has something like =E2=80=9Cinstall last version of = xxx package compatible with Emacs yyy=E2=80=9D. Then we can just bump = the minimum required Emacs version when a new Emacs release come out, = and use new features. Anyway, checking versions to use new Emacs feature = is IMO an acceptable price to pay. >=20 > We could also make treesit.el into a :core package at some point, if = any of the packages will need some new changes. Although this one will = likely depend on changes in treesit.c even more often. But for this = package, at least, it might be worth it to set the "Version:" header in = advance. Maybe, thought I don=E2=80=99t think we=E2=80=99ll need to anytime soon. Yuan=