From: Mauro Aranda <maurooaranda@gmail.com>
To: 46917@debbugs.gnu.org
Subject: bug#46917: 28.0.50; error when unloading feature after loading elp
Date: Thu, 04 Mar 2021 09:56:06 -0300 [thread overview]
Message-ID: <6040d8e9.1c69fb81.a0b83.7e5d@mx.google.com> (raw)
In-Reply-To: <6040d799.1c69fb81.936e9.ec05@mx.google.com> (Mauro Aranda's message of "Thu, 04 Mar 2021 09:50:30 -0300")
[-- Attachment #1: Type: text/plain, Size: 513 bytes --]
tags 46917 patch
quit
Mauro Aranda <maurooaranda@gmail.com> writes:
> Starting from emacs -Q, do:
>
> 1. In the *scratch* buffer, type and evaluate (in any order):
> (require 'autoarg) ; Whatever feature.
> (require 'elp)
>
> 2. Type and evaluate
> (unload-feature 'autoarg)
>
> 3. Emacs signals an error:
> "Unsupported qualifiers in function loadhist-unload-element: (:before :extra \"elp\")"
>
Looks like the problem is the order of the qualifiers; the attached
patch should fix it.
Best regards,
Mauro.
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: Patch --]
[-- Type: text/x-patch, Size: 953 bytes --]
From c05dda94c490a93c360bb5b71ddae7eb1f9cdcb6 Mon Sep 17 00:00:00 2001
From: Mauro Aranda <maurooaranda@gmail.com>
Date: Thu, 4 Mar 2021 09:47:39 -0300
Subject: [PATCH] Fix qualifiers order for loadhist-unload-element in elp.el
* lisp/emacs-lisp/elp.el (loadhist-unload-element): The :extra
qualifier is expected to come before the other qualifiers, so do
that. (Bug#46917)
---
lisp/emacs-lisp/elp.el | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lisp/emacs-lisp/elp.el b/lisp/emacs-lisp/elp.el
index cc2927caf4..411ea2af69 100644
--- a/lisp/emacs-lisp/elp.el
+++ b/lisp/emacs-lisp/elp.el
@@ -583,7 +583,7 @@ elp-unload-function
;; continue standard unloading
nil)
-(cl-defmethod loadhist-unload-element :before :extra "elp" ((x (head defun)))
+(cl-defmethod loadhist-unload-element :extra "elp" :before ((x (head defun)))
"Un-instrument before unloading a function."
(elp-restore-function (cdr x)))
--
2.30.0
next prev parent reply other threads:[~2021-03-04 12:56 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-04 12:50 bug#46917: 28.0.50; error when unloading feature after loading elp Mauro Aranda
2021-03-04 12:56 ` Mauro Aranda [this message]
2021-03-04 20:17 ` Lars Ingebrigtsen
2021-03-04 20:30 ` Mauro Aranda
2021-03-05 13:28 ` Lars Ingebrigtsen
2021-03-05 13:53 ` Mauro Aranda
2021-03-05 15:36 ` Stefan Monnier
2021-03-05 16:12 ` Lars Ingebrigtsen
2021-03-05 17:18 ` Stefan Monnier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6040d8e9.1c69fb81.a0b83.7e5d@mx.google.com \
--to=maurooaranda@gmail.com \
--cc=46917@debbugs.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.