From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Mauro Aranda Newsgroups: gmane.emacs.bugs Subject: bug#45068: [PATCH] 28.0.50; Update Modus themes 1.0.2 (backward-incompatible) Date: Mon, 01 Mar 2021 12:16:06 -0300 Message-ID: <603d053a.1c69fb81.f4cb8.fb14@mx.google.com> References: <87im9fgm27.fsf@protesilaos.com> <83v9d81khh.fsf@gnu.org> <83mtyk1hq3.fsf@gnu.org> <87czzgbapt.fsf@protesilaos.com> <83lfe4192f.fsf@gnu.org> <83im9814oh.fsf@gnu.org> <87sg6po0yd.fsf_-_@protesilaos.com> <83czxt2fpd.fsf@gnu.org> <87h7m0n0em.fsf@protesilaos.com> <83v9agryuz.fsf@gnu.org> <87tupyw83e.fsf@protesilaos.com> <83zgzqncxx.fsf@gnu.org> <874khwn1qf.fsf@protesilaos.com> <603b8171.1c69fb81.aa664.7f40@mx.google.com> <87mtvoxsvs.fsf@protesilaos.com> <603b9b9d.1c69fb81.f37aa.cb7c@mx.google.com> <83eegz7xcx.fsf@gnu.org> <87o8g3exjv.fsf@protesilaos.com> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="1278"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1.50 (gnu/linux) Cc: "Basil L. Contovounesios" , 45068@debbugs.gnu.org To: Protesilaos Stavrou Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Mar 01 16:17:53 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lGkIy-0000Br-KW for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 01 Mar 2021 16:17:52 +0100 Original-Received: from localhost ([::1]:60302 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lGkIx-0003RL-MS for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 01 Mar 2021 10:17:51 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:56852) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lGkIB-00035v-Pu for bug-gnu-emacs@gnu.org; Mon, 01 Mar 2021 10:17:03 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:38790) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lGkIA-0003wv-Hj for bug-gnu-emacs@gnu.org; Mon, 01 Mar 2021 10:17:03 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1lGkIA-0004WI-Dx for bug-gnu-emacs@gnu.org; Mon, 01 Mar 2021 10:17:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Mauro Aranda Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 01 Mar 2021 15:17:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 45068 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 45068-submit@debbugs.gnu.org id=B45068.161461177817290 (code B ref 45068); Mon, 01 Mar 2021 15:17:02 +0000 Original-Received: (at 45068) by debbugs.gnu.org; 1 Mar 2021 15:16:18 +0000 Original-Received: from localhost ([127.0.0.1]:50330 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lGkHS-0004Un-3l for submit@debbugs.gnu.org; Mon, 01 Mar 2021 10:16:18 -0500 Original-Received: from mail-qv1-f49.google.com ([209.85.219.49]:36195) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lGkHQ-0004UW-JZ for 45068@debbugs.gnu.org; Mon, 01 Mar 2021 10:16:16 -0500 Original-Received: by mail-qv1-f49.google.com with SMTP id d9so1982779qvo.3 for <45068@debbugs.gnu.org>; Mon, 01 Mar 2021 07:16:16 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=message-id:from:to:cc:subject:references:date:in-reply-to :user-agent:mime-version; bh=n7RMUBS3JVh2rTDmp4thlYWBw/kdcd9T+MYF0JPvEaU=; b=h9Omzi2xw3kJDPWQ6ngxAB4+5j03hXCdzSxKprAXDR9myiw44EEbNId4/8V2JsXlZb JUx9pvvSHNac9/A93yT8ZLHl8fhKBYZQV/PAMCrVWRNigAWwLZOZM9P9X487D+kxZyP8 HEnB9qPAupG8jztntCFx86p/K/14GtqRMp8IdUWoHCDWMGCk/leywASMafDmH5O14zHq iWu4GuEyiCyPXi/kJtWKcjis7c+2MNPulN1lGIFeBpunyn2tLkm3VZnW20sHYK0cF+se VcV3WKpGevHBIzVcH+iGlrhWSu7AlkzJGVKdOt9x2Y0nwAHfp6YCY7VDot4PnDR3IcmV B6Bg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:message-id:from:to:cc:subject:references:date :in-reply-to:user-agent:mime-version; bh=n7RMUBS3JVh2rTDmp4thlYWBw/kdcd9T+MYF0JPvEaU=; b=n5XS4mrQHurvGexbsVvTu4nBpJ3M6M9CgckPUvQPf6yqffpA4Gpxecx8Aa7pYuWXBV +rYNhJ8tBAuVcgsx2HP7G8VZ8egc1P/qYKBqP6w9G0u3XMKwY7HAOYtfCPd/gQ4LqOgF xrHE7Ew6aKo5XHRHP32jUcx8ww87832qL6oY0F7WjtXXjMlSuwWmzA+DkZdCFuC4CbnM VjRcv3NQUAI7xkGNWrM67TyX8APriodb5NLWbxBeM2h12kClmtGsx37u/i67JBjTbUHk Np7e1LjPkz0zKu1GNY94SUqgOdgjXUvK4Q92Wm7GiAxDKvgpCYBawNMCoO+dz1cDk0a+ Vp8w== X-Gm-Message-State: AOAM530r3WvNgyB48plKatGXrw0ANNGA8eYTvBRxiQKPalhK7NkSQ1Z6 GxB4vRWPQ47m4JNDomk1SJ9qG/Mw68aMsA== X-Google-Smtp-Source: ABdhPJxaplpsPhzoQ27QTiSwGsN1zNCZG8utAyoTCV9k2WNJPExPDulkMPWy6V34T9TnaTbo8WJqYA== X-Received: by 2002:a0c:e152:: with SMTP id c18mr14838283qvl.51.1614611770656; Mon, 01 Mar 2021 07:16:10 -0800 (PST) Original-Received: from tbb-desktop ([201.213.132.172]) by smtp.gmail.com with ESMTPSA id m30sm10378488qtd.30.2021.03.01.07.16.08 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Mon, 01 Mar 2021 07:16:10 -0800 (PST) X-Google-Original-Message-ID: <87eegy3nwp.fsf@maurooaranda@gmail.com> In-Reply-To: <87o8g3exjv.fsf@protesilaos.com> (Protesilaos Stavrou's message of "Mon, 01 Mar 2021 16:52:20 +0200") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:201102 Archived-At: Protesilaos Stavrou writes: > On 2021-03-01, 16:38 +0200, Eli Zaretskii wrote: > >>> From: Mauro Aranda >>> Cc: Eli Zaretskii , 45068@debbugs.gnu.org >>> Date: Sun, 28 Feb 2021 10:33:14 -0300 >>> >>> The rest looks good to me, but let's wait for the other people involved >>> to give their feedback. >> >> It LGTM as well, thanks. > > Thank you! Just to add that Basil (now in cc) shared some more > insights. The current version is this (any mistakes are mine): > > (defun require-theme (theme &optional path) > "Load THEME stored in `custom-theme-load-path'. > > THEME is a symbol that corresponds to the file name without its file > type extension. That is assumed to be either '.el' or '.elc'. > > When THEME is an element of `custom-available-themes', load it and ask > for confirmation if it is not considered safe by `custom-safe-themes'. > Otherwise load the file indicated by THEME, if present. In the latter > case, the file is intended to work as the basis of a theme declared > with `deftheme'. > > If optional PATH is non-nil, it should be a list of directories > to search for THEME in, instead of `custom-theme-load-path'. > PATH should have the same form as `load-path' or `exec-path'." > (cond > ((memq theme (custom-available-themes)) > (load-theme theme)) > ((let* ((dirs (or path (custom-theme--load-path))) > (file (unless (featurep theme) > (locate-file (symbol-name theme) dirs '(".el" ".elc"))))) > (when file > (load-file file)))))) Since there's agreement about this, could you send it as a patch?