From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Jan =?UTF-8?Q?Dj=C3=A4rv?= Newsgroups: gmane.emacs.bugs Subject: bug#11547: 24.0.96; Was a line accidentally commented out in callproc.c? Date: Wed, 23 May 2012 21:50:19 +0200 Message-ID: <603025D8-1D38-4667-B66D-9D2084809423@swipnet.se> References: <4FBCFC39.2090709@cornell.edu> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 (Apple Message framework v1278) Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: quoted-printable X-Trace: dough.gmane.org 1337802682 13681 80.91.229.3 (23 May 2012 19:51:22 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Wed, 23 May 2012 19:51:22 +0000 (UTC) Cc: 11547@debbugs.gnu.org To: Ken Brown Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed May 23 21:51:20 2012 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1SXHaX-0006OI-1E for geb-bug-gnu-emacs@m.gmane.org; Wed, 23 May 2012 21:51:17 +0200 Original-Received: from localhost ([::1]:39115 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SXHaW-00085z-M4 for geb-bug-gnu-emacs@m.gmane.org; Wed, 23 May 2012 15:51:16 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:33353) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SXHaT-00085s-Nm for bug-gnu-emacs@gnu.org; Wed, 23 May 2012 15:51:15 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SXHaR-0001j7-Ov for bug-gnu-emacs@gnu.org; Wed, 23 May 2012 15:51:13 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:59706) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SXHaR-0001j3-Li for bug-gnu-emacs@gnu.org; Wed, 23 May 2012 15:51:11 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.72) (envelope-from ) id 1SXHbF-0004am-Vf for bug-gnu-emacs@gnu.org; Wed, 23 May 2012 15:52:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Jan =?UTF-8?Q?Dj=C3=A4rv?= Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 23 May 2012 19:52:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 11547 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 11547-submit@debbugs.gnu.org id=B11547.133780268117604 (code B ref 11547); Wed, 23 May 2012 19:52:01 +0000 Original-Received: (at 11547) by debbugs.gnu.org; 23 May 2012 19:51:21 +0000 Original-Received: from localhost ([127.0.0.1]:41019 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1SXHaa-0004Zt-Su for submit@debbugs.gnu.org; Wed, 23 May 2012 15:51:21 -0400 Original-Received: from mailout.melmac.se ([62.20.26.67]:34659) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1SXHaY-0004Zg-Sp for 11547@debbugs.gnu.org; Wed, 23 May 2012 15:51:20 -0400 Original-Received: from mail01.melmac.se (mail01.melmac.se [62.20.26.80]) by mailout.melmac.se (Postfix) with ESMTP id 3FFA49CD9 for <11547@debbugs.gnu.org>; Wed, 23 May 2012 21:50:21 +0200 (CEST) Original-Received: (qmail 10483 invoked by uid 89); 23 May 2012 20:45:57 -0000 Original-Received: from h-46-59-42-18.na.cust.bahnhof.se (HELO coolsville.localdomain) (boel.djarv@bdtv.se@46.59.42.18) by mail01.melmac.se with ESMTPA; 23 May 2012 20:45:57 -0000 Original-Received: from [172.20.199.13] (zeplin [172.20.199.13]) by coolsville.localdomain (Postfix) with ESMTPSA id AEC227FA06C; Wed, 23 May 2012 21:50:20 +0200 (CEST) In-Reply-To: <4FBCFC39.2090709@cornell.edu> X-Mailer: Apple Mail (2.1278) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2) X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:60315 Archived-At: Hello. It sure looks like I messed up. Can you restore the line? I don't have = bzr access right now. I guess it needs to be done in the 24 branch also. See bug#5238 (http://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D5238) for = its impact. Jan D. 23 maj 2012 kl. 17:03 skrev Ken Brown: > In the course of trying to debug a Cygwin crash, I noticed that line = 643 of callproc.c is commented out. This was done in bzr revision = 103252, and it seems pretty clear from the context of that change that = it was done by accident: >=20 > revno: 103252 > committer: Jan D > branch nick: trunk > timestamp: Sun 2011-02-13 12:28:42 +0100 > message: > * callproc.c (Fcall_process): > * process.c (create_process): Replace Gtk with GConf in SIGPIPE > comment. > modified: > src/ChangeLog > src/callproc.c > src/process.c > diff: > =3D=3D=3D modified file 'src/ChangeLog' > --- src/ChangeLog 2011-02-13 00:16:28 +0000 > +++ src/ChangeLog 2011-02-13 11:28:42 +0000 > @@ -1,3 +1,9 @@ > +2011-02-13 Jan Dj=E4rv > + > + * callproc.c (Fcall_process): > + * process.c (create_process): Replace Gtk with GConf in = SIGPIPE > + comment. > + > 2011-02-12 Martin Rudalics >=20 > * window.c (select_window): Check inhibit_point_swap argument = when >=20 > =3D=3D=3D modified file 'src/callproc.c' > --- src/callproc.c 2011-02-12 18:53:24 +0000 > +++ src/callproc.c 2011-02-13 11:28:42 +0000 > @@ -559,9 +559,9 @@ > setpgrp (pid, pid); > #endif /* USG */ >=20 > - /* GTK causes us to ignore SIGPIPE, make sure it is restored > + /* GConf causes us to ignore SIGPIPE, make sure it is restored > in the child. */ > - signal (SIGPIPE, SIG_DFL); > + //signal (SIGPIPE, SIG_DFL); > #ifdef HAVE_WORKING_VFORK > sigprocmask (SIG_SETMASK, &procmask, 0); > #endif >=20 > =3D=3D=3D modified file 'src/process.c' > --- src/process.c 2011-02-12 18:53:24 +0000 > +++ src/process.c 2011-02-13 11:28:42 +0000 > @@ -2056,7 +2056,7 @@ >=20 > signal (SIGINT, SIG_DFL); > signal (SIGQUIT, SIG_DFL); > - /* GTK causes us to ignore SIGPIPE, make sure it is restored > + /* GConf causes us to ignore SIGPIPE, make sure it is restored > in the child. */ > signal (SIGPIPE, SIG_DFL); >=20 >=20 > I don't understand the code well enough to know how critical this is. = The comment preceding that line suggests that it could be a problem for = a build with GConf support. >=20 > Ken >=20 >=20 >=20