From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Ted Zlatanov Newsgroups: gmane.emacs.devel Subject: Re: git history tracking across renames (and emacs support) Date: Tue, 10 Jul 2018 20:54:33 +0000 Organization: =?utf-8?B?0KLQtdC+0LTQvtGAINCX0LvQsNGC0LDQvdC+0LI=?= @ Cienfuegos Message-ID: <601m6cc6.fsf@lifelogs.com> References: <87a7yn7tqp.fsf@lifelogs.com> <878te75xa1.fsf@lifelogs.com> <87ind6l2tt.fsf@lifelogs.com> <877etklvsa.fsf@lifelogs.com> <83y3m0pv8u.fsf@gnu.org> <86608msw0h.fsf@dod.no> <838tdiet25.fsf@gnu.org> <87y3li4vh7.fsf@telefonica.net> <87efnan46u.fsf@linux-m68k.org> <86wp12qtgo.fsf@dod.no> <83tvw6chqv.fsf@gnu.org> <86shbprix7.fsf_-_@dod.no> <838t6jgl1k.fsf@gnu.org> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1531256003 32246 195.159.176.226 (10 Jul 2018 20:53:23 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Tue, 10 Jul 2018 20:53:23 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Cc: larsi@gnus.org, emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Jul 10 22:53:19 2018 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fczdM-0008Ex-Jz for ged-emacs-devel@m.gmane.org; Tue, 10 Jul 2018 22:53:16 +0200 Original-Received: from localhost ([::1]:49722 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fczfT-0002oC-LQ for ged-emacs-devel@m.gmane.org; Tue, 10 Jul 2018 16:55:27 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:56029) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fczei-0002nt-Q5 for emacs-devel@gnu.org; Tue, 10 Jul 2018 16:54:41 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fczee-0003mh-Qm for emacs-devel@gnu.org; Tue, 10 Jul 2018 16:54:40 -0400 Original-Received: from mail-qk0-x22a.google.com ([2607:f8b0:400d:c09::22a]:36332) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1fczee-0003mQ-Lv for emacs-devel@gnu.org; Tue, 10 Jul 2018 16:54:36 -0400 Original-Received: by mail-qk0-x22a.google.com with SMTP id a132-v6so12348739qkg.3 for ; Tue, 10 Jul 2018 13:54:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=lifelogs.com; s=google; h=from:to:cc:subject:organization:references:mail-copies-to:date :in-reply-to:message-id:user-agent:mime-version; bh=dY/Av4C7pBZP3vrQrSmihbf/P1Gze2aoc/DEdwdKIa4=; b=lFQ1kR2fcZwpCC07iGIOe+AV/aAH0ni3LLTyAD5pJjmdfw1d8oBgtaJ5Zrn9evCzgJ qXHNSv0AylvolsxWMR1gPk4j2xzDqupvuOIQ+WGvA/pSvAz5ji8q1RQ6Z3cGW5ywaL42 GP43NX9fCEbniYG62oFTDYlcjDWUM2GFNWGfY= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:organization:references :mail-copies-to:date:in-reply-to:message-id:user-agent:mime-version; bh=dY/Av4C7pBZP3vrQrSmihbf/P1Gze2aoc/DEdwdKIa4=; b=Cs1yXouGnX1PncsqJK+8dkm8BCFeZPCGE7K6MjJDHBYN/wOpYEIM60bJC87GpbE/0J Jg7QMPZ+zYLwWCU3gKn8BZ1bN6g2pgo1LeVILASr1sJ6RYBvilIpyvVkteduFoOjbE+T 39CJdO1EVKCv9FUIrSa2nJ3Dgpuo1QWClO3RhAWjVu5lsJ6ix0BLWIWg3dnLrJR5D8ey E/OywgH5wt1KOVn72p/7AFcbSNKUHGraEwP9BHJ1KZygXc3S2ypTrGwjZDID9JUAp7uZ 4kYjWbF61lLluIOJe7b0PUdl930wunFiBb+vt7e4db3CZoF96uXGxgvdsZqqh4tCLaEh ij2A== X-Gm-Message-State: APt69E0x0TBsf2B3ZWZR0KwiTB+1XZpBXkNoqVzGCYoPcT4Az1kXofUc c0B2pZoZicTTva3USuhs5+S/Jp8wd3s= X-Google-Smtp-Source: AAOMgpdnLgXTzlcXTRg+uX8mgOUZD9+EpBgq/M2DJzr/A5tNlrYC9wcxUL+ogu/atIAlnOU0qwA2NQ== X-Received: by 2002:a37:9c94:: with SMTP id f142-v6mr23355919qke.180.1531256075726; Tue, 10 Jul 2018 13:54:35 -0700 (PDT) Original-Received: from flea (c-76-28-41-155.hsd1.ma.comcast.net. [76.28.41.155]) by smtp.gmail.com with ESMTPSA id v1-v6sm5972709qtg.7.2018.07.10.13.54.34 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 10 Jul 2018 13:54:35 -0700 (PDT) X-Face: bd.DQ~'29fIs`T_%O%C\g%6jW)yi[zuz6; d4V0`@y-~$#3P_Ng{@m+e4o<4P'#(_GJQ%TT= D}[Ep*b!\e,fBZ'j_+#"Ps?s2!4H2-Y"sx" Mail-Copies-To: never In-Reply-To: <838t6jgl1k.fsf@gnu.org> (Eli Zaretskii's message of "Tue, 10 Jul 2018 18:36:23 +0300") X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:400d:c09::22a X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:227227 Archived-At: On Tue, 10 Jul 2018 18:36:23 +0300 Eli Zaretskii wrote: >> From: Ted Zlatanov >> I would appreciate that too. If I need to know what functions were >> modified, I look at the diff, which Git makes trivial. >> >> Is there any chance of evolving the commit message formatting >> requirements to lower the friction of making a commit and reduce >> redundancy? EZ> IMO, what you'd like to have will actually _raise_ the friction EZ> (i.e. will be harder to provide) for many contributors, according to EZ> my experience of reviewing quite a few patches. I really don't think the current format is easy for anyone, especially new developers. It's also essentially repeating the headers from the diff. Anecdotally, every time I want to make a larger commit with a lot of items, it feels to me like paperwork for its own sake and takes up a long time. Let's take a recent example. commit 2fde6275b69fd113e78243790bf112bbdd2fe2bf Author: Basil L. Contovounesios Date: Mon Jul 9 18:46:33 2018 -0700 Add predicate proper-list-p For discussion, see emacs-devel thread starting at https://lists.gnu.org/archive/html/emacs-devel/2018-04/msg00460.html. * lisp/subr.el (proper-list-p): New function. Implementation suggested by Paul Eggert in https://lists.gnu.org/archive/html/emacs-devel/2018-06/msg00138.html. * doc/lispref/lists.texi (List Elements): * etc/NEWS: Document proper-list-p. * lisp/org/ob-core.el (org-babel-insert-result): * lisp/emacs-lisp/byte-opt.el (byte-optimize-if): * lisp/emacs-lisp/cl-macs.el (cl--make-usage-args): Use proper-list-p. * lisp/emacs-lisp/ert.el (ert--proper-list-p): Remove. Replaced by proper-list-p in lisp/subr.el. (ert--explain-equal-rec): Use proper-list-length. * lisp/format.el (format-proper-list-p): Remove. Replaced by proper-list-p in lisp/subr.el. (format-annotate-single-property-change): Use proper-list-p. * test/lisp/emacs-lisp/ert-tests.el (ert-test-proper-list-p): Move from here... * test/lisp/subr-tests.el (subr-tests--proper-list-length): ...to here, mutatis mutandis. Here's one way to write it more concisely and make it more readable, keeping in mind that the diff is part of the same log and is thus going to be right below the explanation, and Git usually already *knows* which files and functions have been modified. I'd much rather read the second version. commit 2fde6275b69fd113e78243790bf112bbdd2fe2bf Author: Basil L. Contovounesios Date: Mon Jul 9 18:46:33 2018 -0700 Adds and documents the new predicate function proper-list-p Factors out several one-off implementations of the same functionality. For discussion, see emacs-devel thread starting at https://lists.gnu.org/archive/html/emacs-devel/2018-04/msg00460.html. Implementation suggested by Paul Eggert in https://lists.gnu.org/archive/html/emacs-devel/2018-06/msg00138.html.