From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Phil Sainty Newsgroups: gmane.emacs.devel Subject: Re: [elpa] scratch/email-revision-details Date: Mon, 09 Aug 2021 02:54:51 +1200 Message-ID: <60156c4c16641c85433029e3fce69a6c@webmail.orcon.net.nz> References: <20210806151651.16524.53159@vcs0.savannah.gnu.org> <20210806151653.0F131203E8@vcs0.savannah.gnu.org> <5ddc43060bafb79337ee410c8a70574d@webmail.orcon.net.nz> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="15159"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Orcon Webmail Cc: emacs-devel@gnu.org To: Stefan Monnier Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sun Aug 08 16:55:42 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mCkDF-0003o3-NS for ged-emacs-devel@m.gmane-mx.org; Sun, 08 Aug 2021 16:55:41 +0200 Original-Received: from localhost ([::1]:39856 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mCkDE-0001Nw-Fr for ged-emacs-devel@m.gmane-mx.org; Sun, 08 Aug 2021 10:55:40 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:58860) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mCkCZ-0000hi-H2 for emacs-devel@gnu.org; Sun, 08 Aug 2021 10:54:59 -0400 Original-Received: from smtp-1.orcon.net.nz ([60.234.4.34]:59273) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mCkCY-0002Fn-1u for emacs-devel@gnu.org; Sun, 08 Aug 2021 10:54:59 -0400 Original-Received: from [10.253.37.70] (port=57708 helo=webmail.orcon.net.nz) by smtp-1.orcon.net.nz with esmtpa (Exim 4.90_1) (envelope-from ) id 1mCkCR-0006HF-Cn; Mon, 09 Aug 2021 02:54:51 +1200 Original-Received: from ip-116-251-162-85.kinect.net.nz ([116.251.162.85]) via [10.253.37.253] by webmail.orcon.net.nz with HTTP (HTTP/1.1 POST); Mon, 09 Aug 2021 02:54:51 +1200 In-Reply-To: X-Sender: psainty@orcon.net.nz X-GeoIP: -- Received-SPF: pass client-ip=60.234.4.34; envelope-from=psainty@orcon.net.nz; helo=smtp-1.orcon.net.nz X-Spam_score_int: -11 X-Spam_score: -1.2 X-Spam_bar: - X-Spam_report: (-1.2 / 5.0 requ) BAYES_05=-0.5, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:272203 Archived-At: On 2021-08-08 10:38, Stefan Monnier wrote: > - Make it so `elpaa--release-email` is called directly from > `elpaa--make-one-tarball` when `revision-function` is non-nil. > [ AFAICT `elpaa--release-email` is called if-and-only-if > `revision-function` is non-nil and always in the same way That's true, but the `revision-function' being passed varies... > - Change `elpaa--make-one-tarball` to remember the commit id returned > by `revision-function`, so we can pass it to `elpaa--release-email`. ...and it wasn't clear to me that it was safe to assume that the value being returned by any particular `revision-function' was guaranteed to be a git commit -- the single case where `elpaa--get-release-revision' was called was the only one that I'd been trying to target. Looking again, `elpaa--get-last-release' seems to be responsible for providing the revision value in other situations, and it's similarly grabbing it from git (interestingly this code is getting the first line of the git output explicitly, as in my workaround for that git bug), so your suggestion makes sense. -Phil