From mboxrd@z Thu Jan 1 00:00:00 1970 Path: main.gmane.org!not-for-mail From: no-spam@cua.dk (Kim F. Storm) Newsgroups: gmane.emacs.devel Subject: Recent changes to easy-menu.el breaks "printing.el". Date: 03 May 2002 20:39:13 +0200 Sender: emacs-devel-admin@gnu.org Message-ID: <5xy9f1qdny.fsf@kfs2.cua.dk> NNTP-Posting-Host: localhost.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: main.gmane.org 1020447580 28258 127.0.0.1 (3 May 2002 17:39:40 GMT) X-Complaints-To: usenet@main.gmane.org NNTP-Posting-Date: Fri, 3 May 2002 17:39:40 +0000 (UTC) Cc: vinicius@cpqd.com.br Return-path: Original-Received: from quimby.gnus.org ([80.91.224.244]) by main.gmane.org with esmtp (Exim 3.33 #1 (Debian)) id 173h1w-0007Lf-00 for ; Fri, 03 May 2002 19:39:40 +0200 Original-Received: from fencepost.gnu.org ([199.232.76.164]) by quimby.gnus.org with esmtp (Exim 3.12 #1 (Debian)) id 173h7j-0007IT-00 for ; Fri, 03 May 2002 19:45:39 +0200 Original-Received: from localhost ([127.0.0.1] helo=fencepost.gnu.org) by fencepost.gnu.org with esmtp (Exim 3.34 #1 (Debian)) id 173h1R-0005rm-00; Fri, 03 May 2002 13:39:09 -0400 Original-Received: from mail.filanet.dk ([195.215.206.179]) by fencepost.gnu.org with smtp (Exim 3.34 #1 (Debian)) id 173h0n-0005oa-00 for ; Fri, 03 May 2002 13:38:30 -0400 Original-Received: from kfs2.cua.dk.cua.dk (unknown [10.1.82.3]) by mail.filanet.dk (Postfix) with SMTP id A948F7C035; Fri, 3 May 2002 17:38:26 +0000 (GMT) Original-To: emacs-devel@gnu.org Original-Lines: 52 User-Agent: Gnus/5.09 (Gnus v5.9.0) Emacs/21.2.50 Errors-To: emacs-devel-admin@gnu.org X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.0.9 Precedence: bulk List-Help: List-Post: List-Subscribe: , List-Id: Emacs development discussions. List-Unsubscribe: , List-Archive: Xref: main.gmane.org gmane.emacs.devel:3540 X-Report-Spam: http://spam.gmane.org/gmane.emacs.devel:3540 I've been using Vinicius Jose Latorre's excellent "printing" package without a glitch -- until recently. The printing package does some pretty obscure things to setup its Printing entry on the Tools menu, and it no longer works for me. I traces the problem to a recent change to easy-menu where strings are now downcased before they are interned. Since printing.el does not expect this, it fails. I've fixed it in printing.el with the following small modification. I'm using version 2.1 which may be out-dated, but I'm unable to find anything newer. *** printing.el~ Tue May 23 09:33:13 2000 --- printing.el Fri May 3 12:28:09 2002 *************** *** 2740,2746 **** (defun pr-menu-get-item (name-list) ;; NAME-LIST is a string or a list of strings. ! (let ((ipath [menu-bar tools Printing]) (len (and (listp name-list) (length name-list)))) (and len (cond ((= len 0) (setq name-list "nil")) --- 2740,2746 ---- (defun pr-menu-get-item (name-list) ;; NAME-LIST is a string or a list of strings. ! (let ((ipath (vector 'menu-bar 'tools (pr-get-symbol "Printing"))) (len (and (listp name-list) (length name-list)))) (and len (cond ((= len 0) (setq name-list "nil")) *************** *** 2767,2772 **** --- 2767,2775 ---- (defun pr-get-symbol (name) + ;; Recent versions of easy-menu downcase names before interning them. + (if (fboundp 'easy-menu-name-match) + (setq name (downcase name))) (or (intern-soft name) (make-symbol name))) -- Kim F. Storm