From mboxrd@z Thu Jan 1 00:00:00 1970 Path: main.gmane.org!not-for-mail From: storm@cua.dk (Kim F. Storm) Newsgroups: gmane.emacs.devel Subject: Re: Another question on the W32 port Date: 23 Mar 2003 14:15:27 +0100 Sender: emacs-devel-bounces+emacs-devel=quimby.gnus.org@gnu.org Message-ID: <5xr88y2phs.fsf@kfs2.cua.dk> References: <5xznnoz3uc.fsf@kfs2.cua.dk> NNTP-Posting-Host: main.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: main.gmane.org 1048421871 7850 80.91.224.249 (23 Mar 2003 12:17:51 GMT) X-Complaints-To: usenet@main.gmane.org NNTP-Posting-Date: Sun, 23 Mar 2003 12:17:51 +0000 (UTC) Cc: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+emacs-devel=quimby.gnus.org@gnu.org Sun Mar 23 13:17:50 2003 Return-path: Original-Received: from quimby.gnus.org ([80.91.224.244]) by main.gmane.org with esmtp (Exim 3.35 #1 (Debian)) id 18x4QA-00022S-00 for ; Sun, 23 Mar 2003 13:17:50 +0100 Original-Received: from monty-python.gnu.org ([199.232.76.173]) by quimby.gnus.org with esmtp (Exim 3.12 #1 (Debian)) id 18x4Sq-0002pH-00 for ; Sun, 23 Mar 2003 13:20:37 +0100 Original-Received: from localhost ([127.0.0.1] helo=monty-python.gnu.org) by monty-python.gnu.org with esmtp (Exim 4.10.13) id 18x4Pd-0004wd-01 for emacs-devel@quimby.gnus.org; Sun, 23 Mar 2003 07:17:17 -0500 Original-Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.10.13) id 18x4PC-0004XO-00 for emacs-devel@gnu.org; Sun, 23 Mar 2003 07:16:50 -0500 Original-Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.10.13) id 18x4P4-0004EN-00 for emacs-devel@gnu.org; Sun, 23 Mar 2003 07:16:43 -0500 Original-Received: from mail.filanet.dk ([195.215.206.179]) by monty-python.gnu.org with esmtp (Exim 4.10.13) id 18x4Oz-0003xZ-00; Sun, 23 Mar 2003 07:16:37 -0500 Original-Received: from kfs2.cua.dk.cua.dk (unknown [10.1.82.3]) by mail.filanet.dk (Postfix) with SMTP id 9495C7C012; Sun, 23 Mar 2003 13:16:36 +0100 (CET) Original-To: Jason Rumney In-Reply-To: Original-Lines: 44 User-Agent: Gnus/5.09 (Gnus v5.9.0) Emacs/21.3.50 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1b5 Precedence: list List-Id: Emacs development discussions. List-Help: List-Post: List-Subscribe: , List-Archive: List-Unsubscribe: , Errors-To: emacs-devel-bounces+emacs-devel=quimby.gnus.org@gnu.org Xref: main.gmane.org gmane.emacs.devel:12549 X-Report-Spam: http://spam.gmane.org/gmane.emacs.devel:12549 Jason Rumney writes: > storm@cua.dk (Kim F. Storm) writes: > > > I was looking at glyph_rect in X and W32, and noticed that they are > > significantly different due to the following change: > > > > 2002-02-18 Jason Rumney > > > > * w32term.c (glyph_rect): Determine the row and glyph more precisely. > > > > > > Now I wonder why that change was not back-ported to the X version? > > > > Was there a specific W32 problem that was related to this, or can the > > new W32 version be used on X too (modulo the differences in rectangle > > implementation) ? > > My memory that far back is sketchy, but I think it may have been to > do with mouse highlighting. There have long been bugs in mouse > highlighting that show up under Windows, but not X, and it has often > confused me when I have found a fix for such bugs and wondered why the > fix was not necessary on X. Yes, that is strange. Maybe it can be related to cleartype as you mention in the below W32-specific comment from get_glyph_string_clip_rect: /* If drawing the cursor, don't let glyph draw outside its advertised boundaries. Cleartype does this under some circumstances. */ > In such cases I decide to play it safe > and not backport the change to X. I would prefer if such "improved" code was backported (or consolidated) like I did with get_glyph_string_clip_rect, i.e. let the additional checks be conditioned by HAVE_NTGUI. That way, if similar problems are seen on other platforms later on, the fix may actually be there already. -- Kim F. Storm http://www.cua.dk