From: storm@cua.dk (Kim F. Storm)
Cc: emacs-devel@gnu.org
Subject: Re: Another question on the W32 port
Date: 23 Mar 2003 14:15:27 +0100 [thread overview]
Message-ID: <5xr88y2phs.fsf@kfs2.cua.dk> (raw)
In-Reply-To: <m265qb7n30.fsf@nyaumo.jasonr.f2s.com>
Jason Rumney <jasonr@gnu.org> writes:
> storm@cua.dk (Kim F. Storm) writes:
>
> > I was looking at glyph_rect in X and W32, and noticed that they are
> > significantly different due to the following change:
> >
> > 2002-02-18 Jason Rumney <jasonr@gnu.org>
> >
> > * w32term.c (glyph_rect): Determine the row and glyph more precisely.
> >
> >
> > Now I wonder why that change was not back-ported to the X version?
> >
> > Was there a specific W32 problem that was related to this, or can the
> > new W32 version be used on X too (modulo the differences in rectangle
> > implementation) ?
>
> My memory that far back is sketchy, but I think it may have been to
> do with mouse highlighting. There have long been bugs in mouse
> highlighting that show up under Windows, but not X, and it has often
> confused me when I have found a fix for such bugs and wondered why the
> fix was not necessary on X.
Yes, that is strange.
Maybe it can be related to cleartype as you mention in the below
W32-specific comment from get_glyph_string_clip_rect:
/* If drawing the cursor, don't let glyph draw outside its
advertised boundaries. Cleartype does this under some circumstances. */
> In such cases I decide to play it safe
> and not backport the change to X.
I would prefer if such "improved" code was backported (or
consolidated) like I did with get_glyph_string_clip_rect, i.e. let the
additional checks be conditioned by HAVE_NTGUI. That way, if similar
problems are seen on other platforms later on, the fix may actually be
there already.
--
Kim F. Storm <storm@cua.dk> http://www.cua.dk
next prev parent reply other threads:[~2003-03-23 13:15 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-03-21 23:39 Another question on the W32 port Kim F. Storm
2003-03-22 9:44 ` Jason Rumney
2003-03-23 13:15 ` Kim F. Storm [this message]
2003-03-23 14:58 ` Jason Rumney
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5xr88y2phs.fsf@kfs2.cua.dk \
--to=storm@cua.dk \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.