From mboxrd@z Thu Jan 1 00:00:00 1970 Path: main.gmane.org!not-for-mail From: storm@cua.dk (Kim F. Storm) Newsgroups: gmane.emacs.devel Subject: W32 question - hide/show system caret Date: 20 Mar 2003 00:45:46 +0100 Sender: emacs-devel-bounces+emacs-devel=quimby.gnus.org@gnu.org Message-ID: <5xk7eusyxh.fsf@kfs2.cua.dk> NNTP-Posting-Host: main.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: main.gmane.org 1048114039 23003 80.91.224.249 (19 Mar 2003 22:47:19 GMT) X-Complaints-To: usenet@main.gmane.org NNTP-Posting-Date: Wed, 19 Mar 2003 22:47:19 +0000 (UTC) Original-X-From: emacs-devel-bounces+emacs-devel=quimby.gnus.org@gnu.org Wed Mar 19 23:47:16 2003 Return-path: Original-Received: from quimby.gnus.org ([80.91.224.244]) by main.gmane.org with esmtp (Exim 3.35 #1 (Debian)) id 18vmL6-0005yp-00 for ; Wed, 19 Mar 2003 23:47:16 +0100 Original-Received: from monty-python.gnu.org ([199.232.76.173]) by quimby.gnus.org with esmtp (Exim 3.12 #1 (Debian)) id 18vmM4-0001OD-00 for ; Wed, 19 Mar 2003 23:48:16 +0100 Original-Received: from localhost ([127.0.0.1] helo=monty-python.gnu.org) by monty-python.gnu.org with esmtp (Exim 4.10.13) id 18vmL9-0004ql-00 for emacs-devel@quimby.gnus.org; Wed, 19 Mar 2003 17:47:19 -0500 Original-Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.10.13) id 18vmKp-0004fZ-00 for emacs-devel@gnu.org; Wed, 19 Mar 2003 17:46:59 -0500 Original-Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.10.13) id 18vmKm-0004bu-00 for emacs-devel@gnu.org; Wed, 19 Mar 2003 17:46:58 -0500 Original-Received: from mail.filanet.dk ([195.215.206.179]) by monty-python.gnu.org with esmtp (Exim 4.10.13) id 18vmKl-0004ZL-00 for emacs-devel@gnu.org; Wed, 19 Mar 2003 17:46:55 -0500 Original-Received: from kfs2.cua.dk.cua.dk (unknown [10.1.82.3]) by mail.filanet.dk (Postfix) with SMTP id 8306E7C017 for ; Wed, 19 Mar 2003 23:46:54 +0100 (CET) Original-To: emacs-devel@gnu.org Original-Lines: 13 User-Agent: Gnus/5.09 (Gnus v5.9.0) Emacs/21.3.50 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1b5 Precedence: list List-Id: Emacs development discussions. List-Help: List-Post: List-Subscribe: , List-Archive: List-Unsubscribe: , Errors-To: emacs-devel-bounces+emacs-devel=quimby.gnus.org@gnu.org Xref: main.gmane.org gmane.emacs.devel:12471 X-Report-Spam: http://spam.gmane.org/gmane.emacs.devel:12471 During my merging of X/W32/MAC I found what I think is sub-optimal code: In w32term.c, the system caret is hidden and shown in the hooks x_update_window_begin and x_update_window_end, i.e. once for each updated emacs window. Wouldn't it be simpler and more efficient to move the hide/show into x_update_begin and x_update_end, i.e. only once for each updated emacs frame ? -- Kim F. Storm http://www.cua.dk