Does this code (in wait_reading_process_input) work?

Does this code (in wait_reading_process_input) work?

[Kim F. Storm]

Does the following code in wait_reading_process_input really work
as intended (ie. wait for output from a specific process) ?

      /* Don't wait for output from a non-running process.  */
      if (wait_proc != 0 && !NILP (wait_proc->raw_status_low))
	update_status (wait_proc);
      if (wait_proc != 0
	  && ! EQ (wait_proc->status, Qrun))
	{
	  int nread, total_nread = 0;
          ...


As I read the code, it only enters the the conditional block if the
process state *differs* from 'run - i.e. when it is non-running.
That's the opposite of what the comment above the test says.

So what's up?  

++kfs


_______________________________________________
Emacs-devel mailing list
Emacs-devel@gnu.org
http://mail.gnu.org/mailman/listinfo/emacs-devel

Re: Does this code (in wait_reading_process_input) work?

[Richard Stallman]

	  /* Don't wait for output from a non-running process.  */
	  if (wait_proc != 0 && !NILP (wait_proc->raw_status_low))
	    update_status (wait_proc);
	  if (wait_proc != 0
	      && ! EQ (wait_proc->status, Qrun))
	    {
	      int nread, total_nread = 0;
	      ...


    As I read the code, it only enters the the conditional block if the
    process state *differs* from 'run - i.e. when it is non-running.

That is correct.

    That's the opposite of what the comment above the test says.

That code reads output but does not wait for it.  In fact, it ends
with `break;' which exits the main loop of wait_reading_process_input.
So the comment seems correct to me.

_______________________________________________
Emacs-devel mailing list
Emacs-devel@gnu.org
http://mail.gnu.org/mailman/listinfo/emacs-devel