From mboxrd@z Thu Jan  1 00:00:00 1970
Path: main.gmane.org!not-for-mail
From: storm@cua.dk (Kim F. Storm)
Newsgroups: gmane.emacs.devel
Subject: Re: silly face function names
Date: 20 Dec 2002 11:53:25 +0100
Sender: emacs-devel-bounces+emacs-devel=quimby.gnus.org@gnu.org
Message-ID: <5xd6nx0xne.fsf@kfs2.cua.dk>
References: <buovg1pgmot.fsf@mcspd15.ucom.lsi.nec.co.jp>
NNTP-Posting-Host: main.gmane.org
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
X-Trace: main.gmane.org 1040378179 14105 80.91.224.249 (20 Dec 2002 09:56:19 GMT)
X-Complaints-To: usenet@main.gmane.org
NNTP-Posting-Date: Fri, 20 Dec 2002 09:56:19 +0000 (UTC)
Cc: emacs-devel@gnu.org
Return-path: <emacs-devel-bounces+emacs-devel=quimby.gnus.org@gnu.org>
Original-Received: from quimby.gnus.org ([80.91.224.244])
	by main.gmane.org with esmtp (Exim 3.35 #1 (Debian))
	id 18PJtC-0003fN-00
	for <emacs-devel@main.gmane.org>; Fri, 20 Dec 2002 10:56:18 +0100
Original-Received: from monty-python.gnu.org ([199.232.76.173])
	by quimby.gnus.org with esmtp (Exim 3.12 #1 (Debian))
	id 18PJuk-0006Pk-00
	for <emacs-devel@quimby.gnus.org>; Fri, 20 Dec 2002 10:57:54 +0100
Original-Received: from localhost ([127.0.0.1] helo=monty-python.gnu.org)
	by monty-python.gnu.org with esmtp (Exim 4.10.13)
	id 18PJsX-0001OI-0B
	for emacs-devel@quimby.gnus.org; Fri, 20 Dec 2002 04:55:37 -0500
Original-Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.10.13)
	id 18PJrn-00017U-00
	for emacs-devel@gnu.org; Fri, 20 Dec 2002 04:54:51 -0500
Original-Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.10.13)
	id 18PJra-0000wL-00
	for emacs-devel@gnu.org; Fri, 20 Dec 2002 04:54:39 -0500
Original-Received: from mail.filanet.dk ([195.215.206.179])
	by monty-python.gnu.org with esmtp (Exim 4.10.13)
	id 18PJqn-0000TM-00; Fri, 20 Dec 2002 04:53:49 -0500
Original-Received: from kfs2.cua.dk.cua.dk (kfs2.local.filanet.dk [192.168.1.182])
	by mail.filanet.dk (Postfix) with SMTP
	id 864397C012; Fri, 20 Dec 2002 10:53:47 +0100 (CET)
Original-To: Miles Bader <miles@gnu.org>
In-Reply-To: <buovg1pgmot.fsf@mcspd15.ucom.lsi.nec.co.jp>
Original-Lines: 22
User-Agent: Gnus/5.09 (Gnus v5.9.0) Emacs/21.3.50
X-BeenThere: emacs-devel@gnu.org
X-Mailman-Version: 2.1b5
Precedence: list
List-Id: Emacs development discussions. <emacs-devel.gnu.org>
List-Help: <mailto:emacs-devel-request@gnu.org?subject=help>
List-Post: <mailto:emacs-devel@gnu.org>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/emacs-devel>,
	<mailto:emacs-devel-request@gnu.org?subject=subscribe>
List-Archive: <http://mail.gnu.org/pipermail/emacs-devel>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/emacs-devel>,
	<mailto:emacs-devel-request@gnu.org?subject=unsubscribe>
Errors-To: emacs-devel-bounces+emacs-devel=quimby.gnus.org@gnu.org
Xref: main.gmane.org gmane.emacs.devel:10299
X-Report-Spam: http://spam.gmane.org/gmane.emacs.devel:10299

Miles Bader <miles@lsi.nec.co.jp> writes:

> There are a number of face manipulation functions in faces.el of the
> form `set-face-FOO-p'.  I think such names are misleading, since they use
> the -p prefix on functions which aren't predicates.

The names are badly chosen (having both 'set-' and '-p' is confusing),
but if you read the names like this, it does make sense:

        set-face - FOO-p

I would argue that 'set-' takes precedence over '-p' here...

> 
> Any objections to me renaming them to just `set-face-FOO', and adding
> aliases (and make-obolete) for the old names?

IMHO, there is an abundance of silly functions and commands in
faces.el; I don't see any reason to rename a few of them (which are
rarely used anyway - I found only 5 places total).  

So I object.