From mboxrd@z Thu Jan 1 00:00:00 1970 Path: main.gmane.org!not-for-mail From: storm@cua.dk (Kim F. Storm) Newsgroups: gmane.emacs.devel Subject: Re: C-h k, C-h f and keyboard macros: Patch. Date: 11 Feb 2003 16:36:41 +0100 Sender: emacs-devel-bounces+emacs-devel=quimby.gnus.org@gnu.org Message-ID: <5xadh2vng6.fsf@kfs2.cua.dk> References: <20030211134619.B425.LEKTU@terra.es> <5xisvqvrac.fsf@kfs2.cua.dk> <20030211150612.B42B.LEKTU@terra.es> <5xel6evobb.fsf@kfs2.cua.dk> NNTP-Posting-Host: main.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: main.gmane.org 1044974243 6527 80.91.224.249 (11 Feb 2003 14:37:23 GMT) X-Complaints-To: usenet@main.gmane.org NNTP-Posting-Date: Tue, 11 Feb 2003 14:37:23 +0000 (UTC) Cc: emacs-devel@gnu.org Return-path: Original-Received: from quimby.gnus.org ([80.91.224.244]) by main.gmane.org with esmtp (Exim 3.35 #1 (Debian)) id 18ibXF-0001h9-00 for ; Tue, 11 Feb 2003 15:37:21 +0100 Original-Received: from monty-python.gnu.org ([199.232.76.173]) by quimby.gnus.org with esmtp (Exim 3.12 #1 (Debian)) id 18ibim-0002am-00 for ; Tue, 11 Feb 2003 15:49:16 +0100 Original-Received: from localhost ([127.0.0.1] helo=monty-python.gnu.org) by monty-python.gnu.org with esmtp (Exim 4.10.13) id 18ibY2-00087d-02 for emacs-devel@quimby.gnus.org; Tue, 11 Feb 2003 09:38:10 -0500 Original-Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.10.13) id 18ibXg-0007zu-00 for emacs-devel@gnu.org; Tue, 11 Feb 2003 09:37:48 -0500 Original-Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.10.13) id 18ibXf-0007z2-00 for emacs-devel@gnu.org; Tue, 11 Feb 2003 09:37:48 -0500 Original-Received: from mail.filanet.dk ([195.215.206.179]) by monty-python.gnu.org with esmtp (Exim 4.10.13) id 18ibXQ-0007Z1-00 for emacs-devel@gnu.org; Tue, 11 Feb 2003 09:37:32 -0500 Original-Received: from kfs2.cua.dk.cua.dk (kfs2.local.filanet.dk [192.168.1.182]) by mail.filanet.dk (Postfix) with SMTP id 9C6897C012; Tue, 11 Feb 2003 15:37:31 +0100 (CET) Original-To: Juanma Barranquero In-Reply-To: <5xel6evobb.fsf@kfs2.cua.dk> Original-Lines: 37 User-Agent: Gnus/5.09 (Gnus v5.9.0) Emacs/21.3.50 Original-cc: Luc Teirlinck X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1b5 Precedence: list List-Id: Emacs development discussions. List-Help: List-Post: List-Subscribe: , List-Archive: List-Unsubscribe: , Errors-To: emacs-devel-bounces+emacs-devel=quimby.gnus.org@gnu.org Xref: main.gmane.org gmane.emacs.devel:11560 X-Report-Spam: http://spam.gmane.org/gmane.emacs.devel:11560 storm@cua.dk (Kim F. Storm) writes: > > Here is a version of the patch which fixes this problem: > > ! (let* ((remapped (and (symbolp function) (remap-command function))) Thinking more about it, I would argue that since remap-command may in practice be applied to anything that is found in a keymap (as was the case here), it would be better to just return nil if the argument is not a symbol. I have just committed that change! So with latest CVS head, the previous version of the patch is still ok: Index: help-fns.el =================================================================== RCS file: /cvsroot/emacs/emacs/lisp/help-fns.el,v retrieving revision 1.28 diff -c -r1.28 help-fns.el *** help-fns.el 4 Feb 2003 11:23:06 -0000 1.28 --- help-fns.el 11 Feb 2003 14:36:31 -0000 *************** *** 323,328 **** --- 323,331 ---- function))))) usage) (car usage)) + ((or (stringp def) + (vectorp def)) + (format "\nMacro: %s" (format-kbd-macro def))) (t "[Missing arglist. Please make a bug report.]"))) (terpri)) (let ((obsolete (and -- Kim F. Storm http://www.cua.dk