From: storm@cua.dk (Kim F. Storm)
Cc: emacs-devel@gnu.org
Subject: Re: silly face function names
Date: 20 Dec 2002 12:28:56 +0100 [thread overview]
Message-ID: <5x8yyl0w07.fsf@kfs2.cua.dk> (raw)
In-Reply-To: <buon0n1gfzc.fsf@mcspd15.ucom.lsi.nec.co.jp>
Miles Bader <miles@lsi.nec.co.jp> writes:
> storm@cua.dk (Kim F. Storm) writes:
> > The names are badly chosen (having both 'set-' and '-p' is confusing),
> > but if you read the names like this, it does make sense:
> >
> > set-face - FOO-p
> >
> > I would argue that 'set-' takes precedence over '-p' here...
>
> I'd argue that you're wrong -- `FOO-p' is not a thing which you can set.
> Faces have an `inverse-video' property, and `face-inverse-video-p' is
> merely the name of the predicate which tests that property.
>
> Having bogus function names around in emacs-proper just serves to
> confuse people and cause the _next_ generation of bogus function names.
Ok, but since we already have N ways to do this:
(make-face-FOO face [F])
(make-face-unFOO face [F])
(set-face-attribute face F :FOO bool)
(set-face-FOO-p face bool [F])
So I really don't see _any_ reason to add an N+1'th way to do the same:
(set-face-FOO face bool [F])
Instead, I'd suggest simply to mark the set-face-FOO-p obsolete, and
change the few existing uses of those functions to use one of the other
alternatives above.
--
Kim F. Storm <storm@cua.dk> http://www.cua.dk
next prev parent reply other threads:[~2002-12-20 11:28 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-12-20 7:43 silly face function names Miles Bader
2002-12-20 10:53 ` Kim F. Storm
2002-12-20 10:08 ` Miles Bader
2002-12-20 11:28 ` Kim F. Storm [this message]
2002-12-20 13:22 ` Robert J. Chassell
2002-12-20 14:46 ` Kim F. Storm
2003-01-10 23:21 ` Stefan Monnier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5x8yyl0w07.fsf@kfs2.cua.dk \
--to=storm@cua.dk \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.