From mboxrd@z Thu Jan 1 00:00:00 1970 Path: quimby.gnus.org!not-for-mail From: storm@cua.dk (Kim F. Storm) Newsgroups: gmane.emacs.devel Subject: Re: [ulrich@a0.complang.tuwien.ac.at: blink-cursor improvement suggestion] Date: 26 Feb 2002 12:02:03 +0100 Message-ID: <5x664k33ro.fsf@kfs2.cua.dk> References: <200202250009.g1P09cn15738@aztec.santafe.edu> <5xit8lcl9m.fsf@kfs2.cua.dk> NNTP-Posting-Host: quimby2.netfonds.no Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: quimby2.netfonds.no 1014722558 319 195.204.10.66 (26 Feb 2002 11:22:38 GMT) X-Complaints-To: usenet@quimby2.netfonds.no NNTP-Posting-Date: 26 Feb 2002 11:22:38 GMT Original-Received: from fencepost.gnu.org ([199.232.76.164]) by quimby2.netfonds.no with esmtp (Exim 3.12 #1 (Debian)) id 16ffgs-000053-00 for ; Tue, 26 Feb 2002 12:22:38 +0100 Original-Received: from localhost ([127.0.0.1] helo=fencepost.gnu.org) by fencepost.gnu.org with esmtp (Exim 3.33 #1 (Debian)) id 16ffOE-0002sb-00; Tue, 26 Feb 2002 06:03:22 -0500 Original-Received: from mail.filanet.dk ([195.215.206.179]) by fencepost.gnu.org with smtp (Exim 3.33 #1 (Debian)) id 16ffM7-0001jZ-00; Tue, 26 Feb 2002 06:01:11 -0500 Original-Received: from kfs2.cua.dk.cua.dk (kfs2.local.filanet.dk [192.168.1.182]) by mail.filanet.dk (Postfix) with SMTP id 877877C035; Tue, 26 Feb 2002 11:00:57 +0000 (GMT) Original-To: Jason Rumney , rms@gnu.org, emacs-devel@gnu.org In-Reply-To: <5xit8lcl9m.fsf@kfs2.cua.dk> Original-Lines: 80 User-Agent: Gnus/5.09 (Gnus v5.9.0) Emacs/21.2.50 Errors-To: emacs-devel-admin@gnu.org X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.0.5 Precedence: bulk List-Help: List-Post: List-Subscribe: , List-Id: Emacs development discussions. List-Unsubscribe: , List-Archive: Xref: quimby.gnus.org gmane.emacs.devel:1543 X-Report-Spam: http://spam.gmane.org/gmane.emacs.devel:1543 storm@cua.dk (Kim F. Storm) writes: > Alternatively, it could "blink" between the hollow and normal cursor > shapes. Then we don't need an extra face. Below you'll find a patch which does this (when the block cursor is used). What do you think? Index: xterm.c =================================================================== RCS file: /cvs/emacs/src/xterm.c,v retrieving revision 1.707 diff -c -r1.707 xterm.c *** xterm.c 23 Feb 2002 16:33:00 -0000 1.707 --- xterm.c 26 Feb 2002 10:59:31 -0000 *************** *** 11640,11647 **** else new_cursor_type = HOLLOW_BOX_CURSOR; } - else if (w->cursor_off_p) - new_cursor_type = NO_CURSOR; else { struct buffer *b = XBUFFER (w->buffer); --- 11640,11645 ---- *************** *** 11651,11656 **** --- 11649,11661 ---- else new_cursor_type = x_specified_cursor_type (b->cursor_type, &new_cursor_width); + if (w->cursor_off_p) + { + if (new_cursor_type == FILLED_BOX_CURSOR) + new_cursor_type = HOLLOW_BOX_CURSOR; + else + new_cursor_type = NO_CURSOR; + } } } Index: w32term.c =================================================================== RCS file: /cvs/emacs/src/w32term.c,v retrieving revision 1.146 diff -c -r1.146 w32term.c *** w32term.c 23 Feb 2002 16:28:28 -0000 1.146 --- w32term.c 26 Feb 2002 10:59:32 -0000 *************** *** 9759,9766 **** else new_cursor_type = HOLLOW_BOX_CURSOR; } - else if (w->cursor_off_p) - new_cursor_type = NO_CURSOR; else { struct buffer *b = XBUFFER (w->buffer); --- 9759,9764 ---- *************** *** 9770,9775 **** --- 9768,9780 ---- else new_cursor_type = x_specified_cursor_type (b->cursor_type, &new_cursor_width); + if (w->cursor_off_p) + { + if (new_cursor_type == FILLED_BOX_CURSOR) + new_cursor_type = HOLLOW_BOX_CURSOR; + else + new_cursor_type = NO_CURSOR; + } } } -- Kim F. Storm http://www.cua.dk _______________________________________________ Emacs-devel mailing list Emacs-devel@gnu.org http://mail.gnu.org/mailman/listinfo/emacs-devel