From mboxrd@z Thu Jan 1 00:00:00 1970 Path: main.gmane.org!not-for-mail From: storm@cua.dk (Kim F. Storm) Newsgroups: gmane.emacs.devel Subject: Re: gratuitous changes Date: 02 Feb 2003 14:59:42 +0100 Sender: emacs-devel-bounces+emacs-devel=quimby.gnus.org@gnu.org Message-ID: <5x65s2lr5d.fsf@kfs2.cua.dk> References: NNTP-Posting-Host: main.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: main.gmane.org 1044190874 5362 80.91.224.249 (2 Feb 2003 13:01:14 GMT) X-Complaints-To: usenet@main.gmane.org NNTP-Posting-Date: Sun, 2 Feb 2003 13:01:14 +0000 (UTC) Cc: Stefan Monnier Return-path: Original-Received: from quimby.gnus.org ([80.91.224.244]) by main.gmane.org with esmtp (Exim 3.35 #1 (Debian)) id 18fJkH-0001OK-00 for ; Sun, 02 Feb 2003 14:01:13 +0100 Original-Received: from monty-python.gnu.org ([199.232.76.173]) by quimby.gnus.org with esmtp (Exim 3.12 #1 (Debian)) id 18fJrO-0002Ry-00 for ; Sun, 02 Feb 2003 14:08:34 +0100 Original-Received: from localhost ([127.0.0.1] helo=monty-python.gnu.org) by monty-python.gnu.org with esmtp (Exim 4.10.13) id 18fJlI-0006d7-08 for emacs-devel@quimby.gnus.org; Sun, 02 Feb 2003 08:02:16 -0500 Original-Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.10.13) id 18fJky-0006RI-00 for emacs-devel@gnu.org; Sun, 02 Feb 2003 08:01:56 -0500 Original-Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.10.13) id 18fJkq-0006CV-00 for emacs-devel@gnu.org; Sun, 02 Feb 2003 08:01:50 -0500 Original-Received: from mail.filanet.dk ([195.215.206.179]) by monty-python.gnu.org with esmtp (Exim 4.10.13) id 18fJjg-0005XS-00 for emacs-devel@gnu.org; Sun, 02 Feb 2003 08:00:36 -0500 Original-Received: from kfs2.cua.dk.cua.dk (unknown [10.1.82.3]) by mail.filanet.dk (Postfix) with SMTP id A64EB7C018; Sun, 2 Feb 2003 14:00:28 +0100 (CET) Original-To: Eli Zaretskii In-Reply-To: Original-Lines: 34 User-Agent: Gnus/5.09 (Gnus v5.9.0) Emacs/21.3.50 Original-cc: emacs-devel@gnu.org X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1b5 Precedence: list List-Id: Emacs development discussions. List-Help: List-Post: List-Subscribe: , List-Archive: List-Unsubscribe: , Errors-To: emacs-devel-bounces+emacs-devel=quimby.gnus.org@gnu.org Xref: main.gmane.org gmane.emacs.devel:11290 X-Report-Spam: http://spam.gmane.org/gmane.emacs.devel:11290 Eli Zaretskii writes: > On Fri, 31 Jan 2003, Stefan Monnier wrote: > > > I am responsible for a fair bit of spurious changes in that I often > > remove trailing whitespace when I come across it and thus end > > up comitting changes to more than the places where I've actually > > modified the code. > > > > But I still think that what happened with keyboard.c is bad: > > turning every whitespace-only line into an empty line. > > I generally dislike unnecessary whitespace changes as well: for one > thing, they make diffs much harder to grasp. And merging a nightmare. Making cosmetic changes to source code on the trunk of a CVS project tree often makes it much harder to merge changes from a branch to the trunk. E.g. when it's time to merge the emacs unicode branch to the head, there is a bigger risk of merge conflicts in code which really doesn't differ except for white space. > > However, I must say that when I brought up this issue in the past in the > context of Emacs development, most of other developers didn't feel it was > that bad. So, as extreme as this particular case is, at least in > principle, Emacs development does not seem to discourage such gratuitous > changes. At least it didn't until now. > Maybe because we have been spared from the troubles of large-scale merging of branches... -- Kim F. Storm http://www.cua.dk