From: Glenn Morris <rgm@gnu.org>
To: Stefan Monnier <monnier@iro.umontreal.ca>
Cc: emacs-devel@gnu.org
Subject: Re: /srv/bzr/emacs/trunk r107646: * lisp/files.el (move-file-to-trash): Files aren't regexps.
Date: Wed, 21 Mar 2012 15:10:16 -0400 [thread overview]
Message-ID: <5sfwd1lqhz.fsf@fencepost.gnu.org> (raw)
In-Reply-To: E1SAQ61-0002vF-Rw@vcs.savannah.gnu.org
Stefan Monnier wrote:
> ;; We can't trash a parent directory of trash-directory.
> - (if (string-match fn trash-dir)
> + (if (string-prefix-p fn trash-dir)
> (error "Trash directory `%s' is a subdirectory of `%s'"
> trash-dir filename))
Would the recently added file-subdir-of-p be more appropriate?
Also, I'd never heard of string-prefix-p (added in 23.2). It was never
mentioned in NEWS or documented in the manual.
It also exists as vc-string-prefix-p, latex-string-prefix-p,
tex-string-prefix-p, cvs-string-prefix-p, mpc-string-prefix-p...
next parent reply other threads:[~2012-03-21 19:10 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <E1SAQ61-0002vF-Rw@vcs.savannah.gnu.org>
2012-03-21 19:10 ` Glenn Morris [this message]
2012-03-21 21:14 ` /srv/bzr/emacs/trunk r107646: * lisp/files.el (move-file-to-trash): Files aren't regexps Stefan Monnier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5sfwd1lqhz.fsf@fencepost.gnu.org \
--to=rgm@gnu.org \
--cc=emacs-devel@gnu.org \
--cc=monnier@iro.umontreal.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.