Re: trunk r117448: New if-let, when-let, thread-first and thread-last macros.

Re: trunk r117448: New if-let, when-let, thread-first and thread-last macros.

[Glenn Morris]

Fabián Ezequiel Gallina wrote:

> +---
> +** New macros `if-let' and `when-let' allow defining bindings and to
> +   execute code depending whether all values are a true.
> +
> +---
> +** New macros `thread-first' and `thread-last' allow threading a form
> +   as the first or last argument of subsequent forms.

Probably should mention that these are in subr-x.el, since it is not
loaded by default.

> +	* automated/subr-x-tests.el
> +	(subr-x-test-if-let-single-binding-expansion)
> +	(subr-x-test-if-let-single-symbol-expansion)
> +	(subr-x-test-if-let-nil-related-expansion)
> +	(subr-x-test-if-let-malformed-binding, subr-x-test-if-let-true)
> +	(subr-x-test-if-let-false, subr-x-test-if-let-bound-references)
> +	(subr-x-test-if-let-and-lazyness-is-preserved)
> +	(subr-x-test-when-let-body-expansion)
> +	(subr-x-test-when-let-single-binding-expansion)
> +	(subr-x-test-when-let-single-symbol-expansion)
> +	(subr-x-test-when-let-nil-related-expansion)
> +	(subr-x-test-when-let-malformed-binding)
> +	(subr-x-test-when-let-true, subr-x-test-when-let-false)
> +	(subr-x-test-when-let-bound-references)
> +	(subr-x-test-when-let-and-lazyness-is-preserved)
> +	(subr-x-test-thread-first-no-forms)
> +	(subr-x-test-thread-first-function-names-are-threaded)
> +	(subr-x-test-thread-first-expansion)
> +	(subr-x-test-thread-last-no-forms)
> +	(subr-x-test-thread-last-function-names-are-threaded)
> +	(subr-x-test-thread-last-expansion): New tests.

You can just say "New file".

> +;; Copyright (C) 2011-2014 Free Software Foundation, Inc.

Why copyright 2011, 2012, 2013, when the file (and many of the things it
is testing) did not exist till 2014?

Re: trunk r117448: New if-let, when-let, thread-first and thread-last macros.

[Fabián Ezequiel Gallina]

Glenn Morris <rgm@gnu.org> writes:

> Fabián Ezequiel Gallina wrote:
>
>> +---
>> +** New macros `if-let' and `when-let' allow defining bindings and to
>> +   execute code depending whether all values are a true.
>> +
>> +---
>> +** New macros `thread-first' and `thread-last' allow threading a form
>> +   as the first or last argument of subsequent forms.
>
> Probably should mention that these are in subr-x.el, since it is not
> loaded by default.
>
>> +	* automated/subr-x-tests.el
>> +	(subr-x-test-if-let-single-binding-expansion)
>> +	(subr-x-test-if-let-single-symbol-expansion)
>> +	(subr-x-test-if-let-nil-related-expansion)
>> +	(subr-x-test-if-let-malformed-binding, subr-x-test-if-let-true)
>> +	(subr-x-test-if-let-false, subr-x-test-if-let-bound-references)
>> +	(subr-x-test-if-let-and-lazyness-is-preserved)
>> +	(subr-x-test-when-let-body-expansion)
>> +	(subr-x-test-when-let-single-binding-expansion)
>> +	(subr-x-test-when-let-single-symbol-expansion)
>> +	(subr-x-test-when-let-nil-related-expansion)
>> +	(subr-x-test-when-let-malformed-binding)
>> +	(subr-x-test-when-let-true, subr-x-test-when-let-false)
>> +	(subr-x-test-when-let-bound-references)
>> +	(subr-x-test-when-let-and-lazyness-is-preserved)
>> +	(subr-x-test-thread-first-no-forms)
>> +	(subr-x-test-thread-first-function-names-are-threaded)
>> +	(subr-x-test-thread-first-expansion)
>> +	(subr-x-test-thread-last-no-forms)
>> +	(subr-x-test-thread-last-function-names-are-threaded)
>> +	(subr-x-test-thread-last-expansion): New tests.
>
> You can just say "New file".
>
>> +;; Copyright (C) 2011-2014 Free Software Foundation, Inc.
>
> Why copyright 2011, 2012, 2013, when the file (and many of the things it
> is testing) did not exist till 2014?
>

All of these fixed in revno 117454.



Regards,
Fabián