From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Glenn Morris Newsgroups: gmane.emacs.devel Subject: Re: master 583995c: GnuTLS HMAC and symmetric cipher support Date: Tue, 18 Jul 2017 17:02:31 -0400 Message-ID: <5kzic131co.fsf@fencepost.gnu.org> References: <20170714150706.13106.18905@vcs0.savannah.gnu.org> <20170714150707.5E9B322DF8@vcs0.savannah.gnu.org> <87eftfdu5g.fsf@lifelogs.com> <7kzic356o4.fsf@fencepost.gnu.org> <34d18yexh0.fsf@fencepost.gnu.org> <2ztw2auan0.fsf@fencepost.gnu.org> <3f44fabe-80b7-8a01-2b64-0a33b2a311b3@cs.ucla.edu> <02lgnm1zjh.fsf@fencepost.gnu.org> <22246710-dc3b-f146-1812-cc374a709f0b@cs.ucla.edu> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1500411871 6274 195.159.176.226 (18 Jul 2017 21:04:31 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Tue, 18 Jul 2017 21:04:31 +0000 (UTC) User-Agent: Gnus (www.gnus.org), GNU Emacs (www.gnu.org/software/emacs/) Cc: Emacs developers , Noam Postavsky To: Paul Eggert Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Jul 18 23:04:27 2017 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dXZfP-0001Rf-KL for ged-emacs-devel@m.gmane.org; Tue, 18 Jul 2017 23:04:27 +0200 Original-Received: from localhost ([::1]:58620 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dXZfV-0003Gt-7m for ged-emacs-devel@m.gmane.org; Tue, 18 Jul 2017 17:04:33 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:38965) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dXZdl-0002Ft-Jz for emacs-devel@gnu.org; Tue, 18 Jul 2017 17:02:46 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dXZdk-0002GR-RV for emacs-devel@gnu.org; Tue, 18 Jul 2017 17:02:45 -0400 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:59102) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dXZdX-00029J-Nd; Tue, 18 Jul 2017 17:02:31 -0400 Original-Received: from rgm by fencepost.gnu.org with local (Exim 4.82) (envelope-from ) id 1dXZdX-0007Ud-DP; Tue, 18 Jul 2017 17:02:31 -0400 X-Spook: Execution AK-47 PGP Critical infrastructure fissionable X-Ran: ?tETK (Paul Eggert's message of "Tue, 18 Jul 2017 13:44:14 -0700") X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:216862 Archived-At: Paul Eggert wrote: > For example, on my platform, if I compile and run the attached program via: > > gcc gs.c -lgnutls > ./a.out > > the program silently succeeds. What happens on your platform? Your example doesn't correspond to how the code in Emacs used to be. Change it to: for (int pos = 0; gciphers[pos] != GNUTLS_CIPHER_NULL; pos++) and it fails for me, just as Emacs used to: gciphers[17] == GNUTLS_CIPHER_UNKNOWN ?!? As I said, it seems to be a happy accident that GNUTLS_CIPHER_UNKNOWN == 0. So your example as written happens to skip it. I hope we have now established I'm not mad or lying... :)