From: Glenn Morris <rgm@gnu.org>
To: Barry OReilly <gundaetiapo@gmail.com>
Cc: 15745@debbugs.gnu.org
Subject: bug#15745: [PATCH] Define semantic-idle-symbol-highlight-face with defface
Date: Mon, 28 Oct 2013 17:38:47 -0400 [thread overview]
Message-ID: <5htxg1jct4.fsf@fencepost.gnu.org> (raw)
In-Reply-To: <CAFM41H1RMRVMpvnRiJzPG0Yu3eB4KaX-h5MuepfbuqXWbbeQow@mail.gmail.com>
New face names should not end in -face.
The standard backwards-compatible way to make a change like this is:
1) Add:
(defface semantic-idle-symbol-highlight ...)
2) Change:
(defvar semantic-idle-symbol-highlight-face 'semantic-idle-symbol-highlight)
3) Mark semantic-idle-symbol-highlight-face the variable obsolete,
in favour of semantic-idle-symbol-highlight the face.
See eg diary-face.
next prev parent reply other threads:[~2013-10-28 21:38 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-28 21:04 bug#15745: [PATCH] Define semantic-idle-symbol-highlight-face with defface Barry OReilly
2013-10-28 21:38 ` Glenn Morris [this message]
2013-10-28 22:36 ` Barry OReilly
2013-10-29 2:29 ` Glenn Morris
2013-10-29 15:56 ` Barry OReilly
2013-10-29 22:37 ` Glenn Morris
2013-10-31 1:55 ` Barry OReilly
2013-10-29 1:38 ` Stefan Monnier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5htxg1jct4.fsf@fencepost.gnu.org \
--to=rgm@gnu.org \
--cc=15745@debbugs.gnu.org \
--cc=gundaetiapo@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.