From: Glenn Morris <rgm@gnu.org>
To: 10566-done@debbugs.gnu.org
Subject: bug#10566: some files bind to global-map "C-x" instead of ctl-x-map
Date: Wed, 25 Jan 2012 21:37:58 -0500 [thread overview]
Message-ID: <5gsjj3rxx5.fsf@fencepost.gnu.org> (raw)
In-Reply-To: <20120120.212342.1876052013036691683.teika@lavabit.com> (Teika Kazura's message of "Fri, 20 Jan 2012 21:23:42 +0900 (JST)")
Version: 24.0.93
Teika Kazura wrote:
> In recent versions of emacs - at least in 23.3.3 and 24.0.92 -
Since always probably (at least 21.1).
> some files do
> (define-key global-map "\C-x\C-j" 'some-command)
> but it has to be
> (define-key ctl-x-map "\C-j" 'some-command)
> If you bind "C-x" to non-keymap, you'll receive an error.
Thanks for the report.
> obsolete/iso-insert.el:624: (define-key global-map "\C-x8" 8859-1-map))
Let's not worry about obsolete things (one more reason to remove it).
> dired-x.el:88: (define-key global-map "\C-x\C-j" 'dired-jump)
> dired-x.el:89: (define-key global-map "\C-x4\C-j" 'dired-jump-other-window))
> dired-x.el:91: (define-key global-map "\C-x\C-j" nil))
> dired-x.el:93: (define-key global-map "\C-x4\C-j" nil))))
Fixed.
> vc/vc-hooks.el:944:(define-key global-map "\C-xv" 'vc-prefix-map)
I don't think this matters, since it is preloaded, so it's impossible to
change the C-x mapping before this point, but I changed it anyway.
> eshell/em-term.el:221:; (lookup-key (current-global-map) "\C-x"))
> eshell/em-term.el:244:; (copy-keymap (lookup-key (current-global-map) "\C-x")))
Let's not worry about code that has never been uncommented.
> term.el:911: (copy-keymap (lookup-key (current-global-map) "\C-x")))
Changed.
> term.el:3484: (lookup-key (current-global-map) "\C-x"))
I think it is appropriate to leave this as-is.
> obsolete/iso-insert.el:623: (if (not (lookup-key global-map "\C-x8"))
Obsolete, ignoring.
> dired-x.el:90: (if (eq 'dired-jump (lookup-key global-map "\C-x\C-j"))
> dired-x.el:92: (if (eq 'dired-jump-other-window (lookup-key global-map "\C-x4\C-j"))
Fixed.
prev parent reply other threads:[~2012-01-26 2:37 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-20 12:23 bug#10566: some files bind to global-map "C-x" instead of ctl-x-map Teika Kazura
2012-01-26 2:37 ` Glenn Morris [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5gsjj3rxx5.fsf@fencepost.gnu.org \
--to=rgm@gnu.org \
--cc=10566-done@debbugs.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.