From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Mauro Aranda Newsgroups: gmane.emacs.bugs Subject: bug#45623: 28.0.50; widget-backward sometimes skips one widget Date: Mon, 04 Jan 2021 09:41:12 -0300 Message-ID: <5ff30ceb.1c69fb81.db5ba.99bf@mx.google.com> References: <5ff1d1a3.1c69fb81.41cd3.92bc@mx.google.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="11038"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 45623@debbugs.gnu.org To: Lars Ingebrigtsen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Jan 04 13:42:21 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kwPBk-0002kL-S9 for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 04 Jan 2021 13:42:20 +0100 Original-Received: from localhost ([::1]:59134 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kwPBj-00062n-Go for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 04 Jan 2021 07:42:19 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:49098) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kwPBR-00062d-VW for bug-gnu-emacs@gnu.org; Mon, 04 Jan 2021 07:42:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:46521) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kwPBR-0005tT-OD for bug-gnu-emacs@gnu.org; Mon, 04 Jan 2021 07:42:01 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kwPBR-0002iE-M0 for bug-gnu-emacs@gnu.org; Mon, 04 Jan 2021 07:42:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Mauro Aranda Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 04 Jan 2021 12:42:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 45623 X-GNU-PR-Package: emacs Original-Received: via spool by 45623-submit@debbugs.gnu.org id=B45623.160976408410373 (code B ref 45623); Mon, 04 Jan 2021 12:42:01 +0000 Original-Received: (at 45623) by debbugs.gnu.org; 4 Jan 2021 12:41:24 +0000 Original-Received: from localhost ([127.0.0.1]:58066 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kwPAq-0002hF-6B for submit@debbugs.gnu.org; Mon, 04 Jan 2021 07:41:24 -0500 Original-Received: from mail-qt1-f170.google.com ([209.85.160.170]:37348) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kwPAn-0002h0-W6 for 45623@debbugs.gnu.org; Mon, 04 Jan 2021 07:41:22 -0500 Original-Received: by mail-qt1-f170.google.com with SMTP id z9so18302443qtn.4 for <45623@debbugs.gnu.org>; Mon, 04 Jan 2021 04:41:21 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=message-id:from:to:cc:subject:in-reply-to:date:mime-version; bh=+tBz4rAWbOMMXe+vSrdN2sLokDr62EbG8cabSUA8YYU=; b=NOOKFgwICeqqhgNXeydrIX8KT6OGFhF1P0SNiYmaJaRQj/rIDhN/kN9Snhw0sRkANV J6m2qkTJ5oQJ2LwkMo+L07xc3ZLoXJM8i2Ic51pFQIRh1oELVwlfo46aEdCKD05NgeR7 fhJ5/rMNAJGA/vMtxdHFsK33iPzSJRNlx3IDHKymzz68SWguEL9H0j0kzr9C+XpsxCCq 2gPAZnVACetdrDCNINDj1mRHhwLT7erKN72PsHVlt6Ae5akgOSBr4u+y30NbynNZDAuT x2K7F/vJkSjtbL3NljzfDBUQ7C7+GECiFvu9RaPnzDv+sTQ0fEUx1XCvuA22//FaALsO sLmA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:message-id:from:to:cc:subject:in-reply-to:date :mime-version; bh=+tBz4rAWbOMMXe+vSrdN2sLokDr62EbG8cabSUA8YYU=; b=NA/kBGAumqTmY+yKk4jrcnveEhce1Y/GCi8tfikJikA250gPAjU+XiPoDnDCnAEPwv TumkQJF4Bxj82UZ2r/60MvJKE1HHBLkweKSZ4dNyi+Pz5WqDANj3ZoKRHsu3XMm/nDdl kt5i3owu3BCj3QCPXEbsmtTzuzhVkTyqQILE+QceiM7u79aHQbDdHX33pZYYCV1jWKzE XgCtU75zblgJc+y2WZF6xwvJNQ7i24himYnas9U2XNEY3rPGhUehNO8Y2wHDFfO4Kszj iqCpUaJskZbdpxtsuUAa+JDIAPL7Yw3vLlR9q9veWko5OpIIefgnxeiaPj9Zu9RoDw3C ouGQ== X-Gm-Message-State: AOAM531SmkTunVXkU+9/S//ov1JdH3bSCoN13qhGCfAEkQ27y6990KBz fBm0rqNHNvVVkSF3/bngkoQGbP9LZlk= X-Google-Smtp-Source: ABdhPJw8+3xXMxJDrwx7ndhYVXNzEFhW9YME2pFyEtiwBJFR21BIfzHZFHQyrR9bXVAseMrPb76aZg== X-Received: by 2002:ac8:1282:: with SMTP id y2mr68894132qti.283.1609764076214; Mon, 04 Jan 2021 04:41:16 -0800 (PST) Original-Received: from tbb-desktop ([201.213.132.172]) by smtp.gmail.com with ESMTPSA id p15sm36888789qke.11.2021.01.04.04.41.14 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Mon, 04 Jan 2021 04:41:15 -0800 (PST) X-Google-Original-Message-ID: <87k0ss50yf.fsf@maurooaranda@gmail.com> In-Reply-To: <8735zh57ij.fsf@gnus.org> (message from Lars Ingebrigtsen on Mon, 04 Jan 2021 11:19:32 +0100) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:197301 Archived-At: --=-=-= Content-Type: text/plain Lars Ingebrigtsen writes: > Mauro Aranda writes: > >> I don't understand why that call to backward-char is there. Does anyone >> know of a situation where it is useful? > > If point is just after a button, it makes C-M-i not going to that > button, but the previous one? But that doesn't really sound like > something you'd want, either? > > So, no, I don't see any situation where it would useful -- looks like a > misfeature to me. Agreed. So, any objections to installing this patch and see if something breaks? --=-=-= Content-Type: text/x-patch Content-Disposition: inline; filename=0001-Don-t-skip-widgets-when-moving-backward.patch Content-Description: Patch >From 86c211725ab39ddfc569a16fefd0db6724651b43 Mon Sep 17 00:00:00 2001 From: Mauro Aranda Date: Sun, 3 Jan 2021 11:27:02 -0300 Subject: [PATCH] Don't skip widgets when moving backward * lisp/wid-edit.el (widget-move): Remove code that caused widget-backward to skip a previous adjacent widget when moving backward from the start of a widget. (Bug#45623) * test/lisp/wid-edit-tests.el (widget-test-widget-backward): New test. --- lisp/wid-edit.el | 1 - test/lisp/wid-edit-tests.el | 22 ++++++++++++++++++++++ 2 files changed, 22 insertions(+), 1 deletion(-) diff --git a/lisp/wid-edit.el b/lisp/wid-edit.el index f920130226..8b10d71dcb 100644 --- a/lisp/wid-edit.el +++ b/lisp/wid-edit.el @@ -1204,7 +1204,6 @@ widget-move ARG may be negative to move backward. When the second optional argument is non-nil, nothing is shown in the echo area." - (or (bobp) (> arg 0) (backward-char)) (let ((wrapped 0) (number arg) (old (widget-tabable-at))) diff --git a/test/lisp/wid-edit-tests.el b/test/lisp/wid-edit-tests.el index 35235c6566..f2e8c321f5 100644 --- a/test/lisp/wid-edit-tests.el +++ b/test/lisp/wid-edit-tests.el @@ -301,4 +301,26 @@ widget-test-option-can-handle-inlinable-choice (should child) (should (equal (widget-value widget) '((1 "One"))))))) +(ert-deftest widget-test-widget-backward () + "Test that `widget-backward' works OK." + (with-temp-buffer + (widget-insert "Testing.\n\n") + (dolist (el '("First" "Second" "Third")) + (widget-create 'push-button el)) + (widget-insert "\n") + (goto-char (point-min)) + (use-local-map widget-keymap) + (widget-setup) + ;; Check that moving from the widget's start works. + (widget-forward 3) + (should (string= "Third" (widget-value (widget-at)))) + (widget-backward 1) + (should (string= "Second" (widget-value (widget-at)))) + ;; Check that moving from inside the widget works. + (goto-char (point-min)) + (widget-forward 3) + (forward-char) + (widget-backward 1) + (should (string= "Second" (widget-value (widget-at)))))) + ;;; wid-edit-tests.el ends here -- 2.29.2 --=-=-=--