From: Mauro Aranda <maurooaranda@gmail.com>
To: Drew Adams <drew.adams@oracle.com>
Cc: 35133@debbugs.gnu.org, Lars Ingebrigtsen <larsi@gnus.org>
Subject: bug#35133: 26.1; 1) `:tag' for `restricted-sexp' (not in a choice, set, etc.), 2) Remove `Value Menu' if a no-op
Date: Fri, 11 Dec 2020 11:05:48 -0300 [thread overview]
Message-ID: <5fd37d23.1c69fb81.261a.9f56@mx.google.com> (raw)
In-Reply-To: <3bae30db-9eb9-4185-b549-1cdfd60efc59@default> (Drew Adams's message of "Wed, 9 Dec 2020 15:30:43 -0800 (PST)")
Drew Adams <drew.adams@oracle.com> writes:
> Thanks for looking into this Mauro.
>
> I'd suggest handling this in two stages:
>
> 1. Take care of what is clearly, or pretty clearly,
> straightforward.
> 2. Think about how to handle other cases.
> ____
>
> But in general, for defcustom I think I'm in favor of
> allowing the realization of a :tag, regardless of
> whether using it might be problematic sometimes.
I agree with you. It's just that since it's an intentional behavior (or
at least looks like that), I wanted to make sure we don't miss any
potentially annoying side effects.
> But I guess you're asking about default tags? What
> happens if there's no default :tag for some widget
> (such as `repeat') but when you use the widget you
> provide a :tag? Would that be possible? IOW, maybe
> a :tag for `repeat' isn't useful by default, but
> maybe adding a :tag when you use some `repeat' could
> be useful.
Indeed, I was worried about the default tags. But then I realized that
we already show the "Repeat" tag, when the repeat is part of a choice
type, so it looks like my worries are void. Same goes for the choice
widget inside any other grouping widget.
> (For the problematic cases, maybe the tag text should be
> shown without the trailing colon? Maybe it depends on
> where the tag is placed and how long the string is.)
I think it's better to keep the colon.
> Anyway, for now at least, #1 would be great. Thx.
AFAICS, we should be able to do #1 without trouble, by removing the
:format value-format line, and accounting for the space after the tag
when creating the item.
next prev parent reply other threads:[~2020-12-11 14:05 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-04 3:05 bug#35133: 26.1; 1) `:tag' for `restricted-sexp' (not in a choice, set, etc.), 2) Remove `Value Menu' if a no-op Drew Adams
2020-12-09 14:51 ` Lars Ingebrigtsen
2020-12-09 22:27 ` Mauro Aranda
2020-12-09 23:30 ` Drew Adams
2020-12-11 14:05 ` Mauro Aranda [this message]
2020-12-11 17:26 ` Drew Adams
2020-12-11 14:31 ` Lars Ingebrigtsen
2020-12-11 17:06 ` Mauro Aranda
2020-12-12 10:59 ` Lars Ingebrigtsen
2020-12-13 13:50 ` Mauro Aranda
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5fd37d23.1c69fb81.261a.9f56@mx.google.com \
--to=maurooaranda@gmail.com \
--cc=35133@debbugs.gnu.org \
--cc=drew.adams@oracle.com \
--cc=larsi@gnus.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.