From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: martin rudalics Newsgroups: gmane.emacs.devel Subject: Re: Question about display engine Date: Tue, 3 Sep 2019 10:45:46 +0200 Message-ID: <5fa51eff-75bc-9760-3e6e-af343dedc12e@gmx.at> References: <83zhjrakf9.fsf@gnu.org> <2aff0873-5d18-a4a0-eada-1ad0e632e753@gmx.at> <83mufr9gya.fsf@gnu.org> <03a80221-5222-9b8b-86a1-67cef18df463@gmx.at> <83zhjp937v.fsf@gnu.org> <8acd9fc1-e6ce-9a86-cfb6-e00a672c154a@gmx.at> <20190901122628.aynhzwwpvqbgyydh@Ergus> <20190902110504.zniyfmd7bi53iyxe@Ergus> <83zhjm7juc.fsf@gnu.org> <20190903053331.i36bn2i5ytta2ma7@Ergus> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: quoted-printable Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="24909"; mail-complaints-to="usenet@blaine.gmane.org" Cc: emacs-devel@gnu.org To: Ergus , Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Sep 03 10:50:51 2019 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1i54WY-0006Mn-PG for ged-emacs-devel@m.gmane.org; Tue, 03 Sep 2019 10:50:50 +0200 Original-Received: from localhost ([::1]:42982 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1i54WX-0001pf-7V for ged-emacs-devel@m.gmane.org; Tue, 03 Sep 2019 04:50:49 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:54456) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1i54Rk-0001p0-B2 for emacs-devel@gnu.org; Tue, 03 Sep 2019 04:46:03 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1i54Rj-0001ca-8R for emacs-devel@gnu.org; Tue, 03 Sep 2019 04:45:52 -0400 Original-Received: from mout.gmx.net ([212.227.15.18]:51413) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1i54Ri-0001by-W2; Tue, 03 Sep 2019 04:45:51 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1567500347; bh=khmYXEeQCslom00XdA1IC46Gty/7EKMNufKy6dWMgsg=; h=X-UI-Sender-Class:Subject:To:Cc:References:From:Date:In-Reply-To; b=V4aD3Ujv81cSet1wTBnt6Z8kLgWlBXEkmV8ZzwnNyhXVHJYA8KgJTL8Q6K7B8AjH1 FyHBr6rKb5A8Nnb+av1u/nq7AEd28+rJor5osmPQW6kUArUC6h8KoDyDCy0Gs/TSyA Niz4tZTqe8sf3eQY/y6zBwYjaVLIo1p0ObRiX55g= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Original-Received: from [192.168.1.100] ([212.95.5.255]) by mail.gmx.com (mrgmx002 [212.227.17.190]) with ESMTPSA (Nemesis) id 0Lb4vZ-1iTdkR35i5-00khtt; Tue, 03 Sep 2019 10:45:46 +0200 In-Reply-To: <20190903053331.i36bn2i5ytta2ma7@Ergus> Content-Language: de-DE X-Provags-ID: V03:K1:EB1viDoYP4dIiERXwfDqiGzfeGXIvQ6HNLT999sKR6l6gfxs9WM IobDjlG3fjN7l2K1kOJT6ulRaBhwJebA7uNjWOBzUQW7IRl77BPDS6pdSWvjxt0LIPp6lGF 2xiLpJvP8XTXFCjbgqtmxg6Sgm6LGt1+gfiio2z4tvm5hJ8Gxb0xSg0K9vBTqnTpg2uWsPJ elz7FOjqbTGD8Xae/YtyQ== X-UI-Out-Filterresults: notjunk:1;V03:K0:FpFbB7Opf/c=:huVIuHLb1IjWj47cslp0t+ 3RMt5eKGQ2heVqdvF0fmJRrcAASrV/u8Q/E418323llTsCnzgb3T63MQ+b9jBf0/EnetDo/3o 7foEN0KCFugc9A89jMwx4ntSzlZwUlITh8GLp3uzI6/t6elxWzBnuuH6szswm5HxV1qBebunH Bzd8QwJBUDyOZjFUZt+qgEtigVOX0pY4HW1zeKHKY0GWbbLRif5gkYNCqGVPFy24vtyPBvdYw 8IfRchAIb4akF3HBEpr/gIvUtkcjaOEBJbSfpbwVAv/p61SBQDGiHJHAa8COGka4Ng2pYGfOE YpQVKpdpbBdnWQVhyBM5PhwfJjhx7IdpFCaPJf3LJ2yozVtb17xjHzvtf7WNuCpdKhzvjqJu3 Zh+/WmpDWrVac484ARo0v4ZyaXVr5Sq3wb3Ek2SD5J6BzhK2so2oS/xRElCOh6F8RzcMAJIWr Xx2zWK1m4NiMRT4i0PlI8zvlj/5WDiH9zTaffE1y2oNj+Ae6pTmmgYo7lelyL2XhGwBZLkeca Le4z9GXnRKRzm9nXIOgl56LZFfWJiuNmUkfUsZQctsUQk+VzK5FzFmdC4U3TQobgRNlhTfxJ6 uk0enktm5d/NxJn2cRjmGNBor/xTV8UhQdyoy9tRjpMnLpcPpStvPpL96gOIDEHBDRlUunOc3 gHfLag+24tC6jCl4JF4JVmap0LAujE/EmJKZFBjT4/KXbJcrK3eCMqJ7TX9dHDenbwsU960Qu CEZNLZLJtAzAkHNCRabjPfXM1AwAzP8ne/BQy7gltdFsBoJxKuXBpFd0V0okQtH0YMoP5fxn X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 212.227.15.18 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:239801 Archived-At: > Could any of you give a look to the patch I cannot build Emacs on Windows with the patch due to CC w32select.o =2E./../src/w32term.c: In function 'w32_draw_glyph_string': =2E./../src/w32term.c:2482:20: error: 'struct face' has no member named '= underline_p'; did you mean 'underline'? if (s->face->underline_p) ^~~~~~~~~~~ underline =2E./../src/w32term.c:2484:24: error: 'struct face' has no member named '= underline_type'; did you mean 'underline_color'? if (s->face->underline_type =3D=3D FACE_UNDER_WAVE) ^~~~~~~~~~~~~~ underline_color =2E./../src/w32term.c:2495:29: error: 'struct face' has no member named '= underline_type'; did you mean 'underline_color'? else if (s->face->underline_type =3D=3D FACE_UNDER_LINE) ^~~~~~~~~~~~~~ underline_color =2E./../src/w32term.c:2500:45: error: 'struct face' has no member named '= underline_p'; did you mean 'underline'? if (s->prev && s->prev->face->underline_p ^~~~~~~~~~~ underline =2E./../src/w32term.c:2501:23: error: 'struct face' has no member named '= underline_type'; did you mean 'underline_color'? && s->prev->face->underline_type =3D=3D FACE_UNDER_LINE) ^~~~~~~~~~~~~~ underline_color make[1]: *** [Makefile:402: w32term.o] Fehler 1 make[1]: *** Es wird auf noch nicht beendete Prozesse gewartet.... make[1]: Verzeichnis =E2=80=9E/c/emacs/trunk/non-64/src=E2=80=9C wird ver= lassen make: *** [Makefile:424: src] Fehler 2 and since I don't understand the underline_p/_type rationale I have no good idea how to proceed. > to detect what is failing at > least to triger the merge and extend? > Probably the initialization. (which btw the lisp glue code may be bugg= y > for sure.) I'd run Emacs under gdb to find out whether merge_extend_glyph_face gets called in the first place. And if it doesn't get called, I would continue investigating the places where it should get called. martin