From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Ken Brown Newsgroups: gmane.emacs.bugs Subject: bug#70415: 30.0.50; [Cygwin] `lock-file' creates a symlink with funny name Date: Sun, 5 May 2024 12:21:03 -0400 Message-ID: <5f573c50-4d34-4812-87cb-12abcb38ff54@cornell.edu> References: <861q75juvy.fsf@gnu.org> <86zftsgoxt.fsf@gnu.org> <86frv3r32m.fsf@gnu.org> <3a7eea72-d4ab-4fde-bdad-71b5e8f5bb7f@cornell.edu> <86le4uq0tj.fsf@gnu.org> <26ab8055-1da6-4b3e-a65c-68c598cb7660@cornell.edu> <86zft8n37z.fsf@gnu.org> <618931e0-ad26-4d07-b9c6-8563831a9fb8@cornell.edu> <867cg9fpzv.fsf@gnu.org> <9e83bbd4-13a7-4495-a9dc-d9ad181b5c09@cornell.edu> <86seyweryy.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="18530"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mozilla Thunderbird Cc: yamaoka@jpl.org, 70415@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun May 05 18:22:06 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1s3ecn-0004aM-3H for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 05 May 2024 18:22:05 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1s3ecY-0001zc-IU; Sun, 05 May 2024 12:21:50 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1s3ecN-0001tj-2v for bug-gnu-emacs@gnu.org; Sun, 05 May 2024 12:21:43 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1s3ecM-0007pO-7q for bug-gnu-emacs@gnu.org; Sun, 05 May 2024 12:21:38 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1s3ecj-0001Mk-J0 for bug-gnu-emacs@gnu.org; Sun, 05 May 2024 12:22:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Ken Brown Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 05 May 2024 16:22:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 70415 X-GNU-PR-Package: emacs Original-Received: via spool by 70415-submit@debbugs.gnu.org id=B70415.17149261035239 (code B ref 70415); Sun, 05 May 2024 16:22:01 +0000 Original-Received: (at 70415) by debbugs.gnu.org; 5 May 2024 16:21:43 +0000 Original-Received: from localhost ([127.0.0.1]:60503 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1s3ecR-0001MR-38 for submit@debbugs.gnu.org; Sun, 05 May 2024 12:21:43 -0400 Original-Received: from mail-eastusazon11023014.outbound.protection.outlook.com ([52.101.51.14]:6870 helo=BL0PR05CU006.outbound.protection.outlook.com) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1s3ecN-0001MJ-8F for 70415@debbugs.gnu.org; Sun, 05 May 2024 12:21:42 -0400 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=B/+6GjbIp7xCw7w3VwuFu/5oX3lS9cy5edJ+27dJxcrDwxYTKzg0Nw8cJMciYZMUTFNNusozzfCmlhivBAbpASi0WbHzSzHwBSvusHw6JjhCulpUSk8/qir1BHLzdFoSvoLr4KQxRHyK8Us2ksro7xRwmMaIi4LrJ+ZIuwrJRLdW6C/2UiQzpb1KJgSyRdB+M0PHQjumqhJGBj3x/R8Q3vdVX/Y/HYOY/g2FoQifkWbwMX9E2Wj6OlN4nHc1AgnZzX+t5FZqmKea933MS1K0LvbxYyfJhZIibWso+N0R7hD7ioBzTXv3Y4kCeFDaI2Pk9WfXIfVo0P2HjkmG7aFU/A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=AGXOF8YwsbpyXFKdhRsNW7EyneEwOlbUfVpbGaf78yY=; b=TOXC6VtbV9KGioC6Jkr8Luvipfl2bes++OqrE3dO3XPG9YF49XaHaL0vR9aCji4P78PyizJr4yvjOW1NQBE7kE478zutKP/FCxzRYgznKDV5y7YSj3D4Bn2cccPgSnWtPIGmmUCKiDyx7qs8PcIYp/TNwQ5xNKc+ucy07u5pmYQXLtG3onU9OcJsiXSFUEdTev6fnAefKvWEAuVcJfPXLc/WITXplmFjJ8lVjbdZDWgsCDmAf5Jucp5EThHkHHO4n8+3OQbnPgOCrdqHi5IvnxXjQBn0QIYa96k/aculuzOb1GGd76voXtczJt2W2G6x4Api1dLofvNsigvJUADHkw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=cornell.edu; dmarc=pass action=none header.from=cornell.edu; dkim=pass header.d=cornell.edu; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cornell.edu; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=AGXOF8YwsbpyXFKdhRsNW7EyneEwOlbUfVpbGaf78yY=; b=G+AO2CO6PB1y64grwFUBow9L7u55MbwzUwCFfRMdwhDcC2um0a3EY9G0KkPA2BpW63hUiaMrFnmosHF5+bai1Fj+tQZlKEEBj30ehbtIZuUwmMmRDi7TQ5Pey5NZgnNhlZubd86iMCqg9iGehNipbnUw13fwnfkp2wmoLk7WOY8= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=cornell.edu; Original-Received: from SN6PR04MB5151.namprd04.prod.outlook.com (2603:10b6:805:90::25) by CH3PR04MB8972.namprd04.prod.outlook.com (2603:10b6:610:1a8::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7544.41; Sun, 5 May 2024 16:21:08 +0000 Original-Received: from SN6PR04MB5151.namprd04.prod.outlook.com ([fe80::cb0b:ff0d:6a2a:9ffe]) by SN6PR04MB5151.namprd04.prod.outlook.com ([fe80::cb0b:ff0d:6a2a:9ffe%4]) with mapi id 15.20.7544.041; Sun, 5 May 2024 16:21:07 +0000 Content-Language: en-US In-Reply-To: <86seyweryy.fsf@gnu.org> X-ClientProxiedBy: BLAPR03CA0070.namprd03.prod.outlook.com (2603:10b6:208:329::15) To SN6PR04MB5151.namprd04.prod.outlook.com (2603:10b6:805:90::25) X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SN6PR04MB5151:EE_|CH3PR04MB8972:EE_ X-MS-Office365-Filtering-Correlation-Id: ace4ddce-cf85-4e3d-ff0f-08dc6d1f5e6e X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230031|376005|366007|1800799015; X-Microsoft-Antispam-Message-Info: kWgIhAMEIExMJNdJbB3OeZQNsIBj/9eqyVbi6ZDXd4ANR37A1u+r++M16lQnHtaUGjJKu+Darn7kjWlfecFtoGNbE2Ytn3Brm/23nH88Ovgomwovh3e7yznZpsUcYyRxEsDDcDzsh6bUOws9SDgUp/vLB5m4mLvIoYF1GlSQgQg5Ke8T9JwCicJo56hMBakWBRSzu5yu9/KRg8SaFSEFt/70oLG/+0sDjC+lbgcLCxCnQ2itNhkEYO7+9NnZBRqxVP45gEF4PYaBTx1TYlW40UZRbTbhD8f28++gccrw3uDwEAp/rIwhtFAVcwesHZJuryi2czIItpTozW+VxVp3FHedmW6j9phWmUeR/6lsWUkTdgqRGK7vL0Q4sd3qSIdSaWUWyyb+JQcFmy/0X6ZcAsGoITaskX3mGjzoY707ahFII4ybTcHH0BciEYHQlPfDUciHg0OosI7a04Q/U2dJpyAL0PJtaYntLFTFpQHIKiSC6m1tl0skoaI1yWO5gLO90JkaaYtuKLhvzOMuhjV/bVrb0ibR6tC4i2sg/crgkwLTllESSC+PB9+SAXZ3IgvHgCnKcxX+QI/2uMHr+5icxOrU+x5EFkiuVuth4cPEF60/+I8CKdU/qW2j3GtzFkj4tcVDRt5ROieNeevl+ZOlghN6sg/c/hcrk1IrnMywcOOd2JlRwJUu9MiVokaf2otwah1M9uPVj4HIfBOsaxsudPOs6/fxuLOn/DlK86jEutSXn0prMPyePJPTZqS4l CtL5PYdybvE77nok2h3kKDZPGOKQxrRaWZ31fprkLwToU1GxNVMo8naqeojipt4ZMcCyGuNDZAOsdsu7FtGvtaiF//W2HO9d6j X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SN6PR04MB5151.namprd04.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(376005)(366007)(1800799015); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: HlR6F6xHdhsQavavkvl4qZ5aNFlB4Zd9C4Dxu6CP3Zc+pEgDRD/2KKCT4y/Puj5UgaCTEoNrKCDXs1CAdGYGciNr2sFQs+GRsgDY3LNtYkiauP0qTPDgShJxx7eeu7DgARci3oFhwq++5mtanAJXG+XmGPv+t7sQxtmceVuzudzWGHrFbRsk+hRHsjhqAWqOlf1mt03MIPZ1biY9bqXJGwfr31XyVZ+JgKTMaNIwEfoFLCq5vgHQYcCru5LAYWv40+b+JxGZsHEEgLX8gaM0rQDxUHmtcgMw5jSUQvUgOvvRF7UAJRAFVdUFQzM9nYYI15SIXhABi3SVuqDJEf4xk3wn6xZVnQG9GrEd88SCloEPlC2nGT0G4uYMZgDVkZAE+3kKZ6rVSTX2ZQqOrtcpEgreFTZMDyD+Fj9UBjEinMCWD764dfYm+9eH4n1jmC9NsnBuvffASpybfaYMbnSJ59G8AKdVhcwF6XfqnpO4hrdnKWkZopxygHdJ5L3J8HcqKRJMQZOPtxFw/FJ0YgtWwXW5tNscim8jSQifpULWZMWnmEa6XnLAF9lq50ALuXpxnEwG0YsWxNfRHUaMpcoAvLKfeTnQvmqyf0OV8zY9/mwPqzN8iCNP5dnKWabEDm0cPWQl3CM4zvqzBSsMOEdCgSOejMihO1RuxgrMmxXbBrvGmDZCj7hW2PPWQ/6Z9LOyg/82gg1KYd0bxu/CSyCssa6loQ872FE6K0c6saCeM7vXkQRo5L5RaeK3hf BCcLOlyxHeD7kB8jRb7vPj1+oyGnC++ri6zdQJz0c2Xsw5j7prdNqkPE9bkEVk6ZGnnAVz7PHTdnzyVu47npDcz2FGzZkwRvMX X-OriginatorOrg: cornell.edu X-MS-Exchange-CrossTenant-Network-Message-Id: ace4ddce-cf85-4e3d-ff0f-08dc6d1f5e6e X-MS-Exchange-CrossTenant-AuthSource: SN6PR04MB5151.namprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 May 2024 16:21:07.6881 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 5d7e4366-1b9b-45cf-8e79-b14b27df46e1 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: ppJXSTZCO0k1JhVqfqOiaKKBzfzKgpX4WKJQAJFZWlfFTlj9gMtXgAAGGLhU/ciNYjm4T+FwXqRAGl0kgrpCyQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH3PR04MB8972 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:284510 Archived-At: On 5/5/2024 1:40 AM, Eli Zaretskii wrote: > Right. Does the below look like the right change to support such > weird cases? > > diff --git a/src/filelock.c b/src/filelock.c > index 01d35c4..86c6eeb 100644 > --- a/src/filelock.c > +++ b/src/filelock.c > @@ -419,7 +419,9 @@ current_lock_owner (lock_info_type *owner, Lisp_Object lfname) > boot += 2; > FALLTHROUGH; > case ':': > - if (! c_isdigit (boot[0])) > + if (! c_isdigit (boot[0]) > + /* A negative number. */ > + || (boot[0] == '-' && c_isdigit (boot[1]))) > return EINVAL; > boot_time = strtoimax (boot, &lfinfo_end, 10); > break; Not quite. I think it should be diff --git a/src/filelock.c b/src/filelock.c index 01d35c46726a..faa85a56628b 100644 --- a/src/filelock.c +++ b/src/filelock.c @@ -419,7 +419,9 @@ current_lock_owner (lock_info_type *owner, Lisp_Object lfname) boot += 2; FALLTHROUGH; case ':': - if (! c_isdigit (boot[0])) + if (! (c_isdigit (boot[0]) + /* A negative number. */ + || (boot[0] == '-' && c_isdigit (boot[1])))) return EINVAL; boot_time = strtoimax (boot, &lfinfo_end, 10); break;