From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.bugs Subject: bug#27503: 26.0.50; Not lining up Javascript arguments Date: Mon, 3 Jul 2017 05:11:30 +0300 Message-ID: <5f045d58-fff7-446a-44d3-33d093285ef5@yandex.ru> References: <87FF3D96-DBCF-4EBD-8E72-3F796AB89FF1@fastmail.com> <87fuel70up.fsf@acer.localhost.com> <877ezs7653.fsf@acer.localhost.com> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-Trace: blaine.gmane.org 1499047938 22128 195.159.176.226 (3 Jul 2017 02:12:18 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Mon, 3 Jul 2017 02:12:18 +0000 (UTC) User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:54.0) Gecko/20100101 Thunderbird/54.0 Cc: 27503@debbugs.gnu.org, James Nguyen , james@jojojames.com To: Ingo Lohmar Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Mon Jul 03 04:12:12 2017 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dRqqP-0005JL-2S for geb-bug-gnu-emacs@m.gmane.org; Mon, 03 Jul 2017 04:12:09 +0200 Original-Received: from localhost ([::1]:60003 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dRqqU-0007NU-Ep for geb-bug-gnu-emacs@m.gmane.org; Sun, 02 Jul 2017 22:12:14 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:48654) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dRqqM-0007NE-1g for bug-gnu-emacs@gnu.org; Sun, 02 Jul 2017 22:12:06 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dRqqI-00027p-T3 for bug-gnu-emacs@gnu.org; Sun, 02 Jul 2017 22:12:06 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:46594) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1dRqqI-00027h-PN for bug-gnu-emacs@gnu.org; Sun, 02 Jul 2017 22:12:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1dRqqI-000784-Ei for bug-gnu-emacs@gnu.org; Sun, 02 Jul 2017 22:12:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Dmitry Gutov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 03 Jul 2017 02:12:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 27503 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 27503-submit@debbugs.gnu.org id=B27503.149904790127378 (code B ref 27503); Mon, 03 Jul 2017 02:12:02 +0000 Original-Received: (at 27503) by debbugs.gnu.org; 3 Jul 2017 02:11:41 +0000 Original-Received: from localhost ([127.0.0.1]:49271 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dRqpx-00077W-Da for submit@debbugs.gnu.org; Sun, 02 Jul 2017 22:11:41 -0400 Original-Received: from mail-wr0-f178.google.com ([209.85.128.178]:34983) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dRqpu-00077H-R5 for 27503@debbugs.gnu.org; Sun, 02 Jul 2017 22:11:39 -0400 Original-Received: by mail-wr0-f178.google.com with SMTP id k67so226416001wrc.2 for <27503@debbugs.gnu.org>; Sun, 02 Jul 2017 19:11:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=LbL1VPC3COXzIgLe/uqV253OkfGm5Wks+6mRKuWa/gY=; b=oxWYJ15oj5tJAJ//3QI6ior7055xOn+zC9Q2b8x6SLKqjPL7XA1SkmXPzkX85D4OBF VcQKBSxM/65T9WMpewkUK5IIJBfxkcLt9zq2FJFx/u0OXsTpK0xmJojPSCkPW9fpr38Z +PBlO50V4CZ5q5tv1WIooQ8hNg5WdkaOdcuJFurkLEPGQsnvLaNcdJteonYdHKkdSP8i oveu00hAlh1KdzgoXH/RFW601luu33hJqDUfBPBjjarX/oQBU87RSKy1WpMlovEf4eUb 2mhaIwgkgY4p1MDyHL3Qb8vwTjqAFXhrrfaKpc9VSyB8QKE0PMoRvXY6ujSy/EfaAi0b Dyiw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:cc:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=LbL1VPC3COXzIgLe/uqV253OkfGm5Wks+6mRKuWa/gY=; b=KOZZQa/tCqeiIDX+9qfUt7KHNAqB1lbKdOpYKn970JUslEHImGVoSn+9pg9cwDHwnP YFwX2r/sdayOLvb0lyKX5ugei38pc3N0b084rj1gvseR0fGr9MJzwMB2X/tjX7B22Lx2 7pUm/ocoRHqApAsjDM44kNr4JkSdj61LEANa2lbIS09Hw0Ejs32LjURs+3M9CYfpOJ+G NO2c39eZqCegabp/plWdEoFxBuj6hUgMy8QtAWuu4fDoCLxzxwnsaxLOlM2nvt/yVgYf woA8dE0e0H5DuMuI2T+naYoy9BYojOGbVbdyirNa/cHIDLWfjr3xdfZESRqDFbBnr9X2 qdbA== X-Gm-Message-State: AKS2vOw4IjxKypAK4jU6e8j6vSRc+HUHFcvMnwzgOUswo1q68jcZ1+oX kgjVkDi+053zPg== X-Received: by 10.223.135.68 with SMTP id 4mr23647238wrz.141.1499047892910; Sun, 02 Jul 2017 19:11:32 -0700 (PDT) Original-Received: from [192.168.1.3] ([185.105.174.193]) by smtp.googlemail.com with ESMTPSA id n71sm16695176wrb.62.2017.07.02.19.11.31 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sun, 02 Jul 2017 19:11:32 -0700 (PDT) In-Reply-To: <877ezs7653.fsf@acer.localhost.com> Content-Language: en-US X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:134109 Archived-At: On 7/1/17 2:23 PM, Ingo Lohmar wrote: > I hope I understood the manual/indent idea correctly. Below is the > updated patch including a test file. Looks good, thanks. > I changed the variable name to `js-indent-cont-nonempty-aligned' now > (with "flipped" boolean meaning, as discussed before). This is more > succinct and starts with `js-indent-...' to convey the feature area to > which this setting belongs. OK, it seems better. Still requires effort to decipher the meaning, though. I don't have any better suggestions, so might as well commit this name. > What's the procedure for patches arising from a bug report --- should I > add a NEWS entry (for 26.1, marked +++) and just commit this to master > myself? When a reviewer says "Looks good, please install", or you're feeling confident yourself, yes. On that note, LGTM, please install. :) A NEWS entry for the new variable is a good idea. But "+++" means "all necessary documentation updates are complete". "---", meaning "no change in the manuals is needed", seems more appropriate.