all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Dmitry Gutov <dgutov@yandex.ru>
To: Ingo Lohmar <i.lohmar@gmail.com>
Cc: 27503@debbugs.gnu.org, James Nguyen <jamesn@fastmail.com>,
	james@jojojames.com
Subject: bug#27503: 26.0.50; Not lining up Javascript arguments
Date: Mon, 3 Jul 2017 05:11:30 +0300	[thread overview]
Message-ID: <5f045d58-fff7-446a-44d3-33d093285ef5@yandex.ru> (raw)
In-Reply-To: <877ezs7653.fsf@acer.localhost.com>

On 7/1/17 2:23 PM, Ingo Lohmar wrote:

> I hope I understood the manual/indent idea correctly.  Below is the
> updated patch including a test file.

Looks good, thanks.

> I changed the variable name to `js-indent-cont-nonempty-aligned' now
> (with "flipped" boolean meaning, as discussed before).  This is more
> succinct and starts with `js-indent-...' to convey the feature area to
> which this setting belongs.

OK, it seems better. Still requires effort to decipher the meaning, 
though. I don't have any better suggestions, so might as well commit 
this name.

> What's the procedure for patches arising from a bug report --- should I
> add a NEWS entry (for 26.1, marked +++) and just commit this to master
> myself?

When a reviewer says "Looks good, please install", or you're feeling 
confident yourself, yes. On that note, LGTM, please install. :)

A NEWS entry for the new variable is a good idea. But "+++" means "all 
necessary documentation updates are complete". "---", meaning "no change 
in the manuals is needed", seems more appropriate.





  reply	other threads:[~2017-07-03  2:11 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-06-27  1:49 bug#27503: 26.0.50; Not lining up Javascript arguments James Nguyen
2017-06-27 18:16 ` Ingo Lohmar
2017-06-27 19:42   ` James Nguyen
2017-06-27 20:44     ` Ingo Lohmar
2017-06-28  0:45       ` James Nguyen
2017-06-28 10:36     ` Dmitry Gutov
2017-06-28 10:57     ` Nicolas Petton
2017-06-28 10:35   ` Dmitry Gutov
2017-06-28 14:56     ` Ingo Lohmar
2017-06-29  0:52       ` Dmitry Gutov
2017-07-01 11:23         ` Ingo Lohmar
2017-07-03  2:11           ` Dmitry Gutov [this message]
2017-07-03 18:05             ` Ingo Lohmar
2017-07-03 18:21               ` Ingo Lohmar
2017-07-03 21:01                 ` Dmitry Gutov
2017-07-03 23:14                   ` James Nguyen
2017-07-03 20:17               ` Dmitry Gutov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5f045d58-fff7-446a-44d3-33d093285ef5@yandex.ru \
    --to=dgutov@yandex.ru \
    --cc=27503@debbugs.gnu.org \
    --cc=i.lohmar@gmail.com \
    --cc=james@jojojames.com \
    --cc=jamesn@fastmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.