From: Dmitry Gutov <dgutov@yandex.ru>
To: Matthias Meulien <orontee@gmail.com>, emacs-devel <emacs-devel@gnu.org>
Subject: Re: js-mode default binding for js-find-symbol
Date: Sun, 10 May 2020 03:29:25 +0300 [thread overview]
Message-ID: <5eb2849d-9ca0-d92b-0d4d-c46635a338ff@yandex.ru> (raw)
In-Reply-To: <MG33AQ.7AZV9YXZYVZ02@gmail.com>
On 10.05.2020 00:53, Matthias Meulien wrote:
> Would it be ok to remove the default binding of `js-find-symbol` in js.el?
>
> Current binding (M-.) hides the default binding for `xref-find-definition`.
You're right, it's a problem.
> Since packages like eglot or lsp-mode provide the necessary backend for
> xref to do the right job, I found it confusing to have to reenable the
> default global keybinding for buffers visiting files in js-mode...
I wouldn't outright remove it, though (unless we found it never works; I
just tried it, and it kind of does, in certain cases).
We should turn it into an xref backend instead.
next prev parent reply other threads:[~2020-05-10 0:29 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-09 21:53 js-mode default binding for js-find-symbol Matthias Meulien
2020-05-10 0:29 ` Dmitry Gutov [this message]
2020-05-10 15:15 ` Matthias Meulien
2023-11-02 23:44 ` Dmitry Gutov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5eb2849d-9ca0-d92b-0d4d-c46635a338ff@yandex.ru \
--to=dgutov@yandex.ru \
--cc=emacs-devel@gnu.org \
--cc=orontee@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.