From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Drew Adams Newsgroups: gmane.emacs.devel Subject: RE: master 71783e9: Add the string-numeric-lessp function Date: Sun, 6 Mar 2016 18:27:50 -0800 (PST) Message-ID: <5ea313cd-bc7f-4c18-abe3-69bcc4838cbf@default> References: <20160221043348.25201.81719@vcs.savannah.gnu.org> <87twl2fzaw.fsf@gnus.org> <56CA2C66.7040306@cs.ucla.edu> <87povpzc9c.fsf@gnus.org> <56CA8578.2030004@cs.ucla.edu> <87twl1xul1.fsf@gnus.org> <56CA8BB8.6040908@cs.ucla.edu> <8737s3jfrr.fsf@mail.linkov.net> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Trace: ger.gmane.org 1457317789 5340 80.91.229.3 (7 Mar 2016 02:29:49 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Mon, 7 Mar 2016 02:29:49 +0000 (UTC) Cc: Lars Ingebrigtsen , emacs-devel@gnu.org To: Juri Linkov , Paul Eggert Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon Mar 07 03:29:37 2016 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1ackvQ-0007O0-I4 for ged-emacs-devel@m.gmane.org; Mon, 07 Mar 2016 03:29:36 +0100 Original-Received: from localhost ([::1]:53034 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ackvP-0002xu-Bw for ged-emacs-devel@m.gmane.org; Sun, 06 Mar 2016 21:29:35 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:43014) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1acktr-0000iX-Og for emacs-devel@gnu.org; Sun, 06 Mar 2016 21:28:00 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ackto-0008Hs-HO for emacs-devel@gnu.org; Sun, 06 Mar 2016 21:27:59 -0500 Original-Received: from userp1040.oracle.com ([156.151.31.81]:29071) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ackto-0008Hk-9R for emacs-devel@gnu.org; Sun, 06 Mar 2016 21:27:56 -0500 Original-Received: from userv0022.oracle.com (userv0022.oracle.com [156.151.31.74]) by userp1040.oracle.com (Sentrion-MTA-4.3.2/Sentrion-MTA-4.3.2) with ESMTP id u272Rr4M001782 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 7 Mar 2016 02:27:53 GMT Original-Received: from aserv0122.oracle.com (aserv0122.oracle.com [141.146.126.236]) by userv0022.oracle.com (8.14.4/8.13.8) with ESMTP id u272RqWJ031491 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=FAIL); Mon, 7 Mar 2016 02:27:53 GMT Original-Received: from abhmp0002.oracle.com (abhmp0002.oracle.com [141.146.116.8]) by aserv0122.oracle.com (8.13.8/8.13.8) with ESMTP id u272RphP029459; Mon, 7 Mar 2016 02:27:52 GMT In-Reply-To: <8737s3jfrr.fsf@mail.linkov.net> X-Priority: 3 X-Mailer: Oracle Beehive Extensions for Outlook 2.0.1.9 (901082) [OL 12.0.6691.5000 (x86)] X-Source-IP: userv0022.oracle.com [156.151.31.74] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.4.x-2.6.x [generic] X-Received-From: 156.151.31.81 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:201034 Archived-At: `string-numeric-lessp' really should follow the Emacs convention and be called `string-numeric-less-p'. It's not because `string-less-p' is misnamed that we should add to this mistake. `time-less-p' is correctly named, for example. Or else the rule should be clarified to incorporate `-lessp' exceptions, so they are within, and not outside, the rule. The following 25 are the only such misnamed predicates I see (in a pretty minimal setup - there may be some more in Gnus, Org, etc.). 6 of them end in `-lessp'. auth-source-specmatchp bool-vector-subsetp byte-compile-nilconstp byte-compile-trueconstp byte-optimize-all-constp byte-optimize-zerop cl--compiler-macro-typep cl--macroexp-fboundp coding-system-lessp custom-facep customize-version-lessp default-boundp dired-tree-lessp eieio--typep file-attributes-lessp gnus-boundp gnutls-error-fatalp gnutls-errorp hack-one-local-variable-constantp hack-one-local-variable-eval-safep hack-one-local-variable-quotep ls-lisp-string-lessp slot-boundp string-lessp uniquify-item-greaterp That's 25 out of 438 predicates total whose names end in `p', which I count at the outset in a pretty minimal setup. So less than 6% of predicate names that end in `p' do not follow the rule. 94% follow it correctly. The following predicates are also wrongly named, but they should not have prefix `cl-' anyway. Remove the misguided prefix and these names will all follow the rule. cl-endp cl-equalp cl-evenp cl-minusp cl-oddp cl-plusp cl-subsetp cl-tailp cl-typep