From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Drew Adams Newsgroups: gmane.emacs.bugs Subject: bug#36167: [PATCH] Replace manually crafted hex regexes with [[:xdigit:]] Date: Tue, 11 Jun 2019 10:19:17 -0700 (PDT) Message-ID: <5e87c0dd-1554-4192-b7c1-00212e0be1e0@default> References: <1560263874.21373.1@yandex.ru> <5f7ea771-2a22-ba10-b3ce-6adb5e85dc9d@cs.ucla.edu> <85476B58-4CBD-45C9-903C-5E49D8E5D019@acm.org> <83zhmo834p.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="193118"; mail-complaints-to="usenet@blaine.gmane.org" Cc: mattiase@acm.org, eggert@cs.ucla.edu, 36167@debbugs.gnu.org, hi-angel@yandex.ru To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Jun 11 19:32:45 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hakdZ-000o4l-AB for geb-bug-gnu-emacs@m.gmane.org; Tue, 11 Jun 2019 19:32:45 +0200 Original-Received: from localhost ([::1]:33330 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hakdY-0004lg-6f for geb-bug-gnu-emacs@m.gmane.org; Tue, 11 Jun 2019 13:32:44 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:33784) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hakd1-0003hg-JV for bug-gnu-emacs@gnu.org; Tue, 11 Jun 2019 13:32:12 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hakRG-0000oZ-Hg for bug-gnu-emacs@gnu.org; Tue, 11 Jun 2019 13:20:04 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:46563) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hakRG-0000nq-D4 for bug-gnu-emacs@gnu.org; Tue, 11 Jun 2019 13:20:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1hakRG-0001y5-7o for bug-gnu-emacs@gnu.org; Tue, 11 Jun 2019 13:20:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Drew Adams Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 11 Jun 2019 17:20:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 36167 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 36167-submit@debbugs.gnu.org id=B36167.15602735727523 (code B ref 36167); Tue, 11 Jun 2019 17:20:02 +0000 Original-Received: (at 36167) by debbugs.gnu.org; 11 Jun 2019 17:19:32 +0000 Original-Received: from localhost ([127.0.0.1]:60107 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hakQl-0001xH-Se for submit@debbugs.gnu.org; Tue, 11 Jun 2019 13:19:32 -0400 Original-Received: from aserp2130.oracle.com ([141.146.126.79]:37404) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hakQk-0001x3-Ji for 36167@debbugs.gnu.org; Tue, 11 Jun 2019 13:19:31 -0400 Original-Received: from pps.filterd (aserp2130.oracle.com [127.0.0.1]) by aserp2130.oracle.com (8.16.0.27/8.16.0.27) with SMTP id x5BHIugc046639; Tue, 11 Jun 2019 17:19:20 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=mime-version : message-id : date : from : sender : to : cc : subject : references : in-reply-to : content-type : content-transfer-encoding; s=corp-2018-07-02; bh=ESP7FaV3GfplC4iORY4QHFIAvmRClXPjEyU4sKW9wL0=; b=Xab6+DN/+zGEH4Gt6L8CsdR+Fk+AcvZO6ntck6vCYCGUY/VQ4yA0+ZmWcko88nMUP/aF 8813J8dZ5Dtot3FT9KPEDoE0lW1iuzByLxAEnXVuMh3ip81w9Oj3KHTlxZhgQEO5k01N gJDRIi9caRsIbfQ2txG9Y6EvDNqskP0TiMo+UO1bqnpFKwjvRa4ZLDAy++t4nQ5Cu1Tw XPioi+dKcbEbzpGrYokozDlCnfYdSSPU3GV3Qi4NNbOrYmpnqWpozP3JCGh/NsP3hLBb N0lfVaxfaVrMD2AAXSlGOo7q8IpMTTzIcvgBMHgh6lTqei/6Ez+R4ZDQS0DHDjrTykGq nw== Original-Received: from userp3020.oracle.com (userp3020.oracle.com [156.151.31.79]) by aserp2130.oracle.com with ESMTP id 2t02heps3t-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 11 Jun 2019 17:19:19 +0000 Original-Received: from pps.filterd (userp3020.oracle.com [127.0.0.1]) by userp3020.oracle.com (8.16.0.27/8.16.0.27) with SMTP id x5BHIn7A076748; Tue, 11 Jun 2019 17:19:19 GMT Original-Received: from aserv0121.oracle.com (aserv0121.oracle.com [141.146.126.235]) by userp3020.oracle.com with ESMTP id 2t1jphjkrm-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 11 Jun 2019 17:19:19 +0000 Original-Received: from abhmp0011.oracle.com (abhmp0011.oracle.com [141.146.116.17]) by aserv0121.oracle.com (8.14.4/8.13.8) with ESMTP id x5BHJHjD029150; Tue, 11 Jun 2019 17:19:17 GMT In-Reply-To: <83zhmo834p.fsf@gnu.org> X-Priority: 3 X-Mailer: Oracle Beehive Extensions for Outlook 2.0.1.9.1 (1003210) [OL 16.0.4861.0 (x86)] X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9284 signatures=668687 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=18 malwarescore=0 phishscore=0 bulkscore=0 spamscore=0 mlxscore=0 mlxlogscore=715 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1810050000 definitions=main-1906110111 X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9284 signatures=668687 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 priorityscore=1501 malwarescore=0 suspectscore=18 phishscore=0 bulkscore=0 spamscore=0 clxscore=1015 lowpriorityscore=0 mlxscore=0 impostorscore=0 mlxlogscore=767 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1810050000 definitions=main-1906110111 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:160391 Archived-At: > > > [0-9A-Fa-f] still has one advantage: the reader, and the > > > writer, know exactly which characters are included without looking it= up. > For > > > example: > > > > > > - whether upper case, lower case, or both are accepted > > > - whether non-ascii digits are accepted (included in [:digit:] on man= y > > > platforms) > > > > +1. At least the doc for [:digit:] should say exactly > > what it matches. Then it'll be clear for readers and > > writers. >=20 > Isn't it clear already? I meant [:xdigit:], not [:digit:], in my reply. Sorry for the typo.