From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.bugs Subject: bug#68377: Cannot commit parts of *vc-diff* on Microsoft Windows Date: Sat, 10 Feb 2024 13:44:00 +0200 Message-ID: <5e669d92-7fa8-495c-8df2-c9f712118d51@gutov.dev> References: <87le8wy65p.fsf@gnu.org> <83r0iokq9q.fsf@gnu.org> <65db305f-0606-445b-b034-fc069800a244@gutov.dev> <83jzogkjv5.fsf@gnu.org> <7b1d2533-b214-4646-9145-5de678759009@gutov.dev> <83ttnfeuim.fsf@gnu.org> <86y1cb87k3.fsf@gnu.org> <86il2wvj3e.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="16588"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mozilla Thunderbird Cc: 68377-done@debbugs.gnu.org To: Eli Zaretskii , sds@gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Feb 10 12:52:06 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rYltu-00044Z-8S for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 10 Feb 2024 12:52:06 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rYltc-0006LE-4R; Sat, 10 Feb 2024 06:51:48 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rYlta-0006L0-Jy for bug-gnu-emacs@gnu.org; Sat, 10 Feb 2024 06:51:46 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rYlta-0004Sj-Bv for bug-gnu-emacs@gnu.org; Sat, 10 Feb 2024 06:51:46 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1rYltp-0001ct-Sb for bug-gnu-emacs@gnu.org; Sat, 10 Feb 2024 06:52:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Dmitry Gutov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 10 Feb 2024 11:52:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 68377 X-GNU-PR-Package: emacs Original-Received: via spool by 68377-done@debbugs.gnu.org id=D68377.17075658906177 (code D ref 68377); Sat, 10 Feb 2024 11:52:01 +0000 Original-Received: (at 68377-done) by debbugs.gnu.org; 10 Feb 2024 11:51:30 +0000 Original-Received: from localhost ([127.0.0.1]:35284 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rYltK-0001bY-Bx for submit@debbugs.gnu.org; Sat, 10 Feb 2024 06:51:30 -0500 Original-Received: from out2-smtp.messagingengine.com ([66.111.4.26]:55569) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rYltE-0001b3-5M for 68377-done@debbugs.gnu.org; Sat, 10 Feb 2024 06:51:28 -0500 Original-Received: from compute6.internal (compute6.nyi.internal [10.202.2.47]) by mailout.nyi.internal (Postfix) with ESMTP id 3BF255C00AC; Sat, 10 Feb 2024 06:44:03 -0500 (EST) Original-Received: from mailfrontend1 ([10.202.2.162]) by compute6.internal (MEProxy); Sat, 10 Feb 2024 06:44:03 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gutov.dev; h=cc :cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to; s=fm2; t=1707565443; x=1707651843; bh=XgmO4T7Cuki5guLygGrp1LibJQ8OfIvgyTSWFC8wSqA=; b= GKG4zjoe8zheKwFwvNgtuWJZoLVNL2Eog2o76KkLnMo/Ewtr2XyiZlTdeSnitJd9 FW+X7Eet3qzvgsWHvBUrDkmKC3TYviURxBdynBQXkWCxTqMdiIn5XVBgnFyIAmjr sCaGAt3XDZU23+U3MEOZJhyrM/bkaYrE61NzIsXyxLJjk0x+puAvmnz0fmJnVMjm Q+UCOGXSDCuU54JddbOCMMepivmTkbIyH1vQhZmZbw+WCMWxKCz7J+qL014AfzkY 0/tQYD6cQKbPuK8l3YVOEzAJNq8heXJa6ZISevRJVss6S20muCeaXciQTUKWHBe6 Csw9VtwbdhYTdiFDMsyaaQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm3; t=1707565443; x= 1707651843; bh=XgmO4T7Cuki5guLygGrp1LibJQ8OfIvgyTSWFC8wSqA=; b=L QvrajskDtZnuf0Dy/UHRkTPwf2BUCIkcE/fBGmA1Sq6QFQOMKoLRIfiXkSs2fbYG /6UUZMO7K14S/QbP/EgIFXzQOUdSv007ghn0qzETGsVEqhsp0a5cSKM6TQEcr+qC zA1m3Wo1aRtPGztH4KOPuFC4vyPOAy//KABsR1DBHMBPyhf2c3saVMMY5hZ0I5VS d2WKd4WO/goLV/ipBfznbtiSvMij3/ybgbk78ni6picNR9N0sTcoFg1jRi9ydBFH jkg07qfKr5eJvOV1iJ6Yw0aTbnxYoLgMfQs9t6FXA0BuEi5V6x5wl9/cdTXRVqkX fNSNbSTztF9TiC7m00JAg== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvledrtdelgddtiecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefkffggfgfuvfevfhfhjggtgfesthejredttddvjeenucfhrhhomhepffhmihht rhihucfiuhhtohhvuceoughmihhtrhihsehguhhtohhvrdguvghvqeenucggtffrrghtth gvrhhnpeffueejtefhiefgkeektdejgefhgeeujeefkeevieehieelffduhfehjedutedt vdenucffohhmrghinhepshhtrggtkhgvgigthhgrnhhgvgdrtghomhdpghhnuhdrohhrgh enucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpegumhhi thhrhiesghhuthhovhdruggvvh X-ME-Proxy: Feedback-ID: i0e71465a:Fastmail Original-Received: by mail.messagingengine.com (Postfix) with ESMTPA; Sat, 10 Feb 2024 06:44:02 -0500 (EST) Content-Language: en-US In-Reply-To: <86il2wvj3e.fsf@gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:279750 Archived-At: On 10/02/2024 10:06, Eli Zaretskii wrote: >> Cc: 68377@debbugs.gnu.org, dmitry@gutov.dev >> Date: Sat, 27 Jan 2024 11:11:24 +0200 >> From: Eli Zaretskii >> >> Ping! Sam, would you please try this on the master branch? >> >>> Cc: 68377@debbugs.gnu.org, sds@gnu.org >>> Date: Sun, 14 Jan 2024 18:42:41 +0200 >>> From: Eli Zaretskii >>> >>>> Date: Thu, 11 Jan 2024 17:07:48 +0200 >>>> From: Dmitry Gutov >>>> Cc: 68377@debbugs.gnu.org, sds@gnu.org >>>> >>>> On 11/01/2024 16:47, Eli Zaretskii wrote: >>>>>> Date: Thu, 11 Jan 2024 15:19:26 +0200 >>>>>> Cc:68377@debbugs.gnu.org >>>>>> From: Dmitry Gutov >>>>>> >>>>>> On 11/01/2024 14:28, Eli Zaretskii wrote: >>>>>>>> From: Sam Steingold >>>>>>>> Date: Wed, 10 Jan 2024 21:07:14 -0500 >>>>>>>> >>>>>>>> https://emacs.stackexchange.com/q/80039/795 >>>>>>>> >>>>>>>> Emacs has a beautiful feature: in the `*vc-diff*` buffer (generated by [`vc-diff`](https://www.gnu.org/software/emacs/manual/html_node/emacs/Old-Revisions.html) either by C-x v = in a file buffer or by = in a `*vc-dir*` buffer), kill unwanted hunks with k (i.e., [`diff-hunk-kill`](https://www.gnu.org/software/emacs/manual/html_node/emacs/Diff-Mode.html)) and then commit the remaining hunks with C-x v v (i.e., [`vc-next-action`](https://www.gnu.org/software/emacs/manual/html_node/emacs/Basic-VC-Editing.html)). If you don't know about it -- try it, it is incredibly useful! >>>>>>> (I must say that formatting of this report is AWFUL! How can a human >>>>>>> being be expected to read and understand it it?? PLEASE try to make >>>>>>> bug reports more readable in the future.) >>>>>> Looked fine to me. >>>>>> >>>>>> I think the Markdown format is very readable. >>>>> It isn't Markdown that bothered me, it's some kind of HTML mixed in, >>>>> but in an email message whose format is plain text (at least as I got >>>>> it here). >>>> >>>> The tags? These are also supported by Markdown. The links too. >>>> >>>>>> I think this is the same as bug#65049, meaning that it's fixed on >>>>>> master, but not in Emacs 29.1 (which was the version specified in the >>>>>> report). >>>>> Possibly. If Sam says it works for him on master, we will know. >>>> >>>> Yes, let's see what he says. >>> >>> Sam, could you please chime in after testing this in Emacs 30? >>> >>> Thanks. > > No further comments within a month, so I presume the bug is indeed > fixed on master, and I'm therefore closing it. Yes: Sam confirmed that in a SE comment.