all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Nathaniel Flath <flat0103@gmail.com>
To: Glenn Morris <rgm@gnu.org>
Cc: 5556@debbugs.gnu.org
Subject: bug#5556: [PATCH] vc-next-action destroys window configuration
Date: Wed, 10 Feb 2010 03:20:42 -0500	[thread overview]
Message-ID: <5e3a506e1002100020o512d34e7i4d83431d06c0a389@mail.gmail.com> (raw)
In-Reply-To: <mqsk99y2df.fsf@fencepost.gnu.org>


[-- Attachment #1.1: Type: text/plain, Size: 543 bytes --]

Sorry - somehow I ended up attaching an old version of the patch.  The
correct one is attached.

Proposed changelog entry:

Prevent vc actions from destroying window configuration

* vc-dispatcher.el (vc-finish-logentry): Changed delete-windows-on to
quit-window

On Wed, Feb 10, 2010 at 2:30 AM, Glenn Morris <rgm@gnu.org> wrote:

>
> Your patch seems to include a huge number of formatting changes
> throughout the file. Please could you send it again, with just the
> actual relevant changes, and with a proposed ChangeLog entry. Thanks.
>

[-- Attachment #1.2: Type: text/html, Size: 843 bytes --]

[-- Attachment #2: vc.patch --]
[-- Type: text/x-patch, Size: 658 bytes --]

diff --git a/lisp/vc-dispatcher.el b/lisp/vc-dispatcher.el
index bf3da4e..8aa412f 100644
--- a/lisp/vc-dispatcher.el
+++ b/lisp/vc-dispatcher.el
@@ -604,9 +604,8 @@ the buffer contents as a comment."
 	       log-entry))
     ;; Remove checkin window (after the checkin so that if that fails
     ;; we don't zap the log buffer and the typing therein).
-    ;; -- IMO this should be replaced with quit-window
     (cond ((and logbuf vc-delete-logbuf-window)
-	   (delete-windows-on logbuf (selected-frame))
+	   (quit-window t) 
 	   ;; Kill buffer and delete any other dedicated windows/frames.
 	   (kill-buffer logbuf))
 	  (logbuf (pop-to-buffer logbuf)

  reply	other threads:[~2010-02-10  8:20 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-02-10  1:27 bug#5556: [PATCH] vc-next-action destroys window configuration Nathaniel Flath
2010-02-10  7:30 ` Glenn Morris
2010-02-10  8:20   ` Nathaniel Flath [this message]
2011-10-10 18:20 ` bug#5556: " martin rudalics
2011-10-12  7:01   ` martin rudalics

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5e3a506e1002100020o512d34e7i4d83431d06c0a389@mail.gmail.com \
    --to=flat0103@gmail.com \
    --cc=5556@debbugs.gnu.org \
    --cc=rgm@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.