From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Nathaniel Flath Newsgroups: gmane.emacs.bugs Subject: bug#5376: 23.1; dirtrack.el unnecessary errors [PATCH] Date: Fri, 29 Jan 2010 11:17:09 -0800 Message-ID: <5e3a506e1001291117v5e97b451p5f3ad2022764d0f5@mail.gmail.com> References: <874om4k9s6.fsf@stupidchicken.com> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: multipart/alternative; boundary=001636b2ad255fab13047e527b39 X-Trace: ger.gmane.org 1264804769 30284 80.91.229.12 (29 Jan 2010 22:39:29 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Fri, 29 Jan 2010 22:39:29 +0000 (UTC) Cc: 5376@debbugs.gnu.org To: Chong Yidong Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Jan 29 23:39:24 2010 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1NazUp-0001Ia-W5 for geb-bug-gnu-emacs@m.gmane.org; Fri, 29 Jan 2010 23:39:24 +0100 Original-Received: from localhost ([127.0.0.1]:51758 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NazUp-0003qi-AN for geb-bug-gnu-emacs@m.gmane.org; Fri, 29 Jan 2010 17:39:23 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1NawhU-0007V8-Pq for bug-gnu-emacs@gnu.org; Fri, 29 Jan 2010 14:40:16 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1NawhO-0007O9-11 for bug-gnu-emacs@gnu.org; Fri, 29 Jan 2010 14:40:14 -0500 Original-Received: from [199.232.76.173] (port=50285 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NawhN-0007Ni-M9 for bug-gnu-emacs@gnu.org; Fri, 29 Jan 2010 14:40:09 -0500 Original-Received: from debbugs.gnu.org ([140.186.70.43]:37804) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1NawhN-0004XF-2V for bug-gnu-emacs@gnu.org; Fri, 29 Jan 2010 14:40:09 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.69) (envelope-from ) id 1NawLy-0007JM-TJ; Fri, 29 Jan 2010 14:18:02 -0500 X-Loop: bug-gnu-emacs@gnu.org Resent-From: Nathaniel Flath Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-To: owner@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 29 Jan 2010 19:18:02 +0000 Resent-Message-ID: Resent-Sender: bug-gnu-emacs@gnu.org X-Emacs-PR-Message: followup 5376 X-Emacs-PR-Package: emacs X-Emacs-PR-Keywords: patch Original-Received: via spool by 5376-submit@debbugs.gnu.org id=B5376.126479263928058 (code B ref 5376); Fri, 29 Jan 2010 19:18:02 +0000 Original-Received: (at 5376) by debbugs.gnu.org; 29 Jan 2010 19:17:19 +0000 Original-Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1NawLE-0007IT-Kl for submit@debbugs.gnu.org; Fri, 29 Jan 2010 14:17:18 -0500 Original-Received: from mail-pz0-f202.google.com ([209.85.222.202]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1NawLD-0007IC-3y for 5376@debbugs.gnu.org; Fri, 29 Jan 2010 14:17:15 -0500 Original-Received: by pzk40 with SMTP id 40so1255781pzk.7 for <5376@debbugs.gnu.org>; Fri, 29 Jan 2010 11:17:10 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:received:in-reply-to:references :date:message-id:subject:from:to:cc:content-type; bh=S00MMsqiDhGrDiFViTq5V7IvaGDvYxo3osoHNlXdlF8=; b=RpJPPoeY66f+roMCD5BymkfOuWUl8Zc6PyDBV/JtzyuJ5lioKuvDEYtgg30b8OVj93 qytG6Q9mh7OcXKScdSwDQkq4CRr/4lDU+W2KDlpA8WkYGjP9XiccjYfunmwAFbjtVIs0 uTuYBp1hoyBnfu9jmPWq3Tis3ySyAdjAR8A24= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; b=qD3BVQepj7NRe37xdvhUda2JRZSQVi6wPKKYbhPGwCAsOLAkDf2u9Yp50wMtu36E/C /3Gp7mZ5NKJop72lvHrCqrwBg4RTgPUzQbFMmm28frrQwRN24gaJgogsOBC6184VKcrG QLE523nOacJdn7UoQueYmtmbjUl7rSuIMmKJw= Original-Received: by 10.140.58.9 with SMTP id g9mr826139rva.39.1264792629127; Fri, 29 Jan 2010 11:17:09 -0800 (PST) In-Reply-To: <874om4k9s6.fsf@stupidchicken.com> X-Spam-Score: -3.4 (---) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list X-Spam-Score: -3.3 (---) Resent-Date: Fri, 29 Jan 2010 14:18:02 -0500 X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 3) X-Mailman-Approved-At: Fri, 29 Jan 2010 17:39:19 -0500 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:34808 Archived-At: --001636b2ad255fab13047e527b39 Content-Type: text/plain; charset=ISO-8859-1 If it warns, please ensure that it still returns the input string it recieved; otherwise, the output to the shell buffer is affected. On Fri, Jan 29, 2010 at 11:09 AM, Chong Yidong wrote: > > dirtrack.el can occasionally call a signal an error when it's regex > > matches a directory that does not exist. This is generally called when > > dirtrack-list is slightly incorrect, but this is a hard variable to get > > precise, for some prompts; in the cases where it matches a non-existent > > directory, I believe it should print the input as normal, instead of > > swallowing it and erroring. > > I have changed it to use `warn' instead of `error'. > --001636b2ad255fab13047e527b39 Content-Type: text/html; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable If it warns, please ensure that it still returns the input string it reciev= ed; otherwise, the output to the shell buffer is affected.=A0

On Fri, Jan 29, 2010 at 11:09 AM, Chong Yidong <cyd@stupidchicken.= com> wrote:
> dirtrack.el = can occasionally call a signal an error when it's regex
> matches a directory that does not exist. =A0This is generally called w= hen
> dirtrack-list is slightly incorrect, but this is a hard variable to ge= t
> precise, for some prompts; in the cases where it matches a non-existen= t
> directory, I believe it should print the input as normal, instead of > swallowing it and erroring.

I have changed it to use `warn' instead of `error'.

--001636b2ad255fab13047e527b39--