From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Nathaniel Flath Newsgroups: gmane.emacs.bugs Subject: bug#5376: 23.1; dirtrack.el unnecessary errors [PATCH] Date: Thu, 14 Jan 2010 10:37:58 -0500 Message-ID: <5e3a506e1001140737q172bd0eep5ab8b98519a3e10a@mail.gmail.com> References: <87tyup4eji.fsf@nflath-laptop.i-did-not-set--mail-host-address--so-tickle-me> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: multipart/alternative; boundary=000e0cd11968f0a4c3047d21ab27 X-Trace: ger.gmane.org 1263488034 7914 80.91.229.12 (14 Jan 2010 16:53:54 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Thu, 14 Jan 2010 16:53:54 +0000 (UTC) Cc: 5376@debbugs.gnu.org To: Stefan Monnier Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Thu Jan 14 17:53:47 2010 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1NVSwz-0007NB-JX for geb-bug-gnu-emacs@m.gmane.org; Thu, 14 Jan 2010 17:53:38 +0100 Original-Received: from localhost ([127.0.0.1]:39316 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NVSx0-0008Jt-FF for geb-bug-gnu-emacs@m.gmane.org; Thu, 14 Jan 2010 11:53:38 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1NVRwr-00022Y-UU for bug-gnu-emacs@gnu.org; Thu, 14 Jan 2010 10:49:26 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1NVRwl-0001un-IC for bug-gnu-emacs@gnu.org; Thu, 14 Jan 2010 10:49:24 -0500 Original-Received: from [199.232.76.173] (port=58807 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NVRwk-0001uE-W3 for bug-gnu-emacs@gnu.org; Thu, 14 Jan 2010 10:49:19 -0500 Original-Received: from debbugs.gnu.org ([140.186.70.43]:47141) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1NVRwj-0006Ha-HF for bug-gnu-emacs@gnu.org; Thu, 14 Jan 2010 10:49:17 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.69) (envelope-from ) id 1NVRmo-0001XK-60; Thu, 14 Jan 2010 10:39:02 -0500 X-Loop: bug-gnu-emacs@gnu.org Resent-From: Nathaniel Flath Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-To: owner@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 14 Jan 2010 15:39:02 +0000 Resent-Message-ID: Resent-Sender: bug-gnu-emacs@gnu.org X-Emacs-PR-Message: followup 5376 X-Emacs-PR-Package: emacs X-Emacs-PR-Keywords: Original-Received: via spool by 5376-submit@debbugs.gnu.org id=B5376.12634834885878 (code B ref 5376); Thu, 14 Jan 2010 15:39:02 +0000 Original-Received: (at 5376) by debbugs.gnu.org; 14 Jan 2010 15:38:08 +0000 Original-Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1NVRlv-0001Wl-6X for submit@debbugs.gnu.org; Thu, 14 Jan 2010 10:38:07 -0500 Original-Received: from mail-pz0-f172.google.com ([209.85.222.172]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1NVRls-0001WM-E3 for 5376@debbugs.gnu.org; Thu, 14 Jan 2010 10:38:06 -0500 Original-Received: by pzk2 with SMTP id 2so491564pzk.21 for <5376@debbugs.gnu.org>; Thu, 14 Jan 2010 07:37:59 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:received:in-reply-to:references :date:message-id:subject:from:to:cc:content-type; bh=xXwYE9rgkL0rrm+BMciKh4c5+K47NsWUwOmyz8FVP0Q=; b=vaggE0il/HDQqnhSMo7/ptKcly8JM561YzknzEOmiQXojy7ApITLEY6ttkHsiZ7evz WPLdNKLRnOWZ5xcuMdlC6rOpdxOACWIGx5H2jQHtLNJvAgXpsCK3ijD3yvRUjTB39PK3 y7xRoI/UqFYLFax3qR+kQpq3s7ObZyO76eAPk= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; b=rtP5foRgzzZ4GrxXR/t85QqGhTrQiZXjABkqTYdHBVCw/3S/a3w/aoMmR1gMiwuU70 cUJiCX14ocXhqa/1W6GY3IKSwRZf0sQGej8LVCwtDH8O7u7Brscua51SLzfeQQCwUzH2 z0pVF/JrIbF1eQunWKRwfxN8cqt2Me+6jDNJc= Original-Received: by 10.141.90.2 with SMTP id s2mr677997rvl.273.1263483478909; Thu, 14 Jan 2010 07:37:58 -0800 (PST) In-Reply-To: X-Spam-Score: -4.3 (----) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list X-Spam-Score: -3.7 (---) Resent-Date: Thu, 14 Jan 2010 10:39:02 -0500 X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 3) X-Mailman-Approved-At: Thu, 14 Jan 2010 11:50:52 -0500 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:34331 Archived-At: --000e0cd11968f0a4c3047d21ab27 Content-Type: text/plain; charset=ISO-8859-1 That may be better, yes - the only isue with that is when large chunks of input are messaged due to a improper match, which could still be annoying. However, that is probably fine, and would let the user know if they were just starting with dirtrack.el that their regex was incorrect. On Thu, Jan 14, 2010 at 10:04 AM, Stefan Monnier wrote: > > RCS file: /sources/emacs/emacs/lisp/dirtrack.el,v > > retrieving revision 1.28 > > diff -u -r1.28 dirtrack.el > > @@ -270,7 +270,7 @@ > > (run-hooks 'dirtrack-directory-change-hook) > > (dirtrack-debug-message > > (format "Changing directory to %s" > prompt-path))) > > - (error "Directory %s does not exist" prompt-path))) > > + input)) > > ))))) > > input) > > I agree it shouldn't signal an error. But we turn the `error' into > a `message', so the user is kept informed of the problem. > > > Stefan > --000e0cd11968f0a4c3047d21ab27 Content-Type: text/html; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable That may be better, yes - the only isue with that is when large chunks of i= nput are messaged due to a improper match, which could still be annoying.= =A0 However, that is probably fine, and would let the user know if they wer= e just starting with dirtrack.el that their regex was incorrect.

On Thu, Jan 14, 2010 at 10:04 AM, Stefan Mon= nier <monn= ier@iro.umontreal.ca> wrote:
> RCS file: /sources/emacs/emacs/lisp/dirtrack.el,v
> retrieving revision 1.28
> diff -u -r1.28 dirtrack.el
> @@ -270,7 +270,7 @@
> =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 (run-hooks 'dirtra= ck-directory-change-hook)
> =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 (dirtrack-debug-messag= e
> =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0(format "Chang= ing directory to %s" prompt-path)))
> - =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0(error "Directory %s does not ex= ist" prompt-path)))
> + =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0input))
> =A0 =A0 =A0 =A0 =A0 =A0 =A0)))))
> =A0 =A0input)

I agree it shouldn't signal an error. =A0But we turn the `error' in= to
a `message', so the user is kept informed of the problem.


=A0 =A0 =A0 =A0Stefan

--000e0cd11968f0a4c3047d21ab27--